Patch Detail
Show a patch.
GET /api/1.1/patches/27291/?format=api
{ "id": 27291, "url": "https://patchwork.libcamera.org/api/1.1/patches/27291/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27291/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260708-libipa-algorithms-v4-26-f0e99f035294@ideasonboard.com>", "date": "2026-07-08T09:25:13", "name": "[v4,26/35] ipa: libipa: lsc: Document Components parsing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3ce41517c19acf30eed6093b595ca996535cab7c", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27291/mbox/", "series": [ { "id": 6046, "url": "https://patchwork.libcamera.org/api/1.1/series/6046/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6046", "date": "2026-07-08T09:24:47", "name": "ipa: libipa: Introduce libipa algorithms", "version": 4, "mbox": "https://patchwork.libcamera.org/series/6046/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27291/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27291/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92DD5C3339\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 8 Jul 2026 09:25:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43CA8660E0;\n\tWed, 8 Jul 2026 11:25:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24DCA660A7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jul 2026 11:25:13 +0200 (CEST)", "from [192.168.1.182] (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 703643FBE;\n\tWed, 8 Jul 2026 11:24:23 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IJzlHq+w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783502663;\n\tbh=rQpuQHXCyAXIKUP2x9f0JycAyoGrS4OUcp9j0GEys7U=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=IJzlHq+wEPs8Ah3e4m48azngswhifYreXNUMDqYTxzsyT6515LISibP1w2RnWaDYy\n\txzJ3ZB46yvtW0uqAXVWgQQyy85cBkSDWUc/WnGUEuuuNKfcoLpkKnb5yHBg0V0L6B4\n\te28STmh27Qkg0m2oIl1Qs05fwe9ya7BELj5YhXks=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 08 Jul 2026 11:25:13 +0200", "Subject": "[PATCH v4 26/35] ipa: libipa: lsc: Document Components parsing", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260708-libipa-algorithms-v4-26-f0e99f035294@ideasonboard.com>", "References": "<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>", "In-Reply-To": "<20260708-libipa-algorithms-v4-0-f0e99f035294@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4242;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=rQpuQHXCyAXIKUP2x9f0JycAyoGrS4OUcp9j0GEys7U=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqThdvUx2HTn43uPFM72pCYALjQRxGvrMNKf2+X\n\t6bpsm35IJKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCak4XbwAKCRByNAaPFqFW\n\tPOs/D/4ptHnIOv5v9D2XusHrbvj03vMPRETg7vzT0zqWTPa8CHGFM6RboCruo2w/VK/Iy+lRyZu\n\tpp8mMq+Gs6U6mEZukVgKoAFfD270gm99O+NMGLZhiGBl08/AriHcP3POlKQ2Df9/L9cn8CaFmzn\n\tW76HbnkldrnHHG60YPnahbITCFopf8BnGpv/QQNz8PQp7/hZ2PVIwAgSb9tDNbC/i96mQV2qOsf\n\t9WWzZYozMIiPgedS1VfS4l6M3rLosBoHUmpSLAOrrfXM/HUpLVKTAilKMF0IK5X3tWHqS3dlKYx\n\tSxBHixHzkTK4k6HxkIUFndTeo+UNbTuzM7MjglN7PmUNJcXGVTmYzY1dl4StZbd+N/oUEmCbVFn\n\tfuhxXm2mLzE2K7yhl/R3E8gy1mGxvR+oi5WCk2BtGs9goHqKc5X+mQk9v+s1JZIjSOnKM7ls+fj\n\toRUqb5XL+vtnmJF1qNA5Zr0TtQ51yf0nuy0k3E5s25qHdiWi4CUhoZZjOJ5kTktUMHTkolBLsxW\n\twnys3qs2NGAbgtqAOukbAd0opq5pqwfwbbm7JRtdV1aMGPP8KVmcVsACwSCyGi//ColeSX729qF\n\tWz/HZ3fqsZEMTuC6UaF7C+MUzYYxQgsih5/iRQUYYB6+VxWOd6+UWuQSgyA7ViUTL+fU47CmVC1\n\t2F7AwZj9WsafJXQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Document with examples how different IPA modules parse the tuning\nfile depending on the number of colour channels they support.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc.cpp | 111 +++++++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 111 insertions(+)", "diff": "diff --git a/src/ipa/libipa/lsc.cpp b/src/ipa/libipa/lsc.cpp\nindex 796c75f6d729..26c3e9968072 100644\n--- a/src/ipa/libipa/lsc.cpp\n+++ b/src/ipa/libipa/lsc.cpp\n@@ -68,6 +68,117 @@ namespace lsc {\n * tables are organized per-colour temperature with per-colour components gain\n * vectors or polynomial coefficients.\n *\n+ * The colour components names are IPA-implementation specific and depend on the\n+ * ISP LSC engine design. Some LSC engine support 4 colour components (r, gr,\n+ * gb, b), some only support 3 colour components (r, g, b). The name (and\n+ * number) of the expected colour components shall be provided to\n+ * LscAlgorithm::init() using the LscDescriptor::keys field.\n+ *\n+ * Example of a tabular lens shading tuning file with 'r', 'g' and 'b' colour\n+ * components. The gain table has been here omitted, but the expected number\n+ * of entries has to be equal to\n+ * LscDescriptor::numHCells * LscDescriptor::numVCells.\n+ *\n+ * \\code{.yaml}\n+ * - Lsc:\n+ * sets:\n+ * - ct: 2500\n+ * r: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * g: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * b: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * - ct: 6500\n+ * r: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * g: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * b: [\n+ * \t.. gains table omitted..\n+ * ]\n+ * \\endcode\n+ *\n+ * Example of a polynomial lens shading tuning file with 'r', 'gr', 'gb' and 'b'\n+ * colour components:\n+ *\n+ * \\code{.yaml}\n+ * - Lsc:\n+ * type: \"polynomial\"\n+ * sets:\n+ * - ct: 2500\n+ * r:\n+ * cx: 0.5006571711950275\n+ * cy: 0.510093737499277\n+ * k0: 1.5393282208428813\n+ * k1: -1.1434559757908016\n+ * k2: 4.332602305814554\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gr:\n+ * cx: 0.5009320529087338\n+ * cy: 0.511208038949085\n+ * k0: 1.5634738574805407\n+ * k1: -1.5623484259968348\n+ * k2: 4.846686073656501\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gb:\n+ * cx: 0.5012013290343839\n+ * cy: 0.5128251541578288\n+ * k0: 1.526147944919103\n+ * k1: -1.4316976083689723\n+ * k2: 4.792604063222728\n+ * k3: 0.0\n+ * k4: 0.0\n+ * b:\n+ * cx: 0.49864139511067784\n+ * cy: 0.5162095081739346\n+ * k0: 1.0405245474038738\n+ * k1: 0.05618339879447103\n+ * k2: 1.8792813594001752\n+ * k3: 0.0\n+ * k4: 0.0\n+ * - ct: 6000\n+ * r:\n+ * cx: 0.5006202239353942\n+ * cy: 0.5099531318307661\n+ * k0: 1.4702946023945032\n+ * k1: -0.8893767547927631\n+ * k2: 3.920547732201387\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gr:\n+ * cx: 0.500907874178317\n+ * cy: 0.511084916024106\n+ * k0: 1.5336172760559457\n+ * k1: -1.39964026514435\n+ * k2: 4.565487728954618\n+ * k3: 0.0\n+ * k4: 0.0\n+ * gb:\n+ * cx: 0.5011898608900477\n+ * cy: 0.5126797906745105\n+ * k0: 1.5013145790354843\n+ * k1: -1.2747407173754124\n+ * k2: 4.514682876897286\n+ * k3: 0.0\n+ * k4: 0.0\n+ * b:\n+ * cx: 0.4987561413116136\n+ * cy: 0.5159619420778772\n+ * k0: 1.0102986422191802\n+ * k1: 0.13263449763985727\n+ * k2: 1.686556107316064\n+ * k3: 0.0\n+ * k4: 0.0\n+ * \\endcode\n+ *\n * At LscAlgorithm::configure() time the LSC tables are re-sampled on the\n * sensor's crop rectangle in use to adapt them to the configuration in use for\n * a streaming session. Polynomial LSC tables support re-sampling and can be\n", "prefixes": [ "v4", "26/35" ] }