Patch Detail
Show a patch.
GET /api/1.1/patches/27233/?format=api
{ "id": 27233, "url": "https://patchwork.libcamera.org/api/1.1/patches/27233/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27233/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260706-libipa-algorithms-v3-33-968757b038bb@ideasonboard.com>", "date": "2026-07-06T08:01:53", "name": "[v3,33/35] ipa: libipa: lsc: Specialize Interpolator for uint8_t", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8cc70f4d288768cb68f0ddf42e1226c4373ac2b1", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27233/mbox/", "series": [ { "id": 6038, "url": "https://patchwork.libcamera.org/api/1.1/series/6038/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6038", "date": "2026-07-06T08:01:20", "name": "ipa: libipa: Introduce libipa algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6038/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27233/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27233/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9043C3308\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2026 08:02:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D2E366071;\n\tMon, 6 Jul 2026 10:02:40 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D558466035\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2026 10:02:19 +0200 (CEST)", "from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 79A243EB5;\n\tMon, 6 Jul 2026 10:01:31 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tmvWBUF5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324891;\n\tbh=V4MaF45qbZhRRiHabRO68RMnvgHcBtsHCDtfQ962rIU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=tmvWBUF5w0+NJgvwozZjt/qhR3T/5dVXXoC0yDTIp/k9Nng1hFaIz18C2TAOcVbky\n\t8at3UPYQT9afEF7ogJHizW1j2BYIL3mTUrloIGfrkcUdojjp3thcuRE+upvdRcWiVt\n\tsGCtSvsDfUTLed4Zd+rogDo++pYkV7mWo2OscLqI=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 06 Jul 2026 10:01:53 +0200", "Subject": "[PATCH v3 33/35] ipa: libipa: lsc: Specialize Interpolator for\n\tuint8_t", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260706-libipa-algorithms-v3-33-968757b038bb@ideasonboard.com>", "References": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "In-Reply-To": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1736;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=V4MaF45qbZhRRiHabRO68RMnvgHcBtsHCDtfQ962rIU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2Dz8wOzUM/vbrbq8U8GYIx5VplZAn3QJHgB1\n\t54zIBFVUiqJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8wAKCRByNAaPFqFW\n\tPOsQEACrM8/Q1t7nUZO7z2hsLj+my0Q2hvTODDindgikwhrzFJ2AoKyJIoYUXjSi5z4VxdcK2VQ\n\tkWStp4GCOpw8ionp769XJWC6AQMwLosBmZZUTuBzD+eJD5hqnyDohGBywUbkF9WeWy70+0pQWu8\n\tXUFSkPTpl8fdyoxmm6rp8X2JqGI6iiKvD0DvbKGXJedABNHXaWhkfu4V2ZjEWlr13O6QETFSRyd\n\tjdMSo70Hn2H781uRL5/KsYoCpIr496DGlkmqLaPIb2vJVkXFok2BTcgdxa1ueBYYFBcNmFsoiMI\n\tuuP/i5GNNFfZr0quOMqdgajPYRQKjRBBJhU750YFvMqrV/AIGDtilEb2rzzer8ESXEwr83cBa74\n\t9ywpUpStY5q1dGLcrygvjRNlh80Eow1QA5KZnToIkFxwJS0peUqPnF/ys8dcd4EopFnE3es008f\n\tYUfDyxqEmwsDb0JU4yl++UecZAut9icj54NPIN/h8C0MuIxebOsNYa2ny6uo4eJRHl4WQCZI+G6\n\tBnRLSJXBCjpSufYMfdZ/p/OgDSMwU5CD7+GeAZbJwR/ef/5OAaLuv0nIhefiTM80uADgNTwyE9H\n\tRMwemdrFKImk/w7fH/ylW/bE2b+D2niUYF/XTwI2ZERl2BUQQXA34BOJge8jGPgfC0uQqGqu3Rk\n\tBhtychCyAGJB3nA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Mali-C55 LSC algorithm uses 8-bit gain values.\n\nSpecialize Interpolator<lsc::Components>> for uint8_t to prevent the\nuint16_t specialization from being selected.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_base.cpp | 11 +++++++++++\n src/ipa/libipa/lsc_base.h | 7 +++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex f47c9619669e..3ab1c75c4310 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -63,6 +63,17 @@ namespace lsc {\n } /* namespace lsc */\n \n #ifndef __DOXYGEN__\n+template<>\n+void Interpolator<lsc::Components<uint8_t>>::\n+\tinterpolate(const lsc::Components<uint8_t> &a,\n+\t\t const lsc::Components<uint8_t> &b,\n+\t\t lsc::Components<uint8_t> &dest,\n+\t\t double lambda)\n+{\n+\tfor (auto const &[k, v] : a)\n+\t\tinterpolateVector(v, b.at(k), dest[k], lambda);\n+}\n+\n template<>\n void Interpolator<lsc::Components<uint16_t>>::\n \tinterpolate(const lsc::Components<uint16_t> &a,\ndiff --git a/src/ipa/libipa/lsc_base.h b/src/ipa/libipa/lsc_base.h\nindex a25d951e8ddb..51f3dd91f547 100644\n--- a/src/ipa/libipa/lsc_base.h\n+++ b/src/ipa/libipa/lsc_base.h\n@@ -49,6 +49,13 @@ void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,\n \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n }\n \n+template<>\n+void Interpolator<lsc::Components<uint8_t>>::\n+\tinterpolate(const lsc::Components<uint8_t> &a,\n+\t\t const lsc::Components<uint8_t> &b,\n+\t\t lsc::Components<uint8_t> &dest,\n+\t\t double lambda);\n+\n template<>\n void Interpolator<lsc::Components<uint16_t>>::\n \tinterpolate(const lsc::Components<uint16_t> &a,\n", "prefixes": [ "v3", "33/35" ] }