Patch Detail
Show a patch.
GET /api/1.1/patches/27218/?format=api
{ "id": 27218, "url": "https://patchwork.libcamera.org/api/1.1/patches/27218/?format=api", "web_url": "https://patchwork.libcamera.org/patch/27218/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260706-libipa-algorithms-v3-18-968757b038bb@ideasonboard.com>", "date": "2026-07-06T08:01:38", "name": "[v3,18/35] ipa: libipa: lsc_base: Add sampleForCrop documentation", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6346f14b7d44a3c7b2d04adc8b8cfa27e2c33ad3", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/27218/mbox/", "series": [ { "id": 6038, "url": "https://patchwork.libcamera.org/api/1.1/series/6038/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6038", "date": "2026-07-06T08:01:20", "name": "ipa: libipa: Introduce libipa algorithms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/6038/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/27218/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/27218/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC0E2C3308\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 6 Jul 2026 08:02:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6BB8866050;\n\tMon, 6 Jul 2026 10:02:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49A3866020\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 6 Jul 2026 10:02:09 +0200 (CEST)", "from [192.168.125.177] (mob-109-113-60-81.net.vodafone.it\n\t[109.113.60.81])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04E4E3FB2;\n\tMon, 6 Jul 2026 10:01:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WC6IXRhI\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1783324881;\n\tbh=Xw4RkjyI4aHlrd1nRNO7E5mB7e/vwariTzp8M0iWH74=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=WC6IXRhIxStTzidNWmARvet7bYiDa7ZGP+lCoIuTfhQWXLjk4IVbGb6uObke7hUeI\n\trQC70ILkPQxmuLsD0xdgbFZSKTZqr/iIi8DstVgjDZISdu8GEv5YEo8tqz1H0EGO1i\n\tsSAuf+5fRjxAkvXVyxN1oDaUJIv4YAdHoacn97jE=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 06 Jul 2026 10:01:38 +0200", "Subject": "[PATCH v3 18/35] ipa: libipa: lsc_base: Add sampleForCrop\n\tdocumentation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260706-libipa-algorithms-v3-18-968757b038bb@ideasonboard.com>", "References": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "In-Reply-To": "<20260706-libipa-algorithms-v3-0-968757b038bb@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org, \n\tStefan Klug <stefan.klug@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1444;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=Xw4RkjyI4aHlrd1nRNO7E5mB7e/vwariTzp8M0iWH74=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBqS2DxKro/8/JRvI4o0UshwHU/rSjaES0TMev6X\n\tPJ+6amKxM6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaktg8QAKCRByNAaPFqFW\n\tPGzcEACZZhY8Wq07MAAzpMQ3Iv0E9rJIlBa1rIBPf0130Ob7EAvPaSR52ZyW21TOef9wQMDFTH4\n\tcqAVpTeSwZQfGLAY9xv5MXpB/BXKpWXOSyLGZeonEX1Coodd74vzNc5qaGcZFD2m8IEss0t0Hgz\n\t2lgAL8h51FvuUQx82XsQOo4wPubFwc4YglGnfTqihYufoYGx/c0jksambfBSA2Ci8+rGMZoDZPc\n\tKqGgA0XzCTtfNdgD0qxhHTiin2vNUaOcbW3DzNfWIPjpwU2aTzAmA4TJsFAGoZLu8j3MxhOV9cW\n\t4PDakIGGy5qe/dtyBACAZIxANxaGKQqGcliKag6ZrQtcnCs8kqAbHGiG9UjqvodAB+062ZYXind\n\twXNfUGDBrzLae3MkOdmG0UbDgK5nvjHRqwQYVgF+r5751/xp5yakD3beKnk20WjuyxsfPkD/3sH\n\tjNZb+0pEQqIqYaAsWzWt0vDvzcbq1lQVlAK+vATIxy63NSUhYY+focX/prLeM7tHISKywThV5lC\n\tyaW8njyd/+6MsGwIhRpNJJkPG61jCM5GJ/tANEIBt3GFbFRGv3DJ6KpLD1dofar76ZDq32Pe33G\n\tfua5NiL+0kAOWb4k/dysG6bBa2vAdHfUn1zWul77o9XQJn9v3F48mFuhz0mFlbtpUu0GWIbl+FM\n\tjXvOxkr4T3ikwsQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now that we have two in-tree implementations of LscImplementation\ndetail how the two perform lsc gain re-sampling.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/libipa/lsc_base.cpp | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)", "diff": "diff --git a/src/ipa/libipa/lsc_base.cpp b/src/ipa/libipa/lsc_base.cpp\nindex bddf131b85e2..b055249c066a 100644\n--- a/src/ipa/libipa/lsc_base.cpp\n+++ b/src/ipa/libipa/lsc_base.cpp\n@@ -103,6 +103,21 @@ void Interpolator<lsc::Components>::\n * each segment of size 0.0625 and the list of nodes position will be\n * [0, 0.0625, 0.125, 0.1875, ... , 1]. It is expected that the first position\n * is 0 and the last position is 1.\n+ *\n+ * Lsc tables are expressed in two formats:\n+ * - A list of gain values (LscTable)\n+ * - A radial polynomial (LscPolynomial)\n+ *\n+ * Table-based lsc tables are generated using an image at a fixed resolution and\n+ * can't at the moment be re-sampled when a different resolution is used for a\n+ * streaming session. Re-sampling a grid lsc table will return the same table\n+ * as loaded from the tuning file.\n+ *\n+ * \\todo: Implement grid based re-sampling\n+ *\n+ * Polynomial are more flexible and can be re-sampled for a given sensor frame\n+ * resolution using a list of horizontal and vertical nodes that define the lsc\n+ * grid on which the polynomial is re-sampled on.\n */\n \n } /* namespace ipa */\n", "prefixes": [ "v3", "18/35" ] }