Patch Detail
Show a patch.
GET /api/1.1/patches/26990/?format=api
{ "id": 26990, "url": "https://patchwork.libcamera.org/api/1.1/patches/26990/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26990/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-27-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:43", "name": "[RFC,v1,26/27] v4l2: v4l2_camera: Always clear pending requests", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6b5bc3083fb0456cab9aa2ce4bb9796b910e6c8e", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26990/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/1.1/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26990/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26990/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 41956C3332\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F8E365720;\n\tThu, 18 Jun 2026 14:39:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2008656F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:53 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CA9AEDF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"u24i0n+u\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786298;\n\tbh=sdHFz5WtSyn48bsJYYGaKLdonMkPV576UuxPKIjZc+g=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=u24i0n+uhQ3t1AbgNrnPlA2mKMt8RDCVmTCyURzV5KlMMCwQkKcHvZBNXJGkItPAq\n\t+TVNuMrsqoEktd5DFSg1axrtB3nlS4225ligyzaw1M72Hy/XvvhT6dUAxgaIP41t2I\n\tYsyMbiGuUezWiyGug++LDawC6EPgqysctqIYhBHo=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 26/27] v4l2: v4l2_camera: Always clear pending\n\trequests", "Date": "Thu, 18 Jun 2026 14:38:43 +0200", "Message-ID": "<20260618123844.656396-27-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Clear the list of pending requests regardless whether the camera is running\nor not. The list should only contain entries when `!isRunning_`, in which\ncase it was not cleared previously.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex e72b73a22a..8c7de8e92b 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -226,6 +226,8 @@ int V4L2Camera::streamOn()\n \n int V4L2Camera::streamOff()\n {\n+\tpendingRequests_.clear();\n+\n \tif (!isRunning_) {\n \t\tfor (std::unique_ptr<Request> &req : requestPool_)\n \t\t\treq->reuse();\n@@ -233,8 +235,6 @@ int V4L2Camera::streamOff()\n \t\treturn 0;\n \t}\n \n-\tpendingRequests_.clear();\n-\n \tint ret = camera_->stop();\n \tif (ret < 0)\n \t\treturn ret == -EACCES ? -EBUSY : ret;\n", "prefixes": [ "RFC", "v1", "26/27" ] }