Patch Detail
Show a patch.
GET /api/1.1/patches/26987/?format=api
{ "id": 26987, "url": "https://patchwork.libcamera.org/api/1.1/patches/26987/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26987/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-25-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:41", "name": "[RFC,v1,24/27] v4l2: v4l2_camera: Use buffer cookie for indexing", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c2cef62185b8b64b32d9e24b57b8e2c4b90450db", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26987/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/1.1/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26987/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26987/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F180C3329\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F20C6571B;\n\tThu, 18 Jun 2026 14:39:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51F8362988\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:53 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C314DF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PHW0wEEW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786298;\n\tbh=sopiKBDQMtAt07ooCAVtMn05RUsUGv007Kpx1frGX9s=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=PHW0wEEWkCZ58pFgwQjK4geQ8tMk9UWux2UthiBkwScSTrKzL+ESRfXMxpAAASHOA\n\tzXmHjMYY4Nnw0qnuwZbX5+JOV6RIQ8U9YfXeHcDXaGvCJpD5kUQ1Sxs+7vcZWkIxmE\n\tHUunU/1pqI0Kp0pNoHqTYzEXsOpLHo0dc3Jrp+VE=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 24/27] v4l2: v4l2_camera: Use buffer cookie for\n\tindexing", "Date": "Thu, 18 Jun 2026 14:38:41 +0200", "Message-ID": "<20260618123844.656396-25-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the buffer cookie to store the index of the buffer instead of\nrelying on the 1-to-1 association between requests and buffers,\nwhich will be broken by the split of requests and buffers.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 75428b8adc..7dd0ea1ef9 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -87,7 +87,7 @@ void V4L2Camera::requestComplete(Request *request)\n \t/* We only have one stream at the moment. */\n \tbufferLock_.lock();\n \tFrameBuffer *buffer = request->buffers().begin()->second;\n-\tcompletedBuffers_.emplace_back(request->cookie(), buffer->metadata());\n+\tcompletedBuffers_.emplace_back(buffer->cookie(), buffer->metadata());\n \tbufferLock_.unlock();\n \n \tuint64_t data = 1;\n@@ -171,6 +171,8 @@ int V4L2Camera::allocBuffers()\n \t\t\treturn -ENOMEM;\n \t\t}\n \t\trequestPool_.push_back(std::move(request));\n+\n+\t\tbuffers[i]->setCookie(i);\n \t}\n \n \treturn buffers.size();\n", "prefixes": [ "RFC", "v1", "24/27" ] }