Patch Detail
Show a patch.
GET /api/1.1/patches/26984/?format=api
{ "id": 26984, "url": "https://patchwork.libcamera.org/api/1.1/patches/26984/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26984/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-23-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:39", "name": "[RFC,v1,22/27] v4l2: v4l2_camera: Avoid a level of indirection", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "16493f3ead65a538828cc5904195bfce5d2e8cdc", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26984/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/1.1/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26984/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26984/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC581C3318\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D71665716;\n\tThu, 18 Jun 2026 14:39:21 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E294B62B32\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:52 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7A81DF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hKC25zwB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786298;\n\tbh=rJmuAswBm1gnfX4cU7FIDte9K62dIwjJE69ylzW2nig=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=hKC25zwBLcPRZJ3MjB4kL9Hyg7jqxl8oaWb9E9bWydIfYoHbKASeqni2+HZvNy1RV\n\tbiS/XYCL99sdbx7e0a0cXD8UhyGpSNKPWarXD/wYXwXAZSvEyiBU5B6zFci+Rly9nZ\n\tjXmivVIKQcip1eu8OFtqMgxLdhJkFMSRFtTU+dHk=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 22/27] v4l2: v4l2_camera: Avoid a level of indirection", "Date": "Thu, 18 Jun 2026 14:38:39 +0200", "Message-ID": "<20260618123844.656396-23-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Convert the `completedBuffers_` container to store the items directly\nand not via an `std::unique_ptr`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 11 ++++-------\n src/v4l2/v4l2_camera.h | 2 +-\n 2 files changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 412ab4ea67..648578c22b 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -70,11 +70,10 @@ void V4L2Camera::unbind()\n \n std::vector<V4L2Camera::Buffer> V4L2Camera::completedBuffers()\n {\n-\tstd::vector<Buffer> v;\n-\n \tMutexLocker lock(bufferLock_);\n-\tfor (std::unique_ptr<Buffer> &metadata : completedBuffers_)\n-\t\tv.push_back(*metadata.get());\n+\tstd::vector v(std::move_iterator(completedBuffers_.begin()),\n+\t\t std::move_iterator(completedBuffers_.end()));\n+\n \tcompletedBuffers_.clear();\n \n \treturn v;\n@@ -88,9 +87,7 @@ void V4L2Camera::requestComplete(Request *request)\n \t/* We only have one stream at the moment. */\n \tbufferLock_.lock();\n \tFrameBuffer *buffer = request->buffers().begin()->second;\n-\tstd::unique_ptr<Buffer> metadata =\n-\t\tstd::make_unique<Buffer>(request->cookie(), buffer->metadata());\n-\tcompletedBuffers_.push_back(std::move(metadata));\n+\tcompletedBuffers_.emplace_back(request->cookie(), buffer->metadata());\n \tbufferLock_.unlock();\n \n \tuint64_t data = 1;\ndiff --git a/src/v4l2/v4l2_camera.h b/src/v4l2/v4l2_camera.h\nindex 3d09ae7d60..1528f9aad8 100644\n--- a/src/v4l2/v4l2_camera.h\n+++ b/src/v4l2/v4l2_camera.h\n@@ -85,7 +85,7 @@ private:\n \tstd::vector<std::unique_ptr<libcamera::Request>> requestPool_;\n \n \tstd::deque<libcamera::Request *> pendingRequests_;\n-\tstd::deque<std::unique_ptr<Buffer>> completedBuffers_\n+\tstd::deque<Buffer> completedBuffers_\n \t\tLIBCAMERA_TSA_GUARDED_BY(bufferLock_);\n \n \tint efd_;\n", "prefixes": [ "RFC", "v1", "22/27" ] }