Patch Detail
Show a patch.
GET /api/1.1/patches/26968/?format=api
{ "id": 26968, "url": "https://patchwork.libcamera.org/api/1.1/patches/26968/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26968/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618123844.656396-5-barnabas.pocze@ideasonboard.com>", "date": "2026-06-18T12:38:21", "name": "[RFC,v1,04/27] libcamera: request: Disassociate buffer when cancelling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fe12341f83a9534db7d0aec4b8d7e26276da23e8", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26968/mbox/", "series": [ { "id": 6006, "url": "https://patchwork.libcamera.org/api/1.1/series/6006/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6006", "date": "2026-06-18T12:38:17", "name": "Misc. changes before request-buffer split", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6006/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26968/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26968/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE663C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:39:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6151656FF;\n\tThu, 18 Jun 2026 14:38:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4571C62B29\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:49 +0200 (CEST)", "from pb-laptop.local (185.182.214.63.nat.pool.zt.hu\n\t[185.182.214.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56467DF3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:38:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BCpMCXMy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1781786294;\n\tbh=8nKOaAObOZ2q+PjgR/9/xS1H3dZFC3JvN9UWeRHFOTA=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=BCpMCXMym9thO7EWHKNOc/t8YNCxpLfV4vDd5QSte1EMonWmzniT/ig27k9ifRCZL\n\t67AiaAIO3ltkxaY95xpo4lGicTFnks5nh7UJveE1gvDIDBzAkbZ1rYeGxLtfk68o/n\n\tU1MMVDHIvRt9Ufx9rA04BEPOlIdk37UPV8ZJdMio=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 04/27] libcamera: request: Disassociate buffer when\n\tcancelling", "Date": "Thu, 18 Jun 2026 14:38:21 +0200", "Message-ID": "<20260618123844.656396-5-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "References": "<20260618123844.656396-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Match the behaviour of `completeBuffer()` by unsetting the \"parent\" `Request`\npointer of the `FrameBuffer`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/request.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 163d8cf920..5f983e0ce6 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -143,6 +143,7 @@ void Request::Private::doCancelRequest()\n \tfor (FrameBuffer *buffer : pending_) {\n \t\tbuffer->_d()->cancel();\n \t\tcamera_->bufferCompleted.emit(request, buffer);\n+\t\tbuffer->_d()->setRequest(nullptr);\n \t}\n \n \tcancelled_ = true;\n", "prefixes": [ "RFC", "v1", "04/27" ] }