Patch Detail
Show a patch.
GET /api/1.1/patches/26961/?format=api
{ "id": 26961, "url": "https://patchwork.libcamera.org/api/1.1/patches/26961/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26961/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-29-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:41", "name": "[28/30] libcamera: software_isp: gpu: Switch to using glTexSubImage2D on slow path upload", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "953bc6dfb139d8861c4f2753c590eed49252c8f7", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26961/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/1.1/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26961/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26961/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0DAEC3334\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 862A7656E1;\n\tThu, 18 Jun 2026 14:23:40 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86C186301A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:19 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-490ace40f4bso8813235e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:19 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:18 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"rDiPphOT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785399; x=1782390199;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=++p7rbbpyQ4ktzzlFiMkpZEdxhGxm60fKHrNbbt6c5w=;\n\tb=rDiPphOTWXbscs6ah858KkcGdH0F5C/LKNHLYgr0+b3MCBSk9KUiBqnhSdza1wx33S\n\twheDfQgBSVoTX4tUZD7nlF4Xln9zZx28t8wXrTqWlZn3qCoyOGoba0Tpc87FTLj8lYpx\n\tZLIb7l1EImewa+7ZuzVGxihSoxYUgweDjD6hOUs/MdKcHvYDNBjPw7TQoYhSocVh3l4r\n\trgDXeWquIx7uleWprXa3o+4K0ZeMCKWgD8SCeaB2oySnLXELoaEYAnPaih1DocbeUMKc\n\ttexae6vYi25mmIuFhfKmAbdPSnromSNXGiQOYWwKIUqIlfn5Ntgyl1TA7kLP5jpcZVJa\n\tF0wA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785399; x=1782390199;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=++p7rbbpyQ4ktzzlFiMkpZEdxhGxm60fKHrNbbt6c5w=;\n\tb=HFHHqUyeufXLrPC+MVYSjKDdx+GDZHH/1pLbjIu4paFRwe/AV8NgNaQ5Eju7AZQrwc\n\tmybdMDh5XlF8ZRIbmOgMC8vd1+dsosUmqGaIEi8pTQduhSpYKvF8Ke3/VVL0P9vG/ckJ\n\trHU0ESWyZW8dP2RzgTX9OFEvohafcQYozvMV0muItf0M3a+z3omlnHcBZYos2DztoiVd\n\tmw7eY7Asv+QdSLsHHYtHl6X63ASz8R++X6+tkEhH4T2rxLuQbkhAd5mLrC5dHhYoCn97\n\tOT2bdt0UYYtJGyGFQiUNm6tLhnVm9N6dt39ynB1HtVLYUSHw/mcYlb++HeuHRQQqS3nK\n\tJQcw==", "X-Gm-Message-State": "AOJu0YwWy6DfTFLb+05J0ZB0J8x+0m3kqDyT6fsclYBZqcdnGE3mJYGd\n\tHDsU4ddX6j6A3kURbB6W/XiMxBtXnjMKcAW7SCS0zAhc/pGrJawBPaAyQVeuthbGMkccQxRvmoh\n\tbvNLz+co=", "X-Gm-Gg": "AfdE7cmGscwP6ptLktjSa51kDY8HKD1lgCHKf8MOF4m6EBL193BwpT0GWvpSVdg/FYh\n\tJdv10BO3VBVGrZcvAfYNdfsaIyoRKzc57ncBQHdBRmCwOybKhWkkTvpx7kknssKsXBnLS8zNL+G\n\tv2kgFxu7lRPRLbyIpp7ww2groI2PQMRDrqawz8q5M7y4ciVzCLqeQx1w+GosWhNswLeodEIfj1A\n\tmHekUsUkJ2uOzXqEPzLpOIjFRBl/xfDp8lW8XVIA3+sFlP8PuNOMclvwx0MBT7DVQVXS/C6PqHP\n\tS53DEtCQPvK7NShbjP4iTi596RoaK6apHGL0FyHxnLYUlzgts4azThfogMRrV4fKd8SgZHyrFsv\n\tqeCzK6TgY5F390EuTKmBzkttzU7F0tH365Px1AiIytH1EFvy7sj+01Z+CObxKKH4sKbnPG30xMZ\n\tvGiV4I7cEIiUy1vSPn6q68Kv3Rxz91Pj0lMCSV/gs=", "X-Received": "by 2002:a05:600c:8010:b0:490:bad9:de43 with SMTP id\n\t5b1f17b1804b1-492381a5b88mr58651855e9.0.1781785399097; \n\tThu, 18 Jun 2026 05:23:19 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 28/30] libcamera: software_isp: gpu: Switch to using\n\tglTexSubImage2D on slow path upload", "Date": "Thu, 18 Jun 2026 13:22:41 +0100", "Message-ID": "<20260618122245.946138-29-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This is the right thing to do but, isn't the thing that is costing us right\nnow. We know this is slightly faster, emphasis on the slightly anything\nwith less than a millisecond of performance increase is not easily\nmeasured.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\nindex d7bed8837..2e5c0e40e 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n@@ -260,7 +260,7 @@ int SoftwareIspPipelineGpu::processGPU(FrameBuffer *input, FrameBuffer *output,\n \t\t\tLOG(Debayer, Error) << \"mmap-ing buffer(s) failed\";\n \t\t\treturn -ENODEV;\n \t\t}\n-\t\tegl_.createInputTexture2D(*eglImageBayerIn_, inMapped->value().planes()[0].data());\n+\t\tegl_.updateInputTexture2D(*eglImageBayerIn_, inMapped->value().planes()[0].data());\n \t}\n \n \t/* Generate the output render framebuffer as render to texture */\n@@ -374,6 +374,7 @@ int SoftwareIspPipelineGpu::start()\n \t/* Texture we will render to */\n \teglImageRGBAOut_ = std::make_unique<eGLImage>(GL_RGBA, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE3, 3);\n \n+\tegl_.createInputTexture2D(*eglImageBayerIn_, NULL);\n \tegl_.createOutputTexture2D(*eglImagePingPong_[0]);\n \tegl_.createOutputTexture2D(*eglImagePingPong_[1]);\n \n", "prefixes": [ "28/30" ] }