Patch Detail
Show a patch.
GET /api/1.1/patches/26958/?format=api
{ "id": 26958, "url": "https://patchwork.libcamera.org/api/1.1/patches/26958/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26958/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-26-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:38", "name": "[25/30] libcamera: software_isp: gpu_pipeline_shader_pass: Add shader DEBUG time logging", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2415f3703ea3bc370133771ef514e428ce60581b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26958/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/1.1/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26958/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26958/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 76ADBC3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D924F656CA;\n\tThu, 18 Jun 2026 14:23:37 +0200 (CEST)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44DC0629CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:17 +0200 (CEST)", "by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-490b4a8e28bso6380145e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:17 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"VfFO3BN6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785397; x=1782390197;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=R+IGxiwb/nNpubCez8ipcoHv8HytnsSvPHD8T96HbMI=;\n\tb=VfFO3BN6oi+Qg5PsKPnie0FzKqcR258JNA//M5Un70a9HUZd7xAcvYQ26HcHaazu8x\n\thiUXrhWWYhIbyH1t0YoV1A0Xx+Is6mdqUQ0JNT2f4iCXDOQrghzY9V+Dc+C01tTz20QL\n\tSASmCSQKk6QZJ65qSf47uNyEOxvyu07dJgXu2n/qPAZvFyzurFgfk1KCZQQuFfd+mO1g\n\t6DMq1O25Pegmow/jR5SwviCXfPr13eexsjMGEpJNW6Ch/qdd14u0KC/ukOSQ6VlsfIn5\n\t3vq4vaJ26HVjF5GSsKATLDRriQDvQWd+DTjC+vCYZxAF5lmw9MIqHQ83zBdjWVK6VZjz\n\t/hhA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785397; x=1782390197;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=R+IGxiwb/nNpubCez8ipcoHv8HytnsSvPHD8T96HbMI=;\n\tb=d2cbIliFWsQLsDEGRK5sLEtefMP8Aduosi5zMDxM1abeF4fUWiUnBQfO9HcPhJ6cl/\n\tQSmZAloykl0Y4Zq6AuLmg1pEAgmISHihJv8PE38cM6jaKQAZp624r/jg0UoRH9v7SZm+\n\tgHmomjyI/JVbuJUapMx4AjVRrIqBgBxHE2X1811asbmQQiVPfaqdofVvNzTPufsVWUzE\n\tw/Nc6zElD04Msyrx14h6gZqJwjVEj84h5LEV4SiWjlUD3K1zZT0cp+hOrXSVpPm4KUXW\n\tL8KhSPGaBlF9UpaDblFh9C7IkUcuNRzqIDjZihtpkldcAswJYYt7DCPuC7qg3sbHvwGo\n\tphPA==", "X-Gm-Message-State": "AOJu0Yzob6tjoJ2OKKmlZeg/gaPs1Iie/SHgeDBhrB2PxvvLTLZqqrpA\n\ttK9aqFBlSlVg9Qc/htjVwTdI7hmR6FbiZa6CJ+Roti3v3RxrCkrTzenT5bWYtv7p6CVKPWRZA6t\n\tLyjhlT24=", "X-Gm-Gg": "AfdE7cmjs47L17g5qBI+qOAmPopVcbIpBGFS3cNyrBI5ws1ailiPsODKOykpadX5iga\n\tSi60IdwhFX3EaVCkLCJK2GfT3PUhrgFjMD8174sqa6rEicAZLnVBiFCOT/LBxKOc9z8wseKWGxb\n\tG3mi+AkxAhOMCTwZqFd1YZMBId8qzrlUShle7EjdEKbISKHCM+WSqiLD7YoCa3UW8CRIg/xx10a\n\tU7paEN4Aibm3wy1ImaZy2YJs5u/E3QwBzs9bPGioM/N+6tVZXZscKr2JWjjUhu53gTGlBy8dLh1\n\tQe4uwPOAwvI1VDg0aVsQtCllAiBSTXmxdk68otuHS3MOthG/k5ITACnpxf0WN6Sr7VyP3fy2XBO\n\tlwod3lQbrb2TdMfUZ84uEsVgKBwu2MV4sZagdaFySclc4qxv2yiFYhzpn3W3JNrnEo1LCXYrGNC\n\tT5RLqBtMcCaf+grsU0cvqKLtmbVfUJ", "X-Received": "by 2002:a05:600c:6091:b0:492:3172:bcf0 with SMTP id\n\t5b1f17b1804b1-492333e8d2amr137937185e9.3.1781785396667; \n\tThu, 18 Jun 2026 05:23:16 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 25/30] libcamera: software_isp: gpu_pipeline_shader_pass: Add\n\tshader DEBUG time logging", "Date": "Thu, 18 Jun 2026 13:22:38 +0100", "Message-ID": "<20260618122245.946138-26-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n .../software_isp/gpu_pipeline_shader_pass.cpp | 10 ++++++++++\n src/libcamera/software_isp/gpu_pipeline_shader_pass.h | 4 ++++\n 2 files changed, 14 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/gpu_pipeline_shader_pass.cpp b/src/libcamera/software_isp/gpu_pipeline_shader_pass.cpp\nindex d0d13eef9..57d60f50e 100644\n--- a/src/libcamera/software_isp/gpu_pipeline_shader_pass.cpp\n+++ b/src/libcamera/software_isp/gpu_pipeline_shader_pass.cpp\n@@ -57,6 +57,8 @@ int GpuIspShaderPass::process(eGLImage &eglImageIn, eGLImage &eglImageOut, uint3\n \tglViewport(0, 0, width, height);\n \tglClear(GL_COLOR_BUFFER_BIT);\n \n+\teglBenchMark_.begin(egl_);\n+\n \tglDrawArrays(GL_TRIANGLE_FAN, 0, DEBAYER_OPENGL_COORDS);\n \terr = glGetError();\n \tif (err != GL_NO_ERROR) {\n@@ -64,9 +66,17 @@ int GpuIspShaderPass::process(eGLImage &eglImageIn, eGLImage &eglImageOut, uint3\n \t\treturn -ENODEV;\n \t}\n \n+\teglBenchMark_.end(egl_);\n+\n \treturn 0;\n }\n \n+void GpuIspShaderPass::printShaderBenchMark(void)\n+{\n+\tLOG(GpuShaderPass, Debug) <<\n+\t \"ShaderPass = \" << this->name() << \" took \" << eglBenchMark_.getTimeElapsedSync(egl_) / 1000 << \" us\";\n+}\n+\n int GpuIspShaderPass::start()\n {\n \treturn 0;\ndiff --git a/src/libcamera/software_isp/gpu_pipeline_shader_pass.h b/src/libcamera/software_isp/gpu_pipeline_shader_pass.h\nindex a329845ee..0cff531e9 100644\n--- a/src/libcamera/software_isp/gpu_pipeline_shader_pass.h\n+++ b/src/libcamera/software_isp/gpu_pipeline_shader_pass.h\n@@ -74,8 +74,12 @@ public:\n \t */\n \tGLint glFormat_;\n \n+\tvoid initShaderBenchMark(void) { eglBenchMark_.init(); }\n+\tvoid printShaderBenchMark(void);\n+\n protected:\n \teGL& egl_;\n+\teGLBenchMark eglBenchMark_;\n \n \t/* Shader calculates this getter provides ability to interrogate if needed */\n \tunsigned int bytesPerPixel_;\n", "prefixes": [ "25/30" ] }