Patch Detail
Show a patch.
GET /api/1.1/patches/26954/?format=api
{ "id": 26954, "url": "https://patchwork.libcamera.org/api/1.1/patches/26954/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26954/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-22-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:34", "name": "[21/30] libcamera: software_isp: egl: Add createOutputTexture2D", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e15ab132f39bdad86a54b26d84bec9349ae2b43f", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26954/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/1.1/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26954/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26954/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55BE2C3323\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FBAE656CA;\n\tThu, 18 Jun 2026 14:23:33 +0200 (CEST)", "from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com\n\t[IPv6:2a00:1450:4864:20::42a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FFB5629B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:14 +0200 (CEST)", "by mail-wr1-x42a.google.com with SMTP id\n\tffacd0b85a97d-4631679f204so858905f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:14 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:13 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MqNLYLxJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785394; x=1782390194;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vlemr6TP2yYXWCy4cCKcKNb9td/Kb7P/MkBIEIloaww=;\n\tb=MqNLYLxJz6cw53XHwr5qeCG7Oesh2UGnpyEsx+Aro1PXwA2Mk15UTsrtr4PA+jsaOh\n\toYgbaGYAKoA3WltDHVdFP2dhXeCgeMvlfk/GfqMVQlSQ8IBcW4uPUvqqLrtuf6BUOAod\n\tGlMUGpP/FFDo+n970ueROCBuRu0Ybc6yp0PORAJb3r1F6Ew4HNlnlVQfXytCmfZR567z\n\t06xExKMOjzSLksGiy9sUmvnvZZRDni1RPITzW66d8yiZQMn963OA27o+zGDoY66ce3xk\n\tlEdBiUUaAJk/tyAq4RVPZ6PEFtxrhugK+YczOcJKdq4PPfCKDmJtdr87TRid37QkYC3e\n\tgQpg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785394; x=1782390194;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=vlemr6TP2yYXWCy4cCKcKNb9td/Kb7P/MkBIEIloaww=;\n\tb=nF3Eu/hGkiEkDGu/w+nnArY8ZoECi3NTRY/jfxNdszUZ3y6/joFQfPPhvTZSx2sBvb\n\t5Qrx+sfo7VQclrRjysIvzby0F4M6IB8RIWFqsRuY6b9pwEVJWPM/PwNS/DeRCvhl2F6l\n\tXVwYatKm1kpEaQ1EeW494OSHPA+mrDsq/0gvBRVxZces4XhQOPiqNbJkBYJ7uF4ntOh6\n\t5mr5f0EmqYNWXGYDPrDHIKzOIS7zfXik2tkIKBN/KNDnVFxRx7OVg6xFmGsY8FURHJep\n\tl+ZTR/4m9ev/xQ2ycW9Kq/he+55tuIR8LkAhrygMV0NLpHXu36BfS02q+qwAMQOQ+Zlu\n\tKnNA==", "X-Gm-Message-State": "AOJu0Ywt9CnF1i4SKxJbakr1CKkmWFnI5sbja/Ch2IbMHv/u62UOTwit\n\toSlpc5wtWyOsikxrXBup32702MswD0qoQyi9HV+nJqUovl4tmJKwwk8/Sp1vrEjFFWqCn20sa8A\n\tq/r9svCg=", "X-Gm-Gg": "AfdE7ck6Tz75w+s2hlBLZFsSrD+CVQe2csBXwnjGieSuts2orGGuF9UHL2npzjpGiAR\n\tde2+sMq6Fn/waMZhPjjp7HR145E2oV+BqnAWju7hExfwWmJfvNFR2dcPmO37LGwDKcRwKD955Hv\n\tcqeev8iczugTW9/NeMu4LDvcJD1MVW1UVrTNpPpednGVFvU2RMnBv4Dj9XwZT73tlylG6N141y0\n\tU9M+kYh+DNNlKXN+q362R3P1Qm9POUY/Bsb8zb7McRq5lR6aBB/dl/j73ZzxnPnf51DfFQCWvry\n\tgtbPO+V+VDerzUOgHCcglgXX1iTXsZ+tMxEpj8hR6BN46qZ4iGluXcFEAcsReiXa9s/VJT2Xid5\n\t++mFJM8GQGMl6vBkJnwuzYRzu5kW4B9ciCQKX9m3PP0sD7Wwl9VfTPe13SN+pl25h35QSet6wwg\n\tlQsVTkaz3+segXsMkovDL7/F92fELP", "X-Received": "by 2002:a05:600c:6089:b0:490:5000:917 with SMTP id\n\t5b1f17b1804b1-4923815425fmr47375175e9.1.1781785393854; \n\tThu, 18 Jun 2026 05:23:13 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 21/30] libcamera: software_isp: egl: Add\n\tcreateOutputTexture2D", "Date": "Thu, 18 Jun 2026 13:22:34 +0100", "Message-ID": "<20260618122245.946138-22-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/egl.h | 1 +\n src/libcamera/egl.cpp | 16 ++++++++++++++++\n 2 files changed, 17 insertions(+)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 182a4dc55..d3749d2e7 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -107,6 +107,7 @@ public:\n \tint createInputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tint createOutputDMABufTexture2D(eGLImage &eglImage, int fd);\n \tvoid createInputTexture2D(eGLImage &eglImage, void *data);\n+\tvoid createOutputTexture2D(eGLImage &eglImage);\n \n \tint attachTextureToFBO(eGLImage &eglImage);\n \ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex ffaa6bc49..8d135e092 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -297,6 +297,22 @@ void eGL::createInputTexture2D(eGLImage &eglImage, void *data)\n \tglTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP_TO_EDGE);\n }\n \n+/**\n+ * \\brief Create a 2D texture attached to an FBO for render-to-texture\n+ * \\param[in,out] eglImage EGL image to associate with the texture\n+ * \\param[in] format OpenGL internal format (e.g., GL_RGB, GL_RGBA)\n+ *\n+ * Creates a 2D texture in VRAM. The texture\n+ * is configured with nearest filtering and clamp-to-edge wrapping. This\n+ * is useful for uploading static data like lookup tables or uniform color\n+ * matrices to the GPU.\n+ */\n+void eGL::createOutputTexture2D(eGLImage &eglImage)\n+{\n+\tcreateInputTexture2D(eglImage, NULL);\n+\tattachTextureToFBO(eglImage);\n+}\n+\n /**\n * \\brief Initialise the EGL context\n *\n", "prefixes": [ "21/30" ] }