Patch Detail
Show a patch.
GET /api/1.1/patches/26952/?format=api
{ "id": 26952, "url": "https://patchwork.libcamera.org/api/1.1/patches/26952/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26952/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-19-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:31", "name": "[18/30] libcamera: software_isp: egl: Use Texture Unit 3 for final output texture", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "79ec5972f386cfecf749d11785af3ebc7e550440", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26952/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/1.1/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26952/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26952/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ADC64C3318\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D492162E9D;\n\tThu, 18 Jun 2026 14:23:31 +0200 (CEST)", "from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1275C62C72\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:12 +0200 (CEST)", "by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-490ae94a89eso6313725e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:12 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:11 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"CyL8twYJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785391; x=1782390191;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=qdWOEHoJeTzCOxcBywajFodiO258hC6oLj6gEahZr7s=;\n\tb=CyL8twYJUab2VJlaWrA+3Zx5CqKxDi53guCoQbEVNWTZ6bor2YumV4gxLekQMhZUfx\n\tXJSV3MJgKx6DqjlPTCF8sjbwkWi6ulz8nbg5T8dUYRPcLHMcj83UNcD8y9QzmbSj5UCS\n\tmpcSN8K30QePfI5DXB/Br5qJJ5P3y4eBBSoFBQF28nTtd6SOxuusXzIWAWUaauCBVkp8\n\tsybdYNAlJLU/UsC/HmV7W27hIi7PdfjWjaznyWsvMbXeHPMKz4YACeAEpnhvDlrf2wNQ\n\tWFzfp2rK/KYgftqF/knd+nJylSztYvsdU+tH07uICWjz80m/REGlvXAnjI8TZA01Hro0\n\tZdjA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785391; x=1782390191;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=qdWOEHoJeTzCOxcBywajFodiO258hC6oLj6gEahZr7s=;\n\tb=qbYxRO1mCOCeSdpTrVNLevd+1jaS+HJub4DELUzqc+OrvAm1OwTWDDATBWun3+69Vd\n\tudtq3fUxOyMq9gr/c625PXz/DYv3yz8FOgKfNEWTlqfG/QHmZDEm7XW5fI3XGs1DYKqb\n\tWugzUzz0S93yncFxE0R3QUD49UImCxtSWwRIZwiptP4CHKKDnJN/IWoBmmRSwkBzYs4o\n\tXfUqpyLgOi0/hSGU+wj2PRT4XB9SRBMPl74AnsQGl7/pTmSp/u9ensJzJVxQXQwnzG2+\n\tWRSFXnZ0DatNRS07dPWLWHI2jf1NydOAY39wIlLFn5hxL+AVzHtepTOck3pqVZ6sOLXz\n\tPwnQ==", "X-Gm-Message-State": "AOJu0YyOLk/NwrDCKJDPS7Rl08od3mDxh2/RiIGAs64nf8mRlzlrK9ar\n\tvr1tje1x6Lh5BPgOvO1K9K6RXx/iIMQZh0Iqs1mpRaiNsLIZXZNWtn56NhN1PCv6xlKH+bqWAEk\n\t0Z8Ln3yA=", "X-Gm-Gg": "AfdE7cklJWJoZGQK1B0EC3FPzhMcmCG4/4kfsiKHojA/eGUBcu+ZZcY9q1ytg9UurBL\n\tfRHhtBXueE6qVq60V7j09f30vOi4Bp6uIw7rJoT8jGIPhe2iXBBiDji6yTOa+mkEw7TYKF/bR8I\n\tZJUFgFKpsdP9qV6OYosRy88tNI8RhUIdB6IClsKDBDj/XeAnKaPeoiyHK6IyYjCpmdIqmTG3b53\n\tsj95vzAZ+bUvlSaY7PML8Pi5yxN2bLNk6+M/qV9Hu59zRSoIJr2Z0diDJr3J3GhEEnWO3UaU2Qx\n\tWfV9pUVxtobnN1FHR1zVFE3S59SW9+iGnuSWjTywvhr0SJcnne67qOJDJmHukQqCL4pVAekCalE\n\t41zoFqkudwIdUHnAfoCQP5VrxWIlt2FHDx/DjxFVQ+VDo366hzAwa7+FMuHFoK8A6yA/F/zpOY8\n\tjuq0xp28rj4PHRWT/zeWZu+Cktq5zs", "X-Received": "by 2002:a05:600c:a104:b0:490:e170:b7ee with SMTP id\n\t5b1f17b1804b1-4923821be52mr38526925e9.17.1781785391513; \n\tThu, 18 Jun 2026 05:23:11 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 18/30] libcamera: software_isp: egl: Use Texture Unit 3 for\n\tfinal output texture", "Date": "Thu, 18 Jun 2026 13:22:31 +0100", "Message-ID": "<20260618122245.946138-19-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We will use ping/pong buffers as intermediary steps in the GPUISP pipeline.\nThe last texture should logically be texture unit #3.\n\nTEXTURE0 = Input\nTEXTURE1 = Ping\nTEXTURE2 = Pong\nTEXTURE3 = Output\n\nWe don't have ping/pong yet but in preparation make the small change to\nTEXTURE3 for the existing output framebuffer.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\nindex 8bafd70f8..458b65854 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n@@ -336,7 +336,7 @@ int SoftwareIspPipelineGpu::start()\n \teglImageBayerIn_ = std::make_unique<eGLImage>(gpuIspShaderPassDemosiac_.glFormat_, inputConfig_.stride / gpuIspShaderPassDemosiac_.getBytesPerPixel(), height_, inputConfig_.stride, GL_TEXTURE0, 0);\n \n \t/* Texture we will render to */\n-\teglImageRGBAOut_ = std::make_unique<eGLImage>(GL_RGBA, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n+\teglImageRGBAOut_ = std::make_unique<eGLImage>(GL_RGBA, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE3, 3);\n \n \treturn 0;\n }\n", "prefixes": [ "18/30" ] }