Patch Detail
Show a patch.
GET /api/1.1/patches/26951/?format=api
{ "id": 26951, "url": "https://patchwork.libcamera.org/api/1.1/patches/26951/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26951/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-20-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:32", "name": "[19/30] libcamera: software_isp: egl: Add Ping/Pong buffers with start/stop bindings only", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6b497ff28230418ed681b530593e42f6e19f6682", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26951/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/1.1/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26951/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26951/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3A33C3316\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29689656D4;\n\tThu, 18 Jun 2026 14:23:30 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD98E629A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:12 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-4905529b933so7824735e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:12 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.23.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:23:11 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"FqAEfm7/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785392; x=1782390192;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=wZj9cpOKT3N+cE5reFIhRD3D2OdcaGGh41+idBriHE4=;\n\tb=FqAEfm7/PvA1u8bGrQvB2QkFzeHx5L1axDBduWEEyzrYL46SkNMN+f4nErRrMox+CJ\n\toAU6kZ8yNZw/94h6yMzbndpKYC5KzzzzX8MPoU1fYypoZ10T5RatUBfJQyWjoV29C2ei\n\t6LSYZYc2tE7kBF7mkJM/sxqfQXidDxu2mcs7sV/M1uCvlJPq+6bDYC67M7FF/mea4/Rz\n\tP67JoYcU3qG+AugZKAVbnXilGuKadEXpQ4n33/9IJ5T2XrXJ1oB0B14to0CqvfwUfe9J\n\txNqhhdDn4aQhq4vy824jgU9vFgTIyWKCXYKxIQLHyhOganXVnmtHQqZoSG9qpgBOHYV/\n\tBwJw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785392; x=1782390192;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=wZj9cpOKT3N+cE5reFIhRD3D2OdcaGGh41+idBriHE4=;\n\tb=qynC+Iw4Sj+0MEX7f9p7uRsjZ6Or+3eJ85vskzymafMtWqTHX2Zfeh0AnwuGyq5CS7\n\tpsSzavEqn9z/yw8/QbBFm9zPZ2WKq9Wbpxxq50zwJeaICycU75PD/Fbjyp0fFe3GAL5H\n\tf/dz7gufYfzqh7GCWLb7VS2yhKc1YNEuPNQ7nGouug43zhETHkcBXONIAiIoPA4HwIzQ\n\tB0TuvyvQ8mOOltLvhp3/w+Yopn9W6GtOJsid+2jCHgrUbrGK4Lr9ZOEOLmAhtq55gtWO\n\teVFwPay2SZhAxmi/2T0agh9oJ7QyYXqHWVP4kPQJX7UOd+3Q4UuLbJAJ7SZ/X63CqxQL\n\ta6iQ==", "X-Gm-Message-State": "AOJu0YxSBxR5dQe+6vqx2fCY0A/EG7xxUsFHHx3h/7XYEUpjlyYMl7pN\n\tFXuTmxuK9KP7DRcLVxNpVej1I00jpisXIISNYRPzeionNpznD9ar6XjzZKZ+oMaWrV1X1PY41fX\n\t2dEEO7uo=", "X-Gm-Gg": "AfdE7clSM3DWQY0Bo9yIM+rR9eQzF1IofZTZYodoIcdHBR/AFO0CyaC2McdVwHatj/O\n\tBb+YRGAxMiID625g/Nrl9f1itYVspI+uGHNj6Z/7rdzYvku7HRzmrbTCuRebOfnxMte8fTbHGuD\n\t83+eTtKYpNE/hgNY75r/wmp+ZgwtTCtmlZWdMRrnHmn1VZUKpLG/zO2/Jry0T+z5L3QJ7OeRVjS\n\tVC9kfJbKzhsHnUVtKVdlmsxClXcyDhF1YDyBs3/Ts6FKRhmuqPOaEn3LpMM+RvNwklj71Jcz1aI\n\tt9Anf7QMpPBpAotNX9y9P3uDsi/HdGlBU7dyGs/BpZb/MELcmU2lliVCWxLJ+SiF59puhL9hDnj\n\tIyt7MTE5o+jYmRvXT7ATAmDPHE56h70WJA5FhafDV4ZGD7OPBxnfHaPAV42jT3yFzP++geucWTO\n\tBq9ZA809ULu5wCNL4a58JprRS75x5JWHJXQBtDUZw=", "X-Received": "by 2002:a05:600c:828e:b0:490:e5c1:b8bd with SMTP id\n\t5b1f17b1804b1-4923334baa1mr148777985e9.0.1781785392199; \n\tThu, 18 Jun 2026 05:23:12 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 19/30] libcamera: software_isp: egl: Add Ping/Pong buffers\n\twith start/stop bindings only", "Date": "Thu, 18 Jun 2026 13:22:32 +0100", "Message-ID": "<20260618122245.946138-20-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add in the Ping/Pong texture buffers, don't bind them to anything yet.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 6 ++++++\n src/libcamera/software_isp/software_isp_pipeline_gpu.h | 1 +\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\nindex 458b65854..18a8ae17a 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n@@ -335,6 +335,10 @@ int SoftwareIspPipelineGpu::start()\n \t/* Raw bayer input as texture */\n \teglImageBayerIn_ = std::make_unique<eGLImage>(gpuIspShaderPassDemosiac_.glFormat_, inputConfig_.stride / gpuIspShaderPassDemosiac_.getBytesPerPixel(), height_, inputConfig_.stride, GL_TEXTURE0, 0);\n \n+\t/* Intermediary ping/pong textures */\n+\teglImagePingPong_[0] = std::make_unique<eGLImage>(gpuIspShaderPassDemosiac_.glFormat_, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n+\teglImagePingPong_[1] = std::make_unique<eGLImage>(gpuIspShaderPassDemosiac_.glFormat_, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE2, 2);\n+\n \t/* Texture we will render to */\n \teglImageRGBAOut_ = std::make_unique<eGLImage>(GL_RGBA, outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE3, 3);\n \n@@ -344,6 +348,8 @@ int SoftwareIspPipelineGpu::start()\n void SoftwareIspPipelineGpu::stop()\n {\n \teglImageRGBAOut_.reset();\n+\teglImagePingPong_[1].reset();\n+\teglImagePingPong_[0].reset();\n \teglImageBayerIn_.reset();\n \n \tgpuIspShaderPassDemosiac_.stop();\ndiff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.h b/src/libcamera/software_isp/software_isp_pipeline_gpu.h\nindex 1b77bc71d..fcd622492 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.h\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.h\n@@ -65,6 +65,7 @@ private:\n \n \t/* Pointer to object representing input texture */\n \tstd::unique_ptr<eGLImage> eglImageBayerIn_;\n+\tstd::unique_ptr<eGLImage> eglImagePingPong_[2];\n \tstd::unique_ptr<eGLImage> eglImageRGBAOut_;\n \n \tstd::unique_ptr<SwStatsCpu> stats_;\n", "prefixes": [ "19/30" ] }