Patch Detail
Show a patch.
GET /api/1.1/patches/26936/?format=api
{ "id": 26936, "url": "https://patchwork.libcamera.org/api/1.1/patches/26936/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26936/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260618122245.946138-4-bryan.odonoghue@linaro.org>", "date": "2026-06-18T12:22:16", "name": "[03/30] libcamera: software_isp: gpu: rename debayerGPU to processGPU", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "dedf5960f3b950eb6c9758ade30187dd2373b95c", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26936/mbox/", "series": [ { "id": 6005, "url": "https://patchwork.libcamera.org/api/1.1/series/6005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=6005", "date": "2026-06-18T12:22:13", "name": "RFC/RFT: gpuisp: Multipass with speed optimisations on top", "version": 1, "mbox": "https://patchwork.libcamera.org/series/6005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26936/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26936/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EDAEBF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Jun 2026 12:23:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52A7362B29;\n\tThu, 18 Jun 2026 14:23:06 +0200 (CEST)", "from mail-wr1-x435.google.com (mail-wr1-x435.google.com\n\t[IPv6:2a00:1450:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B8F662987\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 14:23:00 +0200 (CEST)", "by mail-wr1-x435.google.com with SMTP id\n\tffacd0b85a97d-45eeba68948so678305f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Jun 2026 05:23:00 -0700 (PDT)", "from inspiron14p-linux ([109.76.144.236])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4922fa3a4easm275198015e9.3.2026.06.18.05.22.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Jun 2026 05:22:58 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"yIsO7i5s\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1781785379; x=1782390179;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=1J5bcMG3cS5HzAUNVk+psEM90P+jr41K1tK0MCZOzXo=;\n\tb=yIsO7i5sXz5VY6ao1dJ+hePHxUC6mh1g59mlwT0sH484QWw2wJGcITJbTJdZC2t3Kg\n\t4EKxvNFEPRupDFsGWyaNCe2EY7T/H68FZeTgqZyTGCzqvE4xMHTYQKJ/MDbho7nxxve3\n\tZZ2wsp2F9txunWvidfLilW7/XkvvsL/rqmQ8Vm2zUuwng7YMJDDlYe5q8oyhSQBMkjB6\n\tBJ5IA7wDK+lxa1KxR3UUI6iIxvnQi/diQHB6tJ0rXvUNsAAqYLidrqrAwN9BrYPC4aTt\n\tjs0VA5Qe2BNQDCLLDSSnezFKtKkgcV+RjRNxQZhZ5XzHj6ni3dtNuMTCID0oegUQRasL\n\tYl3g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1781785379; x=1782390179;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=1J5bcMG3cS5HzAUNVk+psEM90P+jr41K1tK0MCZOzXo=;\n\tb=rVMOAbF25YZOHAdY0OyKtMRcTQa9J4GoCVag6b920rOma15OFxNLiFvWaBvoXOwPMm\n\tW5MctHMA4U5L3ZbPjfvT/KUNTsAp5kTj13ReeQd+OHTAOfvjZ9RU9mSCbpQrpLjvGqFm\n\th3LZsgCogYEvfDBxgUeEHLEqn3q8QjZKiP1dYZUGEUIunkhnfNKxpKYIs+k9/521Wrn0\n\t3+P8fzmdHQXsc/Y6X4cEvN31c/D6TISsJYVqkhTRiRGmW0DvaGTag9uzXdI66KugH2Qh\n\tJvcae+ESzBgaWlgNPsrzqSIxujzFAbP8QTItLhrV0wUxIymlSd8ufhXivbc9d8I8hCvu\n\thvoA==", "X-Gm-Message-State": "AOJu0YzgmFoJeQbsATUkNhA4D+miPhTDfNCYqOBenkTOjO0ZAfeP3zHt\n\tljSlSZDCMB08I/fDnxICFtUEW8gxH3QaDOAAp0jt83bWi8g7jBuOQSTuBhPvd4JR/CzMqCJmJs4\n\tEKhjg0t0=", "X-Gm-Gg": "AfdE7clf8N1hLthzSi3F1+c+bcblyMuckZTQJfrmSGyR+WK/dfLIi5klZfBFSO9WMB0\n\toqlHpcMgczDWy2/b35k2F0mRsoH2nkdVjSVHVAzA7WDqEUQhFnU8j4H1rl/35juJlCMOS9re/ZA\n\tASZ9q7F67SYMF9a8VnKejQrDVJqefsXRcAazkyW57j1VtMnAqOXlwn9H4PvlPybQz0Lmg5UzCfy\n\tl3cxzVnwaUd4iUrDSIrEOW3ojuXX/DBXu5WprFNiM4EcrX7fhUM5QHRoNxTHxQVjKnFRACP8UMN\n\tzREh7KAeas4zPsJoUatWTlOC3Iw/uJF/7VWkuDfBsmPsmsNSpQl6Aadj7AC4jsoRnEqLiZphvdZ\n\tXSV2q808LAwGDyhaWBhMJ7M2d8CwV+kEnZpjksYfteXXpusAA07zj45m1dPhJVNf44u6SyS+61K\n\tHAnk3MTBWLn1emr7O/jD56xtbB1tQM", "X-Received": "by 2002:a05:600c:247:b0:490:bd66:e522 with SMTP id\n\t5b1f17b1804b1-492333d8c06mr108522325e9.29.1781785379367; \n\tThu, 18 Jun 2026 05:22:59 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "bryan.odonoghue@linaro.org,\n\tpavel@ucw.cz", "Subject": "[PATCH 03/30] libcamera: software_isp: gpu: rename debayerGPU to\n\tprocessGPU", "Date": "Thu, 18 Jun 2026 13:22:16 +0100", "Message-ID": "<20260618122245.946138-4-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.54.0", "In-Reply-To": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "References": "<20260618122245.946138-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This function will do more than debayer, rename it to reflect.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp_pipeline_gpu.cpp | 4 ++--\n src/libcamera/software_isp/software_isp_pipeline_gpu.h | 3 ++-\n 2 files changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\nindex c68a04fff..6f988d672 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.cpp\n@@ -511,7 +511,7 @@ void SoftwareIspPipelineGpu::setShaderVariableValues(const DebayerParams ¶ms\n \treturn;\n }\n \n-int SoftwareIspPipelineGpu::debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional<MappedFrameBuffer> *inMapped, std::optional<DmaSyncer> *inDmaSyncer)\n+int SoftwareIspPipelineGpu::processGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional<MappedFrameBuffer> *inMapped, std::optional<DmaSyncer> *inDmaSyncer)\n {\n \tbool dmabuf_import_succeeded = false;\n \n@@ -569,7 +569,7 @@ void SoftwareIspPipelineGpu::process(uint32_t frame, FrameBuffer *input, FrameBu\n \tstd::optional<MappedFrameBuffer> inMapped;\n \tstd::optional<DmaSyncer> inDmaSyncer;\n \n-\tif (debayerGPU(input, output, params, &inMapped, &inDmaSyncer)) {\n+\tif (processGPU(input, output, params, &inMapped, &inDmaSyncer)) {\n \t\tLOG(Debayer, Error) << \"debayerGPU failed\";\n \t\tgoto error;\n \t}\ndiff --git a/src/libcamera/software_isp/software_isp_pipeline_gpu.h b/src/libcamera/software_isp/software_isp_pipeline_gpu.h\nindex 6f161e063..f0515d889 100644\n--- a/src/libcamera/software_isp/software_isp_pipeline_gpu.h\n+++ b/src/libcamera/software_isp/software_isp_pipeline_gpu.h\n@@ -65,7 +65,8 @@ private:\n \tint initBayerShaders(PixelFormat inputFormat, PixelFormat outputFormat);\n \tint getShaderVariableLocations();\n \tvoid setShaderVariableValues(const DebayerParams ¶ms);\n-\tint debayerGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional<MappedFrameBuffer> *mappedInputBuffer, std::optional<DmaSyncer> *inputBufferDmaSyncer);\n+\tint processGPU(FrameBuffer *input, FrameBuffer *output, const DebayerParams ¶ms, std::optional<MappedFrameBuffer> *mappedInputBuffer, std::optional<DmaSyncer> *inputBufferDmaSyncer);\n+\tvoid configureTexture(GLuint &texture);\n \n \t/* Shader program identifiers */\n \tGLuint vertexShaderId_ = 0;\n", "prefixes": [ "03/30" ] }