Patch Detail
Show a patch.
GET /api/1.1/patches/26861/?format=api
{ "id": 26861, "url": "https://patchwork.libcamera.org/api/1.1/patches/26861/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26861/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260608150349.134371-18-mzamazal@redhat.com>", "date": "2026-06-08T15:03:46", "name": "[RFC,v4,17/17] libcamera: software_isp: Remove stats-sharing TODO item", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4244efdaf88b30ad8c16adc5c31e028a5ec6fd90", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26861/mbox/", "series": [ { "id": 5982, "url": "https://patchwork.libcamera.org/api/1.1/series/5982/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5982", "date": "2026-06-08T15:03:29", "name": "Software ISP: Share params and stats buffers", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5982/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26861/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26861/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 73DE2C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Jun 2026 15:04:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D23B61F41;\n\tMon, 8 Jun 2026 17:04:49 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5256261F1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Jun 2026 17:04:45 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-43-A9Ul4M2HOQCTuwnjnuuaig-1;\n\tMon, 08 Jun 2026 11:04:40 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 61832180058C; Mon, 8 Jun 2026 15:04:39 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.48.51])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 68DAD18005B3; Mon, 8 Jun 2026 15:04:37 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"GvANSb0s\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1780931084;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=PUQ3rffI/BqzXYrzqqZr/7ddTTGPMDReNYc7sL2Z3O0=;\n\tb=GvANSb0s8O2g1C96NvAjGtzq4hqBaorEJZ4t43elDDMLjxAv1d7e/a0GOyKIk2mFWbo+l6\n\tXU/T/0gOrN26KH7YwMVENvqcRKrySINpVSo5VYy2vrEitwFiEWXSSxVkMxXal7fxIamBM1\n\tWfOuLXEWJGPDOxCt7VTRkI/IkRBvVJQ=", "X-MC-Unique": "A9Ul4M2HOQCTuwnjnuuaig-1", "X-Mimecast-MFC-AGG-ID": "A9Ul4M2HOQCTuwnjnuuaig_1780931079", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, johannes.goede@oss.qualcomm.com", "Subject": "[RFC PATCH v4 17/17] libcamera: software_isp: Remove stats-sharing\n\tTODO item", "Date": "Mon, 8 Jun 2026 17:03:46 +0200", "Message-ID": "<20260608150349.134371-18-mzamazal@redhat.com>", "In-Reply-To": "<20260608150349.134371-1-mzamazal@redhat.com>", "References": "<20260608150349.134371-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "EVAZV1RRT9_1lJlIEYPaKqjFZP5baNgt_2OyBNwj01Q_1780931079", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Shared per-frame statistics buffers are implemented, we can remove\nTODO #2.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/software_isp/TODO.md | 27 ---------------------------\n 1 file changed, 27 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/TODO.md b/src/libcamera/software_isp/TODO.md\nindex f4e5190e0..dcdfd109f 100644\n--- a/src/libcamera/software_isp/TODO.md\n+++ b/src/libcamera/software_isp/TODO.md\n@@ -10,33 +10,6 @@ The TODO items in this section gather comments from patch review that were not\n deemed to require being addressed right away. The text in block quotes is\n copied directly from e-mail review.\n \n-### Reconsider stats sharing\n-\n-```\n->>> +void SwStatsCpu::finishFrame(void)\n->>> +{\n->>> +\t*sharedStats_ = stats_;\n->> \n->> Is it more efficient to copy the stats instead of operating directly on\n->> the shared memory ?\n->\n-> I inherited doing things this way from Andrey. I kept this because\n-> we don't really have any synchronization with the IPA reading this.\n->\n-> So the idea is to only touch this when the next set of statistics\n-> is ready since we don't know when the IPA is done with accessing\n-> the previous set of statistics ...\n->\n-> This is both something which seems mostly a theoretic problem,\n-> yet also definitely something which I think we need to fix.\n->\n-> Maybe use a ringbuffer of stats buffers and pass the index into\n-> the ringbuffer to the emit signal ?\n-\n-That would match how we deal with hardware ISPs, and I think that's a\n-good idea. It will help decoupling the processing side from the IPA.\n-```\n-\n ### Remove statsReady signal\n \n ```\n", "prefixes": [ "RFC", "v4", "17/17" ] }