Patch Detail
Show a patch.
GET /api/1.1/patches/26477/?format=api
{ "id": 26477, "url": "https://patchwork.libcamera.org/api/1.1/patches/26477/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26477/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-38-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:34:22", "name": "[v2,37/42] libcamera: global_configuration: Populate empty configuration", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ad547604ca0eeb80a9f69ce35d6d1efa9f4fb8e7", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26477/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/1.1/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26477/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26477/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BBFAC3333\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:35:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6630362E4E;\n\tTue, 7 Apr 2026 17:35:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C5A862E45\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:35:19 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0F9AA596\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rRf0lTMd\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775576032;\n\tbh=eyyjC0HOfDmuFtWQQk39lbuP6N3eQG1/g+xSi+YPFJQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=rRf0lTMd21fy55USPtjKjPnB3UclmkDG9i8zpzkcpCj8GYA6cyDrD7zDwf32OEkOu\n\tmz1RiT5Pe8DkvWmH6oDKp3mp0AvHjjKvl8SMyHYHYgxIN/Fl/BYE/QZtvOboH6X+u+\n\tPlqbPZIe6rc/wAUVP2DfnNlAX8Dk4cCmMN1kTHyY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 37/42] libcamera: global_configuration: Populate empty\n\tconfiguration", "Date": "Tue, 7 Apr 2026 18:34:22 +0300", "Message-ID": "<20260407153427.1825999-38-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "References": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If no configuration file can be parsed, populate an empty configuration.\nThis will serve as a base to store the configuration options set through\nenvironment variables.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nChanges since v1:\n\n- Move code to constructor to cover all loadFile() calls\n---\n src/libcamera/global_configuration.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex cd9cc25e43fd..c87f56c2d822 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -61,6 +61,11 @@ LOG_DEFINE_CATEGORY(Configuration)\n GlobalConfiguration::GlobalConfiguration()\n {\n \tload();\n+\n+\tif (configuration_->isEmpty()) {\n+\t\tconfiguration_->add(\"version\", std::make_unique<ValueNode>(1));\n+\t\tconfiguration_->add(\"configuration\", std::make_unique<ValueNode>());\n+\t}\n }\n \n void GlobalConfiguration::load()\n", "prefixes": [ "v2", "37/42" ] }