Patch Detail
Show a patch.
GET /api/1.1/patches/26473/?format=api
{ "id": 26473, "url": "https://patchwork.libcamera.org/api/1.1/patches/26473/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26473/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-34-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:34:18", "name": "[v2,33/42] libcamera: global_configuration: Add missing include and comment", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8bb403a549a79067e27c97035873647f7c59ff06", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26473/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/1.1/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26473/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26473/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA34EC32BB\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:35:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4554462E47;\n\tTue, 7 Apr 2026 17:35:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2160262E3E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:35:14 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8CA3798A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jj2xZPc9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775576026;\n\tbh=qxKzXGT95FCT6ihpiiKUA04SklOcwwbHdZyr4O5W5vM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Jj2xZPc9kUgJP/jxAWVhfaH2GDj1Z5GTZYUWrwCWcqobbOmpBNqN4kXPeBV773Ke+\n\tMNRIfs4uo2/13/t2x/NnOdd8+5KDKJYi75f2c+2H+2GiavI1boN5ZdxXOVjomkpd1g\n\tFj7FFNUJ4w2PHs7eqF6+qOBbHizSFbJyRKg7ngwY=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 33/42] libcamera: global_configuration: Add missing\n\tinclude and comment", "Date": "Tue, 7 Apr 2026 18:34:18 +0300", "Message-ID": "<20260407153427.1825999-34-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "References": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "global_configuration.h uses std::initializer_list, include the\ncorresponding header. Add a comment in global_configuration.cpp to close\nan anonymous namespace, as mandated by the coding style.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/global_configuration.h | 1 +\n src/libcamera/global_configuration.cpp | 4 +++-\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/global_configuration.h b/include/libcamera/internal/global_configuration.h\nindex 84bdf90244d9..80b57b38ba03 100644\n--- a/include/libcamera/internal/global_configuration.h\n+++ b/include/libcamera/internal/global_configuration.h\n@@ -8,6 +8,7 @@\n #pragma once\n \n #include <filesystem>\n+#include <initializer_list>\n #include <optional>\n #include <string>\n #include <string_view>\ndiff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex c853a028c91d..44ed206de78f 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -24,11 +24,13 @@\n namespace libcamera {\n \n namespace {\n+\n const std::vector<std::filesystem::path> globalConfigurationFiles = {\n \tstd::filesystem::path(LIBCAMERA_SYSCONF_DIR) / \"configuration.yaml\",\n \tstd::filesystem::path(LIBCAMERA_DATA_DIR) / \"configuration.yaml\",\n };\n-}\n+\n+} /* namespace */\n \n LOG_DEFINE_CATEGORY(Configuration)\n \n", "prefixes": [ "v2", "33/42" ] }