Patch Detail
Show a patch.
GET /api/1.1/patches/26456/?format=api
{ "id": 26456, "url": "https://patchwork.libcamera.org/api/1.1/patches/26456/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26456/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-17-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:34:01", "name": "[v2,16/42] libcamera: yaml_parser: Drop unneeded \\fn Doxygen commands", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b4bddde55331e564bc3f8dff2c9af55ba9737113", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26456/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/1.1/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26456/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26456/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C02CC3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:34:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B07B162DFA;\n\tTue, 7 Apr 2026 17:34:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC9CE62DD7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:34:49 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 6C3AB98A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:22 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cOvXD/CY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775576002;\n\tbh=l3tl9rSkQdjIHsfOTq97YOolveY8DWFxRMX3gRoKTYY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=cOvXD/CY604HVBzdHDqKqMZ98+JQr5QkEUmmIxj/D0SVvN4NClkjKbOMHzvHj/EEE\n\tUoJEgDCE6RdLvcKMcWw0Aaw2Ye561Y5Y/fV01oyTWD5J1qXTuxMw5i1VP8FOwoHK5D\n\tdpvd9fXhBnDwHpDSuSMZZkVa0jKZdqBFTl44UqIo=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 16/42] libcamera: yaml_parser: Drop unneeded \\fn Doxygen\n\tcommands", "Date": "Tue, 7 Apr 2026 18:34:01 +0300", "Message-ID": "<20260407153427.1825999-17-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "References": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There's no need to specify the function name in Doxygen comment blocks\nwith \\fn if the documentation directly precedes the function definition.\nDrop the unneeded \\fn.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/yaml_parser.cpp | 7 -------\n 1 file changed, 7 deletions(-)", "diff": "diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex bf098360191b..46369c6bc6a3 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -86,7 +86,6 @@ YamlObject::~YamlObject() = default;\n */\n \n /**\n- * \\fn YamlObject::size()\n * \\brief Retrieve the number of elements in a dictionary or list YamlObject\n *\n * This function retrieves the size of the YamlObject, defined as the number of\n@@ -529,7 +528,6 @@ YamlParserContext::~YamlParserContext()\n }\n \n /**\n- * \\fn YamlParserContext::init()\n * \\brief Initialize a parser with an opened file for parsing\n * \\param[in] fh The YAML file to parse\n *\n@@ -568,7 +566,6 @@ int YamlParserContext::yamlRead(void *data, unsigned char *buffer, size_t size,\n }\n \n /**\n- * \\fn YamlParserContext::nextEvent()\n * \\brief Get the next event\n *\n * Get the next event in the current YAML event stream, and return nullptr when\n@@ -597,7 +594,6 @@ YamlParserContext::EventPtr YamlParserContext::nextEvent()\n }\n \n /**\n- * \\fn YamlParserContext::parseContent()\n * \\brief Parse the content of a YAML document\n * \\param[in] yamlObject The result of YamlObject\n *\n@@ -636,7 +632,6 @@ int YamlParserContext::parseContent(YamlObject &yamlObject)\n }\n \n /**\n- * \\fn YamlParserContext::readValue()\n * \\brief Parse event scalar and fill its content into a string\n *\n * A helper function to parse a scalar event as string. The caller needs to\n@@ -651,7 +646,6 @@ std::string YamlParserContext::readValue(const EventPtr &event)\n }\n \n /**\n- * \\fn YamlParserContext::parseDictionaryOrList()\n * \\brief A helper function to abstract the common part of parsing dictionary or list\n * \\param[in] endEventType The YAML end event type (sequence or mapping)\n * \\param[in] parseItem The callback to handle an item\n@@ -695,7 +689,6 @@ int YamlParserContext::parseDictionaryOrList(yaml_event_type_t endEventType,\n }\n \n /**\n- * \\fn YamlParserContext::parseNextYamlObject()\n * \\brief Parse next YAML event and read it as a YamlObject\n * \\param[in] yamlObject The result of YamlObject\n * \\param[in] event The leading event of the object\n", "prefixes": [ "v2", "16/42" ] }