Patch Detail
Show a patch.
GET /api/1.1/patches/26441/?format=api
{ "id": 26441, "url": "https://patchwork.libcamera.org/api/1.1/patches/26441/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26441/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-2-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:33:46", "name": "[v2,01/42] libcamera: Drop unneeded usage of this pointer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c075be8ebeabd2136bdb24b46030a94c8a599df5", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26441/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/1.1/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26441/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26441/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 527ECBDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:34:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3FF0062DAC;\n\tTue, 7 Apr 2026 17:34:33 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1066F62D95\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:34:30 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 77E326A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:02 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TaPyhsoi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775575982;\n\tbh=9FbfwYofHyzwmmR3Qjf9uUfZyR1GSto0PS3FDU59jvs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=TaPyhsoixfc3mLfDLzpv8oo6X/u9jYVi67WZCGD+JomfXsARElLGs0Ym5kdMbESXH\n\t8Pfcxjwpe49NJUdwM5GxlW8aSJ8IcIoKbcocc8HHnS64amPUVbaZmGx/IYU4FoPzv2\n\tlyzo9m6m3n7M7tHU8Kbnwv4NGCp+27q5Udpt8CLQ=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 01/42] libcamera: Drop unneeded usage of this pointer", "Date": "Tue, 7 Apr 2026 18:33:46 +0300", "Message-ID": "<20260407153427.1825999-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "References": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A few unneeded usages of the this pointer to qualify access to class\nmembers have been introduced over time. Drop them.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nChanges since v1:\n\n- Fix typo in commit message\n---\n include/libcamera/internal/shared_mem_object.h | 4 ++--\n src/libcamera/camera_manager.cpp | 2 +-\n src/libcamera/shared_mem_object.cpp | 8 ++++----\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nindex e9f1dacd731d..21e025513fdf 100644\n--- a/include/libcamera/internal/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -79,7 +79,7 @@ public:\n \tSharedMemObject(SharedMemObject<T> &&rhs)\n \t\t: SharedMem(std::move(rhs))\n \t{\n-\t\tthis->obj_ = rhs.obj_;\n+\t\tobj_ = rhs.obj_;\n \t\trhs.obj_ = nullptr;\n \t}\n \n@@ -92,7 +92,7 @@ public:\n \tSharedMemObject<T> &operator=(SharedMemObject<T> &&rhs)\n \t{\n \t\tSharedMem::operator=(std::move(rhs));\n-\t\tthis->obj_ = rhs.obj_;\n+\t\tobj_ = rhs.obj_;\n \t\trhs.obj_ = nullptr;\n \t\treturn *this;\n \t}\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 23185467ba02..fc6e490bc476 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -41,7 +41,7 @@ LOG_DEFINE_CATEGORY(Camera)\n CameraManager::Private::Private()\n \t: Thread(\"CameraManager\"), initialized_(false)\n {\n-\tipaManager_ = std::make_unique<IPAManager>(this->configuration());\n+\tipaManager_ = std::make_unique<IPAManager>(configuration());\n }\n \n int CameraManager::Private::start()\ndiff --git a/src/libcamera/shared_mem_object.cpp b/src/libcamera/shared_mem_object.cpp\nindex d9b61d37dd43..6edab045d47e 100644\n--- a/src/libcamera/shared_mem_object.cpp\n+++ b/src/libcamera/shared_mem_object.cpp\n@@ -80,8 +80,8 @@ SharedMem::SharedMem(const std::string &name, std::size_t size)\n */\n SharedMem::SharedMem(SharedMem &&rhs)\n {\n-\tthis->fd_ = std::move(rhs.fd_);\n-\tthis->mem_ = rhs.mem_;\n+\tfd_ = std::move(rhs.fd_);\n+\tmem_ = rhs.mem_;\n \trhs.mem_ = {};\n }\n \n@@ -109,8 +109,8 @@ SharedMem::~SharedMem()\n */\n SharedMem &SharedMem::operator=(SharedMem &&rhs)\n {\n-\tthis->fd_ = std::move(rhs.fd_);\n-\tthis->mem_ = rhs.mem_;\n+\tfd_ = std::move(rhs.fd_);\n+\tmem_ = rhs.mem_;\n \trhs.mem_ = {};\n \treturn *this;\n }\n", "prefixes": [ "v2", "01/42" ] }