Patch Detail
Show a patch.
GET /api/1.1/patches/2644/?format=api
{ "id": 2644, "url": "https://patchwork.libcamera.org/api/1.1/patches/2644/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2644/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200114114430.5910-1-laurent.pinchart@ideasonboard.com>", "date": "2020-01-14T11:44:30", "name": "[libcamera-devel] libcamera: gen-controls.py: Don't hardcode path to python interpreter", "commit_ref": "055335bf49dbcb8c149bdcd4e96004c68e6b6ece", "pull_url": null, "state": "accepted", "archived": false, "hash": "4e780171fae9e810e56d2f0abaf99d6509387f65", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2644/mbox/", "series": [ { "id": 623, "url": "https://patchwork.libcamera.org/api/1.1/series/623/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=623", "date": "2020-01-14T11:44:30", "name": "[libcamera-devel] libcamera: gen-controls.py: Don't hardcode path to python interpreter", "version": 1, "mbox": "https://patchwork.libcamera.org/series/623/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2644/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2644/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D392160747\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2020 12:44:46 +0100 (CET)", "from pendragon.ideasonboard.com\n\t(cpc108967-cmbg20-2-0-cust420.5-4.cable.virginm.net [81.101.7.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5503E2F9;\n\tTue, 14 Jan 2020 12:44:46 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579002286;\n\tbh=bUIRHMBJLifVI0XWHveWl1PgLoKa6ZtxrXoSPAAl54M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=XRtaiAZ6WmlVPVLPJFjs4NQeT7kSFMpjx7UVqDG+OYSAor2kaTSPV7aSWowqHc4vq\n\tBqLxJlK/UhOv0rHesDcToLq/ThlNYLI+hCMk5mGZU4pZ6oeuSIaul/rRfiScRW1gcN\n\tSy5fdUtxMWPVQD7/atJdv81Qs1Hk3HLErPBGeU1k=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Madhavan Krishnan <madhavan.krishnan@linaro.org>", "Date": "Tue, 14 Jan 2020 13:44:30 +0200", "Message-Id": "<20200114114430.5910-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.24.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: gen-controls.py: Don't\n\thardcode path to python interpreter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 14 Jan 2020 11:44:47 -0000" }, "content": "The gen-controls.py script hardcodes the path to the python interpreter\nto /usr/bin/python3 in the first line of the script. This hardcodes\nusage of the host python3, even when building in cross-compilation\nenvironments that may ship their own version of python. Fix it by\nsetting the interpreter to '/usr/bin/env python3'.\n\nReported-by: Madhavan Krishnan <madhavan.krishnan@linaro.org>\nSuggested-by: Nicolas Dufresne <nicolas@ndufresne.ca>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/gen-controls.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\nindex 940386cc68c8..2e5ac5c81cca 100755\n--- a/src/libcamera/gen-controls.py\n+++ b/src/libcamera/gen-controls.py\n@@ -1,4 +1,4 @@\n-#!/usr/bin/python3\n+#!/usr/bin/env python3\n # SPDX-License-Identifier: GPL-2.0-or-later\n # Copyright (C) 2019, Google Inc.\n #\n", "prefixes": [ "libcamera-devel" ] }