Patch Detail
Show a patch.
GET /api/1.1/patches/26413/?format=api
{ "id": 26413, "url": "https://patchwork.libcamera.org/api/1.1/patches/26413/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26413/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260401-mali-cru-v8-6-44c48f990e28@ideasonboard.com>", "date": "2026-04-01T16:25:55", "name": "[v8,6/8] libcamera: mali-c55: Do not rely on bufferCount", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c7314c5682c3fa7f983a3a45539c93b1be1b82a2", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26413/mbox/", "series": [ { "id": 5864, "url": "https://patchwork.libcamera.org/api/1.1/series/5864/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5864", "date": "2026-04-01T16:25:49", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5864/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26413/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26413/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E05F9C32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 1 Apr 2026 16:26:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25ECF62D79;\n\tWed, 1 Apr 2026 18:26:10 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1F5C62D58\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 1 Apr 2026 18:26:02 +0200 (CEST)", "from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 673561B0C;\n\tWed, 1 Apr 2026 18:24:39 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oZzkdZRT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775060679;\n\tbh=L5j9uJQPSeneKNWyQ0HTWyYejmERbJhTNJMOPIbNeFY=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=oZzkdZRTQDHM3He3cqUd4O9Mk3WFsy1ECfDSwKVP6Z+35wY5NB8who+k+zFET7dr9\n\tGm0G4nbwu7srn80DGtzPH1cFBAV0NHKu/P4CryIJ6zwYUpdQURwmApNsWLlAt3v0OW\n\tbR8FyTJahJBvpfSg+iwOqTRGxtgXOh6gDjMHR6gU=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 01 Apr 2026 18:25:55 +0200", "Subject": "[PATCH v8 6/8] libcamera: mali-c55: Do not rely on bufferCount", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260401-mali-cru-v8-6-44c48f990e28@ideasonboard.com>", "References": "<20260401-mali-cru-v8-0-44c48f990e28@ideasonboard.com>", "In-Reply-To": "<20260401-mali-cru-v8-0-44c48f990e28@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2258;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=L5j9uJQPSeneKNWyQ0HTWyYejmERbJhTNJMOPIbNeFY=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpzUcXcOJcK4dCB50aYkv8MGTOASvilB6Jdn3nO\n\tzqLtcAcUDCJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCac1HFwAKCRByNAaPFqFW\n\tPDzREADEhCfnH5cC1t80/Hs/YDYe2NZ+ngKhO3IrdpNsJzte6tzs1VACcW6MJBQo/qd5V3G1DUI\n\tzJJG/mB2/IqycGKh/aa2na8AnDspiQbdCVQKNqTjvGDWb6SsBD4OKzg9SYF0f3R4ZckKbTQVrXQ\n\tIyFLO3l4XMIDu8WrXQG2SgnmcQAaKR3Z+POLdfggR1WzQu5XhB+f+8nPRgqYNtDcD2BvIIckxN+\n\tNdAOkZd+PzZH+G/F10E5MOLNu2xRVsOFT9n4Ap3fBZ9nGhSPMuk785gIrT1oa4w8Gk8OoA69dyR\n\t0ObiMxk8xktO1vQAmyAGSYFXbcWH5Wa8YquzhtV/Q12PS59HXAf0qWYBMBfisfT6NHiB9yykCq9\n\tzTOQOeE1cwW0ehCuJXeeQhUU2v2naLDGWY7eUNKuwrTJ3FFFsNwIeQeQn6WCChjZZx1Ip0sewX6\n\t0NnP46X99xN8R7u201VanPKumyH0OIiseKE+m8JEJL9y5SC3oY275QynD6T8pUza8211Yz2sLt0\n\tmQ3FlmxzUNjGelMiu1m9z3NdehcB/v6C/HvTL+zAfKUGeQkI/V/fUDeNXgOl6z1RkUlIAB+xRUe\n\tA5wGIpwbpz2+JpuYBwUgVvUk/uubCuiUnMe36yB94FVRJ86g0xlRx8DCYchtnsaLeGazW0cYePn\n\t57F+3d2GGIP8Yig==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Do not rely on bufferCount for the allocation of parameters and stats\nbuffers but add instead kMaliC55BufferCount which is also used to limit\nthe number of in-flight requests supported by the pipeline handler.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 14 +++++---------\n 1 file changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 566fa0549675..9df35585fef0 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -48,6 +48,8 @@\n \n namespace {\n \n+static constexpr unsigned int kMaliC55BufferCount = 8;\n+\n bool isFormatRaw(const libcamera::PixelFormat &pixFmt)\n {\n \treturn libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n@@ -778,7 +780,7 @@ private:\n };\n \n PipelineHandlerMaliC55::PipelineHandlerMaliC55(CameraManager *manager)\n-\t: PipelineHandler(manager), dsFitted_(true)\n+\t: PipelineHandler(manager, kMaliC55BufferCount), dsFitted_(true)\n {\n }\n \n@@ -1227,14 +1229,8 @@ int PipelineHandlerMaliC55::allocateBuffers(Camera *camera)\n {\n \tMaliC55CameraData *data = cameraData(camera);\n \tunsigned int ipaBufferId = 1;\n-\tunsigned int bufferCount;\n \tint ret;\n \n-\tbufferCount = std::max({\n-\t\tdata->frStream_.configuration().bufferCount,\n-\t\tdata->dsStream_.configuration().bufferCount,\n-\t});\n-\n \tauto pushBuffers = [&](const std::vector<std::unique_ptr<FrameBuffer>> &buffers,\n \t\t\t std::queue<FrameBuffer *> &queue,\n \t\t\t std::vector<IPABuffer> &ipaBuffers) {\n@@ -1249,14 +1245,14 @@ int PipelineHandlerMaliC55::allocateBuffers(Camera *camera)\n \t\t}\n \t};\n \n-\tret = stats_->allocateBuffers(bufferCount, &statsBuffers_);\n+\tret = stats_->allocateBuffers(kMaliC55BufferCount, &statsBuffers_);\n \tif (ret < 0)\n \t\treturn ret;\n \n \tpushBuffers(statsBuffers_, availableStatsBuffers_,\n \t\t data->ipaStatBuffers_);\n \n-\tret = params_->allocateBuffers(bufferCount, ¶msBuffers_);\n+\tret = params_->allocateBuffers(kMaliC55BufferCount, ¶msBuffers_);\n \tif (ret < 0)\n \t\treturn ret;\n \n", "prefixes": [ "v8", "6/8" ] }