Patch Detail
Show a patch.
GET /api/1.1/patches/26398/?format=api
{ "id": 26398, "url": "https://patchwork.libcamera.org/api/1.1/patches/26398/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26398/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260331-mali-cru-v7-8-4caedc898a0e@ideasonboard.com>", "date": "2026-03-31T16:36:36", "name": "[v7,8/8] libcamera: mali-c55: Fix sensor size computation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c316a80ebcbf0901c3362311a408f227862c38e", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26398/mbox/", "series": [ { "id": 5860, "url": "https://patchwork.libcamera.org/api/1.1/series/5860/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5860", "date": "2026-03-31T16:36:28", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5860/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26398/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26398/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17531C32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 31 Mar 2026 16:37:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C4D762D45;\n\tTue, 31 Mar 2026 18:37:00 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BCE862D28\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 31 Mar 2026 18:36:52 +0200 (CEST)", "from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F0C2B20FF;\n\tTue, 31 Mar 2026 18:35:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uPc3k8BP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774974930;\n\tbh=KJL2CcIY5VX/RCnpQMI88gQPmVI3D0wCVe1eWSxWWGU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=uPc3k8BP9C7g8J3Xav5ZyKzn2LT981wSkdkbuH/ibOMqMyqcsNTBcxQgOXaikkAWm\n\tmvk333fT//giMXnv7HHjHJgRd9Hvr2Z+r4sETKnL2uQFCSBd4LOEG+ziaMdPzn6M12\n\tJT1sLehhrIzuRoo2nqe7ZbPeuPaeqaYF6BBML3hk=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Tue, 31 Mar 2026 18:36:36 +0200", "Subject": "[PATCH v7 8/8] libcamera: mali-c55: Fix sensor size computation", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260331-mali-cru-v7-8-4caedc898a0e@ideasonboard.com>", "References": "<20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com>", "In-Reply-To": "<20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1117;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=KJL2CcIY5VX/RCnpQMI88gQPmVI3D0wCVe1eWSxWWGU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpy/ghF8ruG/QF+yIvRiZWI/Vca/YkENSuWl9pM\n\tL/y6U4XDrSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacv4IQAKCRByNAaPFqFW\n\tPKIWD/9EdF1XIH9Y8E1Lst0fSJI0ezYG6R15ppet5gjolFuhL2KHmC9V0DdCN/7Ax6pbmsiQegI\n\tqU7slqTvy8Pab88riWGUb28rg5GSfXjyHccQ7Xe40rfR6sdK/8FTK6pSGajzpNlr6Eid/CHq5ag\n\tybAcdHBuuX7o7EQbzzHzcKAXZitPab+7mjMRYaatOyqKALqPxS8LFvbLv8dRRSJ7O+JTlVBxI9w\n\t7JKK1JH9vdKON7Vkh7Mo05YbCqxiHLxxlDFA2gAchS3SHLggdRVIc3/oIlBPHd3lwaeqas5YixY\n\ttgIkcrU5Mh303CVD87YKexKdAJ+53WwdCNqcOXIIdJZTg4l7hNFRzJnbzOEojdYeHuLKovf7ATJ\n\t1LQNxWp3aQ3H3pPEIc1gLXLalkc5l+7KC2Yged/TxawDrqyj/LgVosSPyjJQ3u7WVGsFsN5LQg8\n\tMSG3EslQTCmzwdmmr95lM79Ad9yTOFQ6FJmSSArUqJXQevdD80FjFyVwn1y56PwkBqyM++wVDIS\n\tvqzDQpMlUb+eNz6x3wFSXW8EPkcRW18V1ukiY/K9bF/emywoeAJaxybj9EgAFvq+nG4GC+hekdy\n\t4JAw43ZlYrre/tvl3nx3gbjijz/rQqfX4IYLoU/mA3JHLBOjtxuysGIHZMEGSuvKvuIE7L6Fl4C\n\th5AQbjjVtlqtdwA==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The last size in the list is always selected unconditionally because\nthe current best distance is not updated properly during the search.\n\nFix the size computation procedure which has an inverted assignment.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Daniel Scally <dan.scally@ideasonboard.com>\nTested-by: Daniel Scally <dan.scally@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex c3856f7c0a11..3d502855dede 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -662,7 +662,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n \t\t\t\tstd::abs(static_cast<int>(minSensorSize.height) -\n \t\t\t\t\t static_cast<int>(size.height));\n \t\tif (dist < distance) {\n-\t\t\tdist = distance;\n+\t\t\tdistance = dist;\n \t\t\tbestSize = size;\n \t\t}\n \t}\n", "prefixes": [ "v7", "8/8" ] }