Patch Detail
Show a patch.
GET /api/1.1/patches/26396/?format=api
{ "id": 26396, "url": "https://patchwork.libcamera.org/api/1.1/patches/26396/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26396/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260331-mali-cru-v7-6-4caedc898a0e@ideasonboard.com>", "date": "2026-03-31T16:36:34", "name": "[v7,6/8] libcamera: mali-c55: Do not rely on bufferCount", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "83816608daea8172a6d585250019bc063e87c21a", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26396/mbox/", "series": [ { "id": 5860, "url": "https://patchwork.libcamera.org/api/1.1/series/5860/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5860", "date": "2026-03-31T16:36:28", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5860/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26396/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26396/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26860C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 31 Mar 2026 16:37:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF14362D1E;\n\tTue, 31 Mar 2026 18:36:58 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C704E62D22\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 31 Mar 2026 18:36:51 +0200 (CEST)", "from [100.93.44.16] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 496912451;\n\tTue, 31 Mar 2026 18:35:29 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fBjiKtJv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774974929;\n\tbh=t/458MfNw43ZCbnpnbloRwKiZfi2yr4wEtFyXhslYiE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=fBjiKtJvyMFsR+lcP6irGpSVl7+vLwluN9nqlCBCHK/A6n880quOorFo121mCIIVa\n\tjRFVCg71ndZ5cHHKdcJ2jcRTVO9J4D950weTXokMs4SnilJMsEjnkOGqFtGS/9U5xg\n\tjCa4sxkx5laFQDB/yvLgRwrfP7UwCoD+TBpsxPyc=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Tue, 31 Mar 2026 18:36:34 +0200", "Subject": "[PATCH v7 6/8] libcamera: mali-c55: Do not rely on bufferCount", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260331-mali-cru-v7-6-4caedc898a0e@ideasonboard.com>", "References": "<20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com>", "In-Reply-To": "<20260331-mali-cru-v7-0-4caedc898a0e@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=2194;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=t/458MfNw43ZCbnpnbloRwKiZfi2yr4wEtFyXhslYiE=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpy/ggskkAOY1Dw14XQ4F3ZxLM4C1pIf6MN8iMw\n\tQwSfLJX6MyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacv4IAAKCRByNAaPFqFW\n\tPDWVD/4vnW8QFFwzPPVUg8akvB/BW2QizhPvHsFf+RSQ9n1wwokaylcx8Ou7M2PyYQQGUmd6ovC\n\tr18byXqpo9ADdgZdb3QA34xCp8+V9kGn8R++5D0/7nkDB5w8Dm+HiwmMP3fyCc3Rg+NGQwd2GWv\n\t5fe0j0Dmha1yOZWaLtX5HpiWHTH2w6jmRPvwMIWUiIu9ZTSwuO7ppzmll2X0IiT+FlBSrhMjBuk\n\trH9XzEHhLJmj4kmFrFZqAZ5JrZlr7JRqHf9cV55bdR3nxwOJTUrjrW8LHcn6j9dfjYXG2f9Ju7j\n\tAsRnB+YvfLUjeCfRGzHyMtLTy58xiYG8Pes8f6+sx89qhBEh5RJcppubYuikPPef2PQsdbv66NM\n\tsR2mFn5LMh10MddV4E8m17mP3GM94AKjviOz/BiB1vNVQtGhUCYGrYoR5kTy96bY5qAFiYka3PP\n\tZXzGWnk0YCBIAJ9/5hRFDNUKY/xD4316TtU2WP/ElEYzTGsZWCLbvJjMJ/r2TSpr0xUeJvh4NEZ\n\tzdDPQ8haosSH/QFwAWNBu+3k7tUU5oJ+cTqvUa1HfhnbKcmIyyxQbRqwwD2TeB+r+XuAmLlscFh\n\tp4VstnqM71gxQzv0hmB4lsQOq/la1z8sOUySvpQgOm8Jn/qMHC7AyhL47Jobz6/+Uy32Gfn1y+t\n\tV5THrVz+lg4uJLQ==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Do not rely on bufferCount for the allocation of parameters and stats\nbuffers but add instead kMaliC55BufferCount which is also used to limit\nthe number of in-flight requests supported by the pipeline handler.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 14 +++++---------\n 1 file changed, 5 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 566fa0549675..ce1f0b65cd6e 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -48,6 +48,8 @@\n \n namespace {\n \n+static constexpr unsigned int kMaliC55BufferCount = 16;\n+\n bool isFormatRaw(const libcamera::PixelFormat &pixFmt)\n {\n \treturn libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n@@ -778,7 +780,7 @@ private:\n };\n \n PipelineHandlerMaliC55::PipelineHandlerMaliC55(CameraManager *manager)\n-\t: PipelineHandler(manager), dsFitted_(true)\n+\t: PipelineHandler(manager, kMaliC55BufferCount), dsFitted_(true)\n {\n }\n \n@@ -1227,14 +1229,8 @@ int PipelineHandlerMaliC55::allocateBuffers(Camera *camera)\n {\n \tMaliC55CameraData *data = cameraData(camera);\n \tunsigned int ipaBufferId = 1;\n-\tunsigned int bufferCount;\n \tint ret;\n \n-\tbufferCount = std::max({\n-\t\tdata->frStream_.configuration().bufferCount,\n-\t\tdata->dsStream_.configuration().bufferCount,\n-\t});\n-\n \tauto pushBuffers = [&](const std::vector<std::unique_ptr<FrameBuffer>> &buffers,\n \t\t\t std::queue<FrameBuffer *> &queue,\n \t\t\t std::vector<IPABuffer> &ipaBuffers) {\n@@ -1249,14 +1245,14 @@ int PipelineHandlerMaliC55::allocateBuffers(Camera *camera)\n \t\t}\n \t};\n \n-\tret = stats_->allocateBuffers(bufferCount, &statsBuffers_);\n+\tret = stats_->allocateBuffers(kMaliC55BufferCount, &statsBuffers_);\n \tif (ret < 0)\n \t\treturn ret;\n \n \tpushBuffers(statsBuffers_, availableStatsBuffers_,\n \t\t data->ipaStatBuffers_);\n \n-\tret = params_->allocateBuffers(bufferCount, ¶msBuffers_);\n+\tret = params_->allocateBuffers(kMaliC55BufferCount, ¶msBuffers_);\n \tif (ret < 0)\n \t\treturn ret;\n \n", "prefixes": [ "v7", "6/8" ] }