Patch Detail
Show a patch.
GET /api/1.1/patches/26363/?format=api
{ "id": 26363, "url": "https://patchwork.libcamera.org/api/1.1/patches/26363/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26363/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260325151416.2114564-22-stefan.klug@ideasonboard.com>", "date": "2026-03-25T15:13:53", "name": "[v2,21/32] ipa: rkisp1: Allow processStats() to be called without stats buffer", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fa22b91c93076d875a41e499e3a29dcaa0d65e48", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26363/mbox/", "series": [ { "id": 5849, "url": "https://patchwork.libcamera.org/api/1.1/series/5849/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5849", "date": "2026-03-25T15:13:32", "name": "rkisp1: pipeline rework for PFC", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5849/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26363/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26363/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D22B9C3304\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Mar 2026 15:15:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 631C762C7D;\n\tWed, 25 Mar 2026 16:15:41 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B01B62C44\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2026 16:15:40 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b16a:5ed9:4ada:a95a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 73CE71992; \n\tWed, 25 Mar 2026 16:14:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZBVuDrcg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774451662;\n\tbh=ZvkKBAI6BWqkHPAtWOtsQMkeg8HSUtRWRmQVERiUozw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZBVuDrcgyyGmNGJqBEAn6Ri8ooEEJ6hkVroYJ/jLLUbgFCviJGy+AwtgOInaaxQCX\n\tEvWp04t5igVCsxOp/fK/EkwZ8+GZut+n9pMUstDK052/son5c3LdCk+0jrZgFvK9LD\n\tgcn/gSxcvoxVizYUz7RZQSFs2ZdhXK4FgiDZi9CQ=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 21/32] ipa: rkisp1: Allow processStats() to be called\n\twithout stats buffer", "Date": "Wed, 25 Mar 2026 16:13:53 +0100", "Message-ID": "<20260325151416.2114564-22-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260325151416.2114564-1-stefan.klug@ideasonboard.com>", "References": "<20260325151416.2114564-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When there are no stats available for a frame, it still makes sense to\ncall processStats() to fill in the metadata of that frame. This\nmechanism is already used for the raw path. Allow it's use for non-raw\nalso.\n\nThe current code never produces buffers with id 0, but it is not\nenforced. Add a assert to enforce that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Added an assert to ensure there is no buffer with id 0\n---\n src/ipa/rkisp1/rkisp1.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 3f943a08d011..88cf6afc219d 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -304,6 +304,9 @@ int IPARkISP1::configure(const IPAConfigInfo &ipaConfig,\n void IPARkISP1::mapBuffers(const std::vector<IPABuffer> &buffers)\n {\n \tfor (const IPABuffer &buffer : buffers) {\n+\t\t/* A buffer id of 0 is considered invalid */\n+\t\tASSERT(buffer.id != 0);\n+\n \t\tauto elem = buffers_.emplace(std::piecewise_construct,\n \t\t\t\t\t std::forward_as_tuple(buffer.id),\n \t\t\t\t\t std::forward_as_tuple(buffer.planes));\n@@ -389,7 +392,7 @@ void IPARkISP1::processStats(const uint32_t frame, const uint32_t bufferId,\n \t * provided.\n \t */\n \tconst rkisp1_stat_buffer *stats = nullptr;\n-\tif (!context_.configuration.raw)\n+\tif (bufferId != 0)\n \t\tstats = reinterpret_cast<rkisp1_stat_buffer *>(\n \t\t\tmappedBuffers_.at(bufferId).planes()[0].data());\n \n", "prefixes": [ "v2", "21/32" ] }