Patch Detail
Show a patch.
GET /api/1.1/patches/26344/?format=api
{ "id": 26344, "url": "https://patchwork.libcamera.org/api/1.1/patches/26344/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26344/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260325151416.2114564-3-stefan.klug@ideasonboard.com>", "date": "2026-03-25T15:13:34", "name": "[v2,02/32] libcamera: delayed_controls: Handle missed pushes", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "e3d89751a5153c518fba131dfc3ec78b4a9163c4", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26344/mbox/", "series": [ { "id": 5849, "url": "https://patchwork.libcamera.org/api/1.1/series/5849/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5849", "date": "2026-03-25T15:13:32", "name": "rkisp1: pipeline rework for PFC", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5849/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26344/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26344/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D60CAC32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Mar 2026 15:14:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34A5562841;\n\tWed, 25 Mar 2026 16:14:50 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BB4A627D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2026 16:14:48 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b16a:5ed9:4ada:a95a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0881412BB; \n\tWed, 25 Mar 2026 16:13:30 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sgRNSEwF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774451610;\n\tbh=l3vpLe0XYWTCBdGP+/6jXvvI83rewD783FNSy/pnRwE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sgRNSEwF2ugLbLSGNEDZlMKMX44vXkN0V94R/sEFkIdCJMKLFso7gl/Cp+jv3PTcf\n\ta5NHql5Sd5UfWq4q+GGR3YyT7M4+eUe3t9TPhqYI66a9EtXSfvev2FxQlSzpBgw/a/\n\tpt82GCacjVi6r59bO/2eNeGrGji7hlne/k4OH+DA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v2 02/32] libcamera: delayed_controls: Handle missed pushes", "Date": "Wed, 25 Mar 2026 16:13:34 +0100", "Message-ID": "<20260325151416.2114564-3-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260325151416.2114564-1-stefan.klug@ideasonboard.com>", "References": "<20260325151416.2114564-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In unstable systems it can happen, that some sequence numbers are missed\nin the IPA. Gracefully handle that situation by queuing no-ops.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tag\n---\n src/libcamera/delayed_controls.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 36d1f20a3680..dc3850c0885d 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -178,6 +178,15 @@ bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n \t\t\t<< \" current queue index: \" << queueCount_;\n \t}\n \n+\twhile (sequence > queueCount_) {\n+\t\tLOG(DelayedControls, Warning)\n+\t\t\t<< \"Missed push for sequence \" << queueCount_\n+\t\t\t<< \" Auto queue no-op.\";\n+\t\tpush(queueCount_, {});\n+\t}\n+\n+\tASSERT(sequence == queueCount_);\n+\n \t/* Copy state from previous frame. */\n \tfor (auto &ctrl : values_) {\n \t\tInfo &info = ctrl.second[queueCount_];\n", "prefixes": [ "v2", "02/32" ] }