Patch Detail
Show a patch.
GET /api/1.1/patches/26339/?format=api
{ "id": 26339, "url": "https://patchwork.libcamera.org/api/1.1/patches/26339/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26339/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260325-mali-cru-v6-5-b16b0c49819a@ideasonboard.com>", "date": "2026-03-25T14:44:12", "name": "[v6,5/7] libcamera: mali-c55: Configure camera in memory-to-memory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f9443c90a2fdf06aeb528e5d7042ddc545bfba02", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26339/mbox/", "series": [ { "id": 5848, "url": "https://patchwork.libcamera.org/api/1.1/series/5848/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5848", "date": "2026-03-25T14:44:07", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5848/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26339/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26339/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F25AEC32F7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Mar 2026 14:44:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1C536283B;\n\tWed, 25 Mar 2026 15:44:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61B186274D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Mar 2026 15:44:20 +0100 (CET)", "from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5F5FC12BB;\n\tWed, 25 Mar 2026 15:43:02 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hce/ANx4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774449782;\n\tbh=sP0IWdRDNIIoDrW3dfKUPHYNyxEAn42AOQ7h2wJnwIs=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Hce/ANx41uhdH+xPBlQCiWl/7jq838ZpPJ/uWi76g1qPhgL5opoblSYI+odv/mYSD\n\tpQcOnmUw4EO3QXUaCbBsdRAGJCq4z3ih50PMZQWYyPh/zPSHwrryTbhPCs1V2ipsD3\n\tbsIOEYbxqBj5szTxPIIwUUvNNoRggGQ0bf2F0Zx0=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 25 Mar 2026 15:44:12 +0100", "Subject": "[PATCH v6 5/7] libcamera: mali-c55: Configure camera in\n\tmemory-to-memory", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260325-mali-cru-v6-5-b16b0c49819a@ideasonboard.com>", "References": "<20260325-mali-cru-v6-0-b16b0c49819a@ideasonboard.com>", "In-Reply-To": "<20260325-mali-cru-v6-0-b16b0c49819a@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tJacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1783;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=sP0IWdRDNIIoDrW3dfKUPHYNyxEAn42AOQ7h2wJnwIs=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpw/TBFOcfItju3wI/6K0agWpPfOVINColHeEFx\n\tIauDWpntk+JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCacP0wQAKCRByNAaPFqFW\n\tPJoyD/9k/UmLYEncMNbIEINmNyDPHYNEC/k7kijP+2r2IZKEgoVGt5oFFsiOCTkt2/4zGN+m1TN\n\tPOYywo64l8WPCvWpZpIhNPUIUMnbEz987EkpVdNL0BK85C5eZkQQHNJdeDhX7I0Pv2x6pfmCY9v\n\tGygTtqtbcdqG3VstHy1ZV1iiOk1BOxgaroH8DhtBM4FehFkGqEyBboiAcFgNBdU/aQgu2KSmi74\n\tKY5L/R95ki9dFbaInfzTuto2chglsL41dPNldpozCNhptq38in967KGfDisK3Ydve3dX/Fh+WHr\n\tlIGizyQoEHGBYA9/gYeaaF2HEYFBhbxwzKp3a6rA+1ec1GNQKN9lGKivurzdeebQHVEX1TjBnkl\n\tTysNJiRBQ5HaZsfXicPYNzaoAJZtobdaTV/QnAFxrmT3dJ/aapFuz+WUmL/J8kulqu8xPhEZHrI\n\tb3htcWfefKuKtqZv1Q7svuUX/UDxtPfggn6shG7ARQWdbBlBCvIGaCqBMZ2xYbLrJoYQAOEPy49\n\tM5gt1+FVEpaZ7W3um3hKWbSjsJmSqeCEM+HNIkt8CKqF77I5uoezhxPTu17TsAmvlqrT5eWgMG3\n\tvQ19LCKCC8WVQ8JoYz7aBoPU6oH6+8Jf0gyVjKYuctBFb50k2PD3L331Rqv1Yt061JqRM9C2gkG\n\tOrcpep4uh0aU2Kw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for memory-to-memory Camera to the\nPipelineHandlerMaliC55::configure() function.\n\nStart by enabling the IVC links, then configure the CRU and\npropagate the format to the IVC.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 24 ++++++++++++++++++++----\n 1 file changed, 20 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 26d368bb9132..be3e38da95ab 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1013,8 +1013,9 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\t\tconst MediaEntity *csi2Entity = in.csi2_->entity();\n \t\t\treturn csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true);\n \t\t},\n-\t\t[](MaliC55CameraData::Memory &) {\n-\t\t\treturn 0;\n+\t\t[&](MaliC55CameraData::Memory &) {\n+\t\t\tconst MediaEntity *ivcEntity = ivcSd_->entity();\n+\t\t\treturn ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n \t\t},\n \t}, data->input_);\n \tif (ret)\n@@ -1041,8 +1042,23 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \n \t\t\treturn in.csi2_->getFormat(1, &subdevFormat);\n \t\t},\n-\t\t[](MaliC55CameraData::Memory &) {\n-\t\t\treturn 0;\n+\t\t[&](MaliC55CameraData::Memory &mem) {\n+\t\t\tV4L2DeviceFormat inputFormat;\n+\n+\t\t\tint r = mem.cru_->configure(&subdevFormat, &inputFormat);\n+\t\t\tif (r)\n+\t\t\t\treturn r;\n+\n+\t\t\t/* Propagate the CRU format to the IVC input. */\n+\t\t\tr = ivcSd_->setFormat(0, &subdevFormat);\n+\t\t\tif (r)\n+\t\t\t\treturn r;\n+\n+\t\t\tr = ivcSd_->getFormat(1, &subdevFormat);\n+\t\t\tif (r)\n+\t\t\t\treturn r;\n+\n+\t\t\treturn ivc_->setFormat(&inputFormat);\n \t\t},\n \t}, data->input_);\n \tif (ret)\n", "prefixes": [ "v6", "5/7" ] }