Patch Detail
Show a patch.
GET /api/1.1/patches/26310/?format=api
{ "id": 26310, "url": "https://patchwork.libcamera.org/api/1.1/patches/26310/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26310/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260323082000.1324115-8-barnabas.pocze@ideasonboard.com>", "date": "2026-03-23T08:20:00", "name": "[v2,7/7] meson: Guard softisp gpu acceleration with feature option: softisp-gpu", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "34dc160e13146ad825d0c879c662df5a24865b3e", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26310/mbox/", "series": [ { "id": 5835, "url": "https://patchwork.libcamera.org/api/1.1/series/5835/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5835", "date": "2026-03-23T08:19:53", "name": "meson: Add `softisp-gpu` option", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5835/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26310/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26310/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90782C32F9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Mar 2026 08:20:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3560162771;\n\tMon, 23 Mar 2026 09:20:15 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1B15762753\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2026 09:20:05 +0100 (CET)", "from pb-laptop.local (185.221.143.129.nat.pool.zt.hu\n\t[185.221.143.129])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C72C12441;\n\tMon, 23 Mar 2026 09:18:48 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g9Yo/4ze\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774253928;\n\tbh=WMTAH5iIIgsliP//GsQRG6lecJ69mye4o3hZkv3d/0k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g9Yo/4zeU9EYLTjIsjeN7BlUj6+e7HgJ/8q0PaJEw0stwwIOUwn49aD0ZwFbE4XOg\n\tnrKl1yj0XoZ7BAqCdOmd3VDs2sbpsKYEFf1MYjLLuD7lhIRDEanYwm1KYQcgtkov+L\n\tsu0p6iMuuaOrokZgYUKgOqmz4qtOGaDUx1mn8gcE=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 7/7] meson: Guard softisp gpu acceleration with feature\n\toption: softisp-gpu", "Date": "Mon, 23 Mar 2026 09:20:00 +0100", "Message-ID": "<20260323082000.1324115-8-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>", "References": "<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Previously it was not possible to disable gpu acceleration if every\ndependency was discovered by meson. Fix that by adding a new option.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\nchanges in v2:\n * rename option from `softisp-debayer-egl` to `softisp-gpu`\n\nv1: https://patchwork.libcamera.org/patch/26047/\n---\n meson_options.txt | 5 +++++\n src/libcamera/software_isp/meson.build | 8 +++++---\n 2 files changed, 10 insertions(+), 3 deletions(-)\n\n--\n2.53.0", "diff": "diff --git a/meson_options.txt b/meson_options.txt\nindex c27e377ad..af1c60cce 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -86,6 +86,11 @@ option('rpi-awb-nn',\n value : 'auto',\n description : 'Enable the Raspberry Pi Neural Network AWB algorithm')\n\n+option('softisp-gpu',\n+ type : 'feature',\n+ value : 'auto',\n+ description : 'Enable GPU accelerated processing in the software ISP')\n+\n option('test',\n type : 'boolean',\n value : false,\ndiff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\nindex cbcd3c1b3..7a2f704bf 100644\n--- a/src/libcamera/software_isp/meson.build\n+++ b/src/libcamera/software_isp/meson.build\n@@ -7,9 +7,11 @@ if not softisp_enabled\n subdir_done()\n endif\n\n-libegl = dependency('egl', required : false)\n-libglesv2 = dependency('glesv2', required : false)\n-mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n+libegl = dependency('egl', required : get_option('softisp-gpu'))\n+libglesv2 = dependency('glesv2', required : get_option('softisp-gpu'))\n+mesa_works = cc.check_header('EGL/egl.h',\n+ required : get_option('softisp-gpu'),\n+ dependencies : libegl)\n\n summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n\n", "prefixes": [ "v2", "7/7" ] }