Patch Detail
Show a patch.
GET /api/1.1/patches/26309/?format=api
{ "id": 26309, "url": "https://patchwork.libcamera.org/api/1.1/patches/26309/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26309/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260323082000.1324115-7-barnabas.pocze@ideasonboard.com>", "date": "2026-03-23T08:19:59", "name": "[v2,6/7] meson: Move egl related dependencies to `software_isp` subdir", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a75c05d87b57ccb284869301114aeb0a7431b03a", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26309/mbox/", "series": [ { "id": 5835, "url": "https://patchwork.libcamera.org/api/1.1/series/5835/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5835", "date": "2026-03-23T08:19:53", "name": "meson: Add `softisp-gpu` option", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5835/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26309/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26309/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C0FEC32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Mar 2026 08:20:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0FB562760;\n\tMon, 23 Mar 2026 09:20:13 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CD84962743\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Mar 2026 09:20:04 +0100 (CET)", "from pb-laptop.local (185.221.143.129.nat.pool.zt.hu\n\t[185.221.143.129])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A56419DF;\n\tMon, 23 Mar 2026 09:18:48 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RD6acg2k\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1774253928;\n\tbh=oRrMHbJUfe3QXgyJbv/+omRPsmaUVw11cD8KWldNOvQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RD6acg2k0SZU12c3An9LTthVmiPl9e+SiGevd7RrwewRTK2gCgo/u4+mD6/Kd7pRA\n\tEDFc088NyMwKZMPIq65ZhfEsY5/rUKPxCaTlfXJxEOkCqcb3js+wjdYVVNcnbQyuPp\n\t6xVAVwbGjYT5vm5g9uJ9jgP1m8k2O2UQRPX9r3Zc=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 6/7] meson: Move egl related dependencies to\n\t`software_isp` subdir", "Date": "Mon, 23 Mar 2026 09:19:59 +0100", "Message-ID": "<20260323082000.1324115-7-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>", "References": "<20260323082000.1324115-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This way the dependencies are only added if they are actually used.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 6 ------\n src/libcamera/software_isp/meson.build | 11 ++++++++++-\n 2 files changed, 10 insertions(+), 7 deletions(-)\n\n--\n2.53.0", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 72b7bf02d..575408b2c 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -70,10 +70,6 @@ libcamera_deps = []\n libatomic = cc.find_library('atomic', required : false)\n libthreads = dependency('threads')\n\n-libegl = dependency('egl', required : false)\n-libglesv2 = dependency('glesv2', required : false)\n-mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n-\n subdir('base')\n subdir('converter')\n subdir('ipa')\n@@ -182,8 +178,6 @@ libcamera_deps += [\n libcamera_base_private,\n libcrypto,\n libdl,\n- libegl,\n- libglesv2,\n liblttng,\n libudev,\n libyaml,\ndiff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\nindex 118d3f92f..cbcd3c1b3 100644\n--- a/src/libcamera/software_isp/meson.build\n+++ b/src/libcamera/software_isp/meson.build\n@@ -2,12 +2,17 @@\n\n softisp_enabled = pipelines.contains('simple')\n summary({'SoftISP support' : softisp_enabled}, section : 'Configuration')\n-summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n\n if not softisp_enabled\n subdir_done()\n endif\n\n+libegl = dependency('egl', required : false)\n+libglesv2 = dependency('glesv2', required : false)\n+mesa_works = cc.check_header('EGL/egl.h', required : false, dependencies : libegl)\n+\n+summary({'SoftISP GPU acceleration' : mesa_works}, section : 'Configuration')\n+\n libcamera_internal_sources += files([\n 'benchmark.cpp',\n 'debayer.cpp',\n@@ -22,4 +27,8 @@ if mesa_works\n '../egl.cpp',\n 'debayer_egl.cpp',\n ])\n+ libcamera_deps += [\n+ libegl,\n+ libglesv2,\n+ ]\n endif\n", "prefixes": [ "v2", "6/7" ] }