Patch Detail
Show a patch.
GET /api/1.1/patches/26285/?format=api
{ "id": 26285, "url": "https://patchwork.libcamera.org/api/1.1/patches/26285/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26285/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260313-mali-cru-v4-2-c0d9bc8cd8fa@ideasonboard.com>", "date": "2026-03-13T11:33:43", "name": "[v4,2/7] libcamera: utils: Add overloaded visitor helpers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c295290bf38cb92c0aeecc9f3981401289378bc9", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26285/mbox/", "series": [ { "id": 5829, "url": "https://patchwork.libcamera.org/api/1.1/series/5829/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5829", "date": "2026-03-13T11:33:41", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5829/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26285/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26285/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 96ABBBE086\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Mar 2026 11:34:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B3CC62657;\n\tFri, 13 Mar 2026 12:34:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37D7A6263D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Mar 2026 12:34:23 +0100 (CET)", "from [192.168.224.131] (unknown [37.159.92.229])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 844FA103D;\n\tFri, 13 Mar 2026 12:33:12 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RCMyNpcb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1773401594;\n\tbh=zprjRPHJf6qrBYQuTrxKQDqXGcDi5fNentWk7weQpOI=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=RCMyNpcbj45DanT51KNshYzuEN7YFT/U6CXcEBoKw8Ai9paG3OcLx5bn+CSA/7vRd\n\trSg4PRNKzGonz1FZoNAGCTMl+bzZCwhOwZrXzWwYmT3vIVaTNzG//zjLjPb3Gej4AF\n\t++2Zhgu+XWHCihFXe7VL9/ftOqNGCjXCXXZDCrTM=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 13 Mar 2026 12:33:43 +0100", "Subject": "[PATCH v4 2/7] libcamera: utils: Add overloaded visitor helpers", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260313-mali-cru-v4-2-c0d9bc8cd8fa@ideasonboard.com>", "References": "<20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com>", "In-Reply-To": "<20260313-mali-cru-v4-0-c0d9bc8cd8fa@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=4117;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=zprjRPHJf6qrBYQuTrxKQDqXGcDi5fNentWk7weQpOI=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBps/Y06wo47K0QwTTk2FCH3z+v5bSgXx/ukxo3P\n\tRC64Bd9iCyJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCabP2NAAKCRByNAaPFqFW\n\tPLvqEADHmdaMo+P2tCCqeM1fK7GDIcQhWzLFbxD1wUPl3bhGofXGgXqwJB1gTv+wd6SZup3Ovf3\n\t8quBiQiE3PefeOHPAlD2+fy9xtDIUFhmav4UU6vuLSI7slMwlK5Pyj3f0kvWv7b1e5irQ3IGsyB\n\t+lkefw47H7HPESviBBcTvMyiuWCYhRgZYgLoi+SDxvS9oKCjvFV53WIAc5fc90yRnU4/NFurC+W\n\tUrJkUWmAmRc25qF8hEnoGHUrZLE00+vsJwNWoVEfA+/ZEZsztt6VatD1uThD6ers3nfrhlAvF8H\n\tcMYeJTftO5yHdUKfytBmW9W9MRk9XMa2FARj6J3vB9icxiWloZg36Iy7obe6wiNHcEMX6JFt5DA\n\thoTnBP9sqy/6c7QfUWg8b0LW6R32hSp8ovFHd5k+RzzCgz+RVShLTGzOo5KmJ2yg5eV+a57ev5q\n\tNa17jz2EIIs1zjN91JKvQ6p8MoqN0ZfKbiMlqUNUSJ6LGGyhacBDpLv/hms9ZeqresVyBa6zdfD\n\tD3R999C1G8OICXd/mABL1SpOQtpB54PbqFBi5KbcrGL+T4m07TECINtuXw6CWjckNj2bhlPh9xY\n\tXzROWCH6xzDeLQPcBXDGuthLJuB/EF9ARYQmyKgnZ/6zLRn6yzkyifbFXJ86SUMIJoJE/8ielYN\n\tjDKSPGmp0/s9hqw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "std::visit() allows quite elegant type-matching implementation of the\nvisitor pattern.\n\nThe overaloded type helpers allow to define a hierarchy of overloaded\noperator() implementations which can be used by std::visit().\n\nCurrently only the Virtual pipeline handler uses this type-matching\nimplementation of std::visit. To prepare to add another user in the Mali\nC55 pipeline handler move the 'overloaded' helper types to\nlibcamera::utils for easier re-use.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n include/libcamera/base/utils.h | 7 ++++++\n src/libcamera/base/utils.cpp | 35 ++++++++++++++++++++++++++++++\n src/libcamera/pipeline/virtual/virtual.cpp | 10 ++-------\n 3 files changed, 44 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/base/utils.h b/include/libcamera/base/utils.h\nindex 7083b7ce9ce9..62c7f89c25a1 100644\n--- a/include/libcamera/base/utils.h\n+++ b/include/libcamera/base/utils.h\n@@ -37,6 +37,13 @@ namespace libcamera {\n \n namespace utils {\n \n+template<class... Ts>\n+struct overloaded : Ts... {\n+\tusing Ts::operator()...;\n+};\n+template<class... Ts>\n+overloaded(Ts...) -> overloaded<Ts...>;\n+\n const char *basename(const char *path);\n \n char *secure_getenv(const char *name);\ndiff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\nindex 42a516097be2..a18ca82e8d07 100644\n--- a/src/libcamera/base/utils.cpp\n+++ b/src/libcamera/base/utils.cpp\n@@ -23,6 +23,41 @@ namespace libcamera {\n \n namespace utils {\n \n+/**\n+ * \\struct overloaded\n+ * \\brief Helper type for type-matching std::visit implementations\n+ * \\tparam Ts... Template arguments pack of visitors\n+ *\n+ * Expand the template argument pack \\a Ts... to provide overloaded\n+ * implementations of \\a operator().\n+ */\n+\n+/**\n+ * \\var <class... Ts> overloaded(Ts...) -> overloaded<Ts...>\n+ * \\brief Overloaded visitor class for type-matching std::visit implementations\n+ * \\tparam Ts... Template arguments pack of visitor functions\n+ *\n+ * std::visit allows quite elegant type-matching implementation of the visitor\n+ * pattern. An example is provided by the STL documentation in the form of:\n+ *\n+ * \\code{.cpp}\n+ * template<class... Ts> struct overloaded : Ts... { using Ts::operator()...; };\n+ * template<class... Ts> overloaded(Ts...) -> overloaded<Ts...>;\n+ *\n+ * using var_t = std::variant<int, long, double, std::string>;\n+ * std::vector<var_t> vec = {10, 15l, 1.5, \"hello\"};\n+ *\n+ * for (auto& v: vec) {\n+ * \tstd::visit(overloaded {\n+ * \t\t[](auto arg) { std::cout << arg << ' '; },\n+ * \t\t[](double arg) { std::cout << std::fixed << arg << ' '; },\n+ * \t\t[](const std::string& arg) { std::cout << std::quoted(arg) << ' '; },\n+ * \t}, v);\n+ * \\endcode\n+ *\n+ * Use this helper to implement type-matching visitors using std::visit().\n+ */\n+\n /**\n * \\brief Strip the directory prefix from the path\n * \\param[in] path The path to process\ndiff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp\nindex efd800ebe3d6..e8ef7e524ccf 100644\n--- a/src/libcamera/pipeline/virtual/virtual.cpp\n+++ b/src/libcamera/pipeline/virtual/virtual.cpp\n@@ -23,6 +23,7 @@\n \n #include <libcamera/base/flags.h>\n #include <libcamera/base/log.h>\n+#include <libcamera/base/utils.h>\n \n #include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n@@ -57,13 +58,6 @@ uint64_t currentTimestamp()\n \n } /* namespace */\n \n-template<class... Ts>\n-struct overloaded : Ts... {\n-\tusing Ts::operator()...;\n-};\n-template<class... Ts>\n-overloaded(Ts...) -> overloaded<Ts...>;\n-\n class VirtualCameraConfiguration : public CameraConfiguration\n {\n public:\n@@ -428,7 +422,7 @@ bool PipelineHandlerVirtual::initFrameGenerator(Camera *camera)\n {\n \tauto data = cameraData(camera);\n \tauto &frame = data->config_.frame;\n-\tstd::visit(overloaded{\n+\tstd::visit(utils::overloaded{\n \t\t\t [&](TestPattern &testPattern) {\n \t\t\t\t for (auto &streamConfig : data->streamConfigs_) {\n \t\t\t\t\t if (testPattern == TestPattern::DiagonalLines)\n", "prefixes": [ "v4", "2/7" ] }