Patch Detail
Show a patch.
GET /api/1.1/patches/26280/?format=api
{ "id": 26280, "url": "https://patchwork.libcamera.org/api/1.1/patches/26280/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26280/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260312231616.3590215-2-faizel.kb@gmail.com>", "date": "2026-03-12T23:16:14", "name": "[RESEND,v3,1/3] media: vimc: sensor: Move vimc_sensor_device to common header", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9ac9755488d2c4de361ef09ec457c18b0496903a", "submitter": { "id": 258, "url": "https://patchwork.libcamera.org/api/1.1/people/258/?format=api", "name": "Faizel K B", "email": "faizel.kb@gmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26280/mbox/", "series": [ { "id": 5828, "url": "https://patchwork.libcamera.org/api/1.1/series/5828/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5828", "date": "2026-03-12T23:16:13", "name": "media: vimc: Add timing controls for fps config", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5828/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26280/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26280/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51676BDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Mar 2026 23:17:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 011026265F;\n\tFri, 13 Mar 2026 00:17:33 +0100 (CET)", "from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com\n\t[IPv6:2607:f8b0:4864:20::1031])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35A356261B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Mar 2026 00:17:32 +0100 (CET)", "by mail-pj1-x1031.google.com with SMTP id\n\t98e67ed59e1d1-35a1826cb69so103325a91.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Mar 2026 16:17:32 -0700 (PDT)", "from FAIZEL-KB.. ([2001:569:5b64:e100:3685:315:53bf:61fc])\n\tby smtp.googlemail.com with ESMTPSA id\n\td9443c01a7336-2aece81cde8sm619395ad.70.2026.03.12.16.17.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 12 Mar 2026 16:17:30 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Z95v1MAL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1773357451; x=1773962251;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Crj5/i72nEqbooeaF7oZTjBVdiKVVLm5IQ4dcnP9qgM=;\n\tb=Z95v1MALJN1mh/QrovurbdWDv6q7sCJl0BANG8KjHF9BAij3dfftDapD8NZ7bZeH3f\n\tZ5Tv5s2XDbzSd/WHDy/qx3bY1Fy+HvLsAalekh4uDIlTfkDmebhs6xrP5cHO3MS+nXw1\n\tMM5S1dpOvd1kZCL1DDGf3t8DZ7A36DO5t7WLkBqG86Ykse92Ik5LDS0UOhQpuzG3gOkx\n\tpW9HYpkwkV2NIlvBy5z24rsC2gNIkinMZrRbMiSnxtOU7nQLY12nQECGaUpeiMjzi9L3\n\tHNuUQRB6I2mIkix7d2RlDO+biS3QR434B7XiUn6oKy9aYD0EW5Lhx7ZsjDyR/GLlkyUm\n\tXd4A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20251104; t=1773357451; x=1773962251;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Crj5/i72nEqbooeaF7oZTjBVdiKVVLm5IQ4dcnP9qgM=;\n\tb=rIa739Zd/Go/vYr8667GX5C7eE0uSEJBuaqCWRKTBlNVlRYhMsLHk9siKQKL1Noeey\n\t1UmofQ9w38+xmYIBPRhfaHOG5AxFQeknF3RdwspkP/yKRBOVBDZapiErCnlZRO5378CU\n\t0nmBtJLov9iZjDc8kP4Qa8HHgX33De2VQJ2QQK2PTsc34UHAXrFAp6niqWCueogVPXGw\n\tbMhOngQI6P5iZgb40ghL2Si2kCZBkUaMeABPRKQewdVemaHS/wBms1b+mqmin1qAI38I\n\t/V5ZQEnqydPaRsCD6Uz8RtaCP+bbqwVScEH0lQSzpUOzwCFTt/P5NtMFRNxsYTKnAkd/\n\tvMJQ==", "X-Forwarded-Encrypted": "i=1;\n\tAJvYcCUqihqB5oaiT+x1n6YWtFrwHBtFnP8DLTkoHV0mUVrHRMwYKK9E8ho42kbqVycyaHqDKq53c4kUhTEYEQi3phk=@lists.libcamera.org", "X-Gm-Message-State": "AOJu0YyGuuXHq00uorB9gawCLzhePHeVkErNxVyD0Pq8uRrNcfyqOr26\n\t1dbCOsEY/3qsaGREMWZEjeG+vGdBpI9hMZSb+x8L/vFUM/Vp/21pEtwR", "X-Gm-Gg": "ATEYQzx61vj5M8S1tiTreW6U38ECvEiWV4qKe+BjMP3tnNs/k6qrKlKqFGxWSGsAE1d\n\t3SYB00vfXk6xzhV5L0inCzauVN2VqfRa6/+sLO+2JhUHqfpEyq7rpcac+w2Q5Ufj91MA4ThQkOb\n\tsC08NWqXKX3lIH7ovgwFA1X9SJOwQT7OALmitAIGj4XYdNkm8Op9qks0PE2hlciaaUFRVA7SSpx\n\tfEakNlNz8pHM/V7fud5W9FmduDWacDUtW+gwDXouaxKVhbxjZIkqOXn370fY+pnrEh5omp8dGai\n\tT8IAJYCLpDBavU7OHpp0Qf8OVkMgARxP3lReLVQTTpX2YBphewW60ipio4Ag+hbPmwKt6o/KL1m\n\t2tlQELnYekk9iISG5A+4A7w/2M+EkKyVoy3AeaJE753xT9ewdvGtTGjMK0fpxxP68Zt7zRcqe6/\n\tmpagxtqC7+TYY4suhQeFo3BTfdOvE+rdtbtipbiUTzK0VNC8pUO3eb8rw=", "X-Received": "by 2002:a17:902:f546:b0:2ae:4f95:df56 with SMTP id\n\td9443c01a7336-2aecaa3eb84mr7530795ad.3.1773357450767; \n\tThu, 12 Mar 2026 16:17:30 -0700 (PDT)", "From": "Faizel K B <faizel.kb@gmail.com>", "To": "Shuah Khan <skhan@linuxfoundation.org>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlinux-media@vger.kernel.org", "Cc": "Mauro Carvalho Chehab <mchehab@kernel.org>,\n\tlibcamera-devel@lists.libcamera.org, Faizel K B <faizel.kb@gmail.com>", "Subject": "[PATCH RESEND v3 1/3] media: vimc: sensor: Move vimc_sensor_device\n\tto common header", "Date": "Thu, 12 Mar 2026 16:16:14 -0700", "Message-ID": "<20260312231616.3590215-2-faizel.kb@gmail.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260312231616.3590215-1-faizel.kb@gmail.com>", "References": "<20260312231616.3590215-1-faizel.kb@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the vimc_sensor_device structure from vimc-sensor.c to\nvimc-common.h to make it accessible to the vimc-streamer component.\n\nSigned-off-by: Faizel K B <faizel.kb@gmail.com>\n---\n drivers/media/test-drivers/vimc/vimc-common.h | 28 +++++++++++++++++++\n drivers/media/test-drivers/vimc/vimc-sensor.c | 26 -----------------\n 2 files changed, 28 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/media/test-drivers/vimc/vimc-common.h b/drivers/media/test-drivers/vimc/vimc-common.h\nindex 7a45a2117748..35789add6b4a 100644\n--- a/drivers/media/test-drivers/vimc/vimc-common.h\n+++ b/drivers/media/test-drivers/vimc/vimc-common.h\n@@ -12,6 +12,8 @@\n #include <linux/slab.h>\n #include <media/media-device.h>\n #include <media/v4l2-device.h>\n+#include <media/tpg/v4l2-tpg.h>\n+#include <media/v4l2-ctrls.h>\n \n #define VIMC_PDEV_NAME \"vimc\"\n \n@@ -159,6 +161,32 @@ struct vimc_ent_config {\n \tconst struct vimc_ent_type *type;\n };\n \n+enum vimc_sensor_osd_mode {\n+\tVIMC_SENSOR_OSD_SHOW_ALL = 0,\n+\tVIMC_SENSOR_OSD_SHOW_COUNTERS = 1,\n+\tVIMC_SENSOR_OSD_SHOW_NONE = 2\n+};\n+\n+struct vimc_sensor_device {\n+\tstruct vimc_ent_device ved;\n+\tstruct v4l2_subdev sd;\n+\tstruct tpg_data tpg;\n+\tstruct v4l2_ctrl_handler hdl;\n+\tstruct media_pad pad;\n+\n+\tu8 *frame;\n+\n+\t/*\n+\t * Virtual \"hardware\" configuration, filled when the stream starts or\n+\t * when controls are set.\n+\t */\n+\tstruct {\n+\t\tstruct v4l2_area size;\n+\t\tenum vimc_sensor_osd_mode osd_value;\n+\t\tu64 start_stream_ts;\n+\t} hw;\n+};\n+\n /**\n * vimc_is_source - returns true if the entity has only source pads\n *\ndiff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c\nindex 69e714d4f228..4c64cdab8cda 100644\n--- a/drivers/media/test-drivers/vimc/vimc-sensor.c\n+++ b/drivers/media/test-drivers/vimc/vimc-sensor.c\n@@ -14,32 +14,6 @@\n \n #include \"vimc-common.h\"\n \n-enum vimc_sensor_osd_mode {\n-\tVIMC_SENSOR_OSD_SHOW_ALL = 0,\n-\tVIMC_SENSOR_OSD_SHOW_COUNTERS = 1,\n-\tVIMC_SENSOR_OSD_SHOW_NONE = 2\n-};\n-\n-struct vimc_sensor_device {\n-\tstruct vimc_ent_device ved;\n-\tstruct v4l2_subdev sd;\n-\tstruct tpg_data tpg;\n-\tstruct v4l2_ctrl_handler hdl;\n-\tstruct media_pad pad;\n-\n-\tu8 *frame;\n-\n-\t/*\n-\t * Virtual \"hardware\" configuration, filled when the stream starts or\n-\t * when controls are set.\n-\t */\n-\tstruct {\n-\t\tstruct v4l2_area size;\n-\t\tenum vimc_sensor_osd_mode osd_value;\n-\t\tu64 start_stream_ts;\n-\t} hw;\n-};\n-\n static const struct v4l2_mbus_framefmt fmt_default = {\n \t.width = 640,\n \t.height = 480,\n", "prefixes": [ "RESEND", "v3", "1/3" ] }