Patch Detail
Show a patch.
GET /api/1.1/patches/26251/?format=api
{ "id": 26251, "url": "https://patchwork.libcamera.org/api/1.1/patches/26251/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26251/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260304075052.11599-5-johannes.goede@oss.qualcomm.com>", "date": "2026-03-04T07:50:51", "name": "[v5,4/5] software_isp: Log input config from configure()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "93c9a5453fc1d9d8048bd86d2d99f47fb5d97f10", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/1.1/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26251/mbox/", "series": [ { "id": 5817, "url": "https://patchwork.libcamera.org/api/1.1/series/5817/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5817", "date": "2026-03-04T07:50:47", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5817/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26251/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26251/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83C9CC32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Mar 2026 07:51:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 318DD623A5;\n\tWed, 4 Mar 2026 08:51:05 +0100 (CET)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65B8562391\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Mar 2026 08:51:02 +0100 (CET)", "from pps.filterd (m0279862.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t6245SXee3110522 for <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Mar 2026 07:51:00 GMT", "from mail-qk1-f198.google.com (mail-qk1-f198.google.com\n\t[209.85.222.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp5h2a7t7-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 04 Mar 2026 07:51:00 +0000 (GMT)", "by mail-qk1-f198.google.com with SMTP id\n\taf79cd13be357-8c711251ac5so4135334785a.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Mar 2026 23:51:00 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b935ac73a5dsm693263366b.25.2026.03.03.23.50.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 03 Mar 2026 23:50:58 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"YOZFi/Bo\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"Zw4UHxQe\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=8Gvil8HmgAm\n\tctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=YOZFi/Bofk/Ull9bZzx74gmaaeh\n\tqKF9HjoFTZMoeIE2RiuQSVaW67FPjD7X/eXF4bDtasCvnYc0zVmUdyoMR+IZYPKh\n\tIA2I9eRLj2d4+u5ahAfjs5RS6czTWShL98nl2JMml0nhLTmxHVaIshepAbFbyuWt\n\tK0piwc9I0GG0gekK7YkPUvxG82Eb8NpEvJB8b0fu4/G86yL/IR2xdI7/C6EFEC6F\n\tdZTnJG7XgMpNC0iGrhggplF9mifP/JhGKCRLs6GCoxKStf+fJYcMgF1KoOFJ/W6k\n\ty+PkgLVArOKsxKR82UmUg/JyOhawYXUzAlTkDENrxhCnAD2vOU5Cy+YPwMg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1772610659; x=1773215459;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=;\n\tb=Zw4UHxQeST4YWlpbjgZJtNQh+9h+Jvryo6h+U/dtEnyk/7z36o2DhTtM9cYqHpZ7Cc\n\tzJ8lh7qOpvS221yQ4vIb7Fv4FOhjMx6ay+rNaZH4Ahtq9uuy3Ywk8n+kRoUu3d4dtOFI\n\tj6VtRaw1/Ih6LHP+CEGS3ApAJkmu2bnmbH/VThroXypWWG6kq9fy8HRRYwDngRvvAcwe\n\tyEuonx/zoH3n7BLIA7H6NveB525OMLhF73rWNRn9pNz4kvVCtNpbapwr8DgWa3b4mFgz\n\ttSIcO2Xi0Zt2hlSXDdj3yrnzw22J4zkDTkqGVf2GStJ59/K+GHaOnlZ2YVvC9/3zE7xz\n\tDRCA==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1772610659; x=1773215459;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=;\n\tb=j2BFEqaCeLYtYE6fEUD5wXc31znIRiSwNDJtLmr/8+Hoa+YyeFGxsdo7S1dHAKgoD6\n\tFlEYnk1coDp0ooqwIAlJ6/aypHLqLZ612qRwpxArSmFN/E/UIC/KBOG8m8t1bPoTNZMj\n\tDUIZ+c0LmQl73lmprxQ2tcbcj69E8TwkgGgakYJe21FT7ZkN4ra7Bi8x4cyRr4yU4iZ7\n\t4suOFbCTgp9zA7Qp6d+V1uvszuiMASM5qNgHG38r0pLiN0WrsAgkSAtlJgte0F9o04jd\n\tGA81X/wzXMEOpS7JvF0mEOTsAdHH8E8GDnfH4KH50UKD8UVdqcCnNMIwdtlZ25Yfzpg1\n\tw3ag==", "X-Gm-Message-State": "AOJu0YzZpSl7Olo8Cjwedwb4Xuy9SWk5qfLbLg7GEsnQaem4yv8FdYGR\n\tyoOEihs46nCNgJlKb34f1lhn4qOaAx6RBB70Ti3LPLdJxvcpoKlKasDlGHPgEK+hbQ/8s30Fbpa\n\tLcfsfGZFZ28jczI5yG3SfSPH4ES2bMKqkhYwQ9QWOTTuTjHaOT5mqJJaTu+jBJ744+hzwfRdNUR\n\twv0UywBljp", "X-Gm-Gg": "ATEYQzymA58Ga7ct0xpSnfIcgY6ouA5ve5PD8FU3KGujsFdV33Ab7DGhIMg7RdgK/uy\n\tGchdweie5T6rSyvARMXHwijFj43GG8SvTjJRD/93GpscLJXFdSWWueMMunklDySEcLFTo0kcCw1\n\tOvxHniRyKWxGxCD40p4kP8ifgeg9UFEFlnOTWN+/5b/1hpWS8n1UnL/pWOpLCsuzb+DOaF0/BO6\n\tPS/vTT749AQ5grM0sk761aseN2icsWIipAJ2RTLUPTJPaqschjCzYhQH4f/tksQyf9U1tDiTVnz\n\tTjAI9ztQd0NflQSOmNpYRGPw3+ohx2mO9Jeb6j08S8DJSfgfVYukRDBNxWAECmkDgxWAvw0Jta+\n\tLp8l442PSQQwYVAUC0mzf9gEk8bZGSqohnYefqKwPi1D5zRRE4OyUyUmN8TtQapb8YB7Zd5v7iu\n\tP4DK1m/iqmlXUBYT+tUf6BL7Kb7/+LKdexOK4N", "X-Received": [ "by 2002:a05:620a:4096:b0:8b2:74e5:b36 with SMTP id\n\taf79cd13be357-8cd5afa5ad6mr133601985a.68.1772610659329; \n\tTue, 03 Mar 2026 23:50:59 -0800 (PST)", "by 2002:a05:620a:4096:b0:8b2:74e5:b36 with SMTP id\n\taf79cd13be357-8cd5afa5ad6mr133600485a.68.1772610658856; \n\tTue, 03 Mar 2026 23:50:58 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v5 4/5] software_isp: Log input config from configure()", "Date": "Wed, 4 Mar 2026 08:50:51 +0100", "Message-ID": "<20260304075052.11599-5-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260304075052.11599-1-johannes.goede@oss.qualcomm.com>", "References": "<20260304075052.11599-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=JqL8bc4C c=1 sm=1 tr=0 ts=69a7e464 cx=c_pps\n\ta=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=_K5XuSEh1TEqbUxoQ0s3:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8\n\ta=mKg8M22OkPar6P-70WAA:9 a=NFOGd7dJGGMPyQGDc5-O:22", "X-Proofpoint-ORIG-GUID": "G4PKVQMS25KC8Fy7LK0fW8Ss69w5gQ2f", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzA0MDA2MiBTYWx0ZWRfX1RmgWT/+if/N\n\tHPn0tkHuXMmqlDnhQ8CUqQkOt/QzoYAUJzy/QEQYAjH8m5ivyWnbQ91iYFy1JC4N/iYnFDvG8MI\n\t7GvJAPebmwxDyFfE/sTU4YJ6UrEAWxqo287LS167dK+u5czpAKzC15a7NKx5NVVLDXHk3BLSYad\n\t8YvvlRiW9kZLaZvjlWTWp0XY6mFVCwOdTWodkfNRfqCkfQTL/c/hqgBBmAKlb4XVnrR0f3cnEym\n\tocWm9tzLmCohkKOoTPHTzsWraYeqEYzpWhmrKsa0iWXlfarEbMKmw7sZZswM88nLIew/DOmonaL\n\t164Stu657R4Cgzol5+owED0LrthmnuE5AGnVXUSewUpVm56NVKO1wgkiqPuboVbl0oCqYmatU8J\n\tC8NZw0PD718M19POdI3xSPeWmImYTw76V+38eqKU5kgT6s54FqWFaAWiuFFCx08PXORLidRQ9uI\n\t7ceMJPLiZmJnyqOGTtQ==", "X-Proofpoint-GUID": "G4PKVQMS25KC8Fy7LK0fW8Ss69w5gQ2f", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-03-04_02,2026-03-03_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\timpostorscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0\n\tclxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0\n\tbulkscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound\n\tadjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2603040062", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As shown by commit 94d32fdc55a3 (\"pipeline: simple: Consider output sizes\nwhen choosing pipe config\"), the extra pixel columns CPU debayering\nrequires on the input side makes resolution selection non trivial.\n\nAdd logging of the selected input config on a successful configure() so\nthat the logs clearly show which sensor mode has been selected.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\nChanges in v2:\n- Move from DebayerCpu::configure() to SoftwareIsp::configure() so that\n the input fmt also gets logged when using the DebayerEgl class\n---\n src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 562cdba22..4cf5639d9 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -21,6 +21,7 @@\n #include <libcamera/formats.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n@@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tLOG(SoftwareIsp, Info)\n+\t\t<< \"Input \" << inputCfg.size\n+\t\t<< \"-\" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat)\n+\t\t<< \" stride \" << inputCfg.stride;\n+\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "v5", "4/5" ] }