Patch Detail
Show a patch.
GET /api/1.1/patches/26247/?format=api
{ "id": 26247, "url": "https://patchwork.libcamera.org/api/1.1/patches/26247/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26247/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260303111741.17417-5-johannes.goede@oss.qualcomm.com>", "date": "2026-03-03T11:17:41", "name": "[v4,4/4] software_isp: Log input config from configure()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "93c9a5453fc1d9d8048bd86d2d99f47fb5d97f10", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/1.1/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26247/mbox/", "series": [ { "id": 5816, "url": "https://patchwork.libcamera.org/api/1.1/series/5816/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5816", "date": "2026-03-03T11:17:37", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5816/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26247/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26247/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59519C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Mar 2026 11:17:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C6B26239C;\n\tTue, 3 Mar 2026 12:17:56 +0100 (CET)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F5216238E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Mar 2026 12:17:52 +0100 (CET)", "from pps.filterd (m0279862.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t6239n5J4582371 for <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Mar 2026 11:17:51 GMT", "from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n\t[209.85.160.199])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnh6uaqd3-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Mar 2026 11:17:51 +0000 (GMT)", "by mail-qt1-f199.google.com with SMTP id\n\td75a77b69052e-5033c483b74so54133211cf.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Mar 2026 03:17:51 -0800 (PST)", "from t14s\n\t(2001-1c00-0c32-7800-beb3-9058-f5fe-3f2e.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:beb3:9058:f5fe:3f2e])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-66003479178sm2958144a12.9.2026.03.03.03.17.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 03 Mar 2026 03:17:49 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"MPfQBuog\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"BZEq/wwx\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=8Gvil8HmgAm\n\tctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=; b=MPfQBuogKnHaHWjex2Pq8gDiH8q\n\ttIzTvJ5q6EsyHyWb+QV9JJsdBgudUrz/q5IFo+SFayrw5JVOtEUXJZCDzuw5jKo0\n\tML7AKAn8SA//GMo3eAzHUFDIjY4dmim4X6SJC/RkQYBuxmgYcA9E/ua1VSbpG/hf\n\tlVJ9/xE6BAq0altuQlyqnSmZgL4Z3X0/soxcDp3fKNDN6ZwYzYdTq2Vdl5e6ztBo\n\tG796jQYUMDML8rNui1YH4CPsQiJ82ANZ9D85F6cNXEGtoIfqzQglZcXhBmpz/Dtw\n\tw6nFj7O8fs4SWep/e/DEDrcxOJfm2wli5wdNR8sGg0hsQA04JRNshhYjsXQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1772536670; x=1773141470;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=;\n\tb=BZEq/wwxatmlrB481uf5huSmkKJFPGDR5GNASU7zQxCBhyucnO5A2115NSs4dyBb7v\n\tUz7J+WcjmO+xnQMHzPYThe/l7irSUfGkiHibsxg1vsZ3BAAKS0TM2rbdfdr3MpRs2olv\n\tW96gUp6tlHbmkBTT/CUjbdY6x52f5RGdAeNiyvh/IvYc0kTo+BwXZQKyuhmvau6R5d8L\n\tnZ82QcH5dVYwL98qC2UwIx+KTz9RLxV5fcDStxzhbnxw7NONhKr+JGL0fXat4WjngzZQ\n\tAHtlSzA35iBeh1RyD1RmWtiX8ME9LXBq++RAdVjgXuw0fXsj5EaHJj2LNHEMOXG1rnej\n\tzEuw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1772536670; x=1773141470;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=8Gvil8HmgAmctZLXvrxDYw8ceQF1zFMUNkBVOjwGEfg=;\n\tb=fC90qVVtHVf80gL5qKXzIbLyRRkKl6iqoduZ0PorEvkLH+AqJcBLq7Czwg5LAw/t1A\n\t27emaNCWJxpoqA4OJqPYtpdZCLOkFEsFkZYAqeaacqsyIIipnQsuRtdnimn34Is5hTpN\n\tt7kRu5j0nw8yW784rIx45MaGCJ+JWGOn9mq0TSLJmNwvIZKkefovAHl/+vDCFPJNJYvV\n\tnjViqeriaNApk5QQ2NL4lDZDyONujElDGL4DJFifvHrXwuVLBk95Ji1LA0+Ib39V0aij\n\t4rZwSRRSg4lrHXbvDoTAor6OEwYQDLoppDIq/bJ/jl2VHVFjeAVcA/Uw76L65vWNjprx\n\tg4Ww==", "X-Gm-Message-State": "AOJu0YwG94wSvbI5X26MXhhKivYqYxrTQJOnf/tnvFusk+orvnHUN7tm\n\tCh1tnn2/OHCvcMe6fn+sGurs/qdLGzQt7OVw0tGs6twg4/UWjdLTgqSChuyw3k1dVZrj+SgpdMN\n\t7vtN66wF2KeGqbAbs6mPbI7yjuTdxN9dGl3B3sL/zsQOdvcrngCCWdXJ6fjP0TvO65TiNaztbOw\n\t5R8tO698n3", "X-Gm-Gg": "ATEYQzz1uzgzgYrFnm8dyET6AJqQ+BaU8Vkcg+ZnCHkcTHOQTqupE/y2XrMTVDD1ynw\n\tEjOAuryi6QSvxrFNnLnSYhHK/vHUYCenQiHql3GJEofbXwjwE8punrHly7VnhXC1YrCcoEx1W0G\n\tvcHN18h1J+8+e5iiopQM34JNVRJEjuet2rWlfPAJAmCGnwaw3poYbhQn3QG0sRA4IhdnThjFvzc\n\thLY/FgqfzjIzYLbeFHaWhMI9XG8nyzjRlPZKC8nulaFrq+wpK0UrcdzP8ewArrgKQ62NqgjVJl/\n\t0fpMom/efqLkZrbWeeIrjBG2s1j2gWC7Gs/XqbkvV4x7AJQ190plSXjHNFWCMdawxm3pZyM9tnI\n\tnheBgU2RzR7YOxrIk+afo6cCxFz4sN+yG1hB8RPapYkIdUXh6jezHQT5MJTroZeL11FKecaOmil\n\tnvIvnUU/eLIflkuV5SXqxFwHkjC94BuHiAJA==", "X-Received": [ "by 2002:a05:620a:f0e:b0:8b2:e666:70d with SMTP id\n\taf79cd13be357-8cbc8e03a3emr1976829485a.43.1772536670070; \n\tTue, 03 Mar 2026 03:17:50 -0800 (PST)", "by 2002:a05:620a:f0e:b0:8b2:e666:70d with SMTP id\n\taf79cd13be357-8cbc8e03a3emr1976826585a.43.1772536669622; \n\tTue, 03 Mar 2026 03:17:49 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tHans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v4 4/4] software_isp: Log input config from configure()", "Date": "Tue, 3 Mar 2026 12:17:41 +0100", "Message-ID": "<20260303111741.17417-5-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260303111741.17417-1-johannes.goede@oss.qualcomm.com>", "References": "<20260303111741.17417-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzAzMDA4NiBTYWx0ZWRfX8+JV4HTK+qix\n\tIQ/XKUC/sWrSZEQc/KiFYB3v5+sk2bgEpgpiP0kvCCEBgamlAtYTeCyHFlslIEBACQHkoSN/Hk2\n\tpe+t29ryOicK5WIA0xdJmD6F05nmGLHEJ8AX2Dk4J7U6YtizQo3znGbF7Uu4Bux3ezKKNr/zmGX\n\tjX9L8775h6RemE3rPoMiMYMr3g+DaGRWy1M2/9H73BXSxM6XFG8LOyOanaD/un57HJn2hTLpQ4Q\n\twA6WtuMoHHMgfNv5dnsRoFAuKJ3dFeYL1wBRC1xOUpyxWgTfcxckeG5AG6SyDH8DP8Kf3UF2QIb\n\t0uR9F6+VuiXibxVM/kDs7p9eRIKEcSEbQzzxfmIRzVEcZxLQrMHhjsIK1V21UOTiAdtVtKByMxJ\n\tvXKqcgeCwy/9xAEjUob6NG4eRr8OMvNiKZ5ns5ubuOXlAmJw0ytJyVeKWpuz0xwZ9NnKsLib4Ps\n\tF0NDAxyc5XOzbZEXMDQ==", "X-Authority-Analysis": "v=2.4 cv=MuhfKmae c=1 sm=1 tr=0 ts=69a6c35f cx=c_pps\n\ta=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=_K5XuSEh1TEqbUxoQ0s3:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8\n\ta=mKg8M22OkPar6P-70WAA:9 a=kacYvNCVWA4VmyqE58fU:22", "X-Proofpoint-ORIG-GUID": "n64Tv9yWasSHCK2RLVsI7F_X4cy4Vi1N", "X-Proofpoint-GUID": "n64Tv9yWasSHCK2RLVsI7F_X4cy4Vi1N", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-03-02_05,2026-03-03_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0\n\tadultscore=0\n\timpostorscore=0 suspectscore=0 malwarescore=0 clxscore=1015\n\tspamscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2603030086", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As shown by commit 94d32fdc55a3 (\"pipeline: simple: Consider output sizes\nwhen choosing pipe config\"), the extra pixel columns CPU debayering\nrequires on the input side makes resolution selection non trivial.\n\nAdd logging of the selected input config on a successful configure() so\nthat the logs clearly show which sensor mode has been selected.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\nChanges in v2:\n- Move from DebayerCpu::configure() to SoftwareIsp::configure() so that\n the input fmt also gets logged when using the DebayerEgl class\n---\n src/libcamera/software_isp/software_isp.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 562cdba22..4cf5639d9 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -21,6 +21,7 @@\n #include <libcamera/formats.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/bayer_format.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n@@ -270,7 +271,16 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n-\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tret = debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\n+\tLOG(SoftwareIsp, Info)\n+\t\t<< \"Input \" << inputCfg.size\n+\t\t<< \"-\" << BayerFormat::fromPixelFormat(inputCfg.pixelFormat)\n+\t\t<< \" stride \" << inputCfg.stride;\n+\n+\treturn 0;\n }\n \n /**\n", "prefixes": [ "v4", "4/4" ] }