Patch Detail
Show a patch.
GET /api/1.1/patches/26239/?format=api
{ "id": 26239, "url": "https://patchwork.libcamera.org/api/1.1/patches/26239/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26239/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260225221859.600869-3-floss@jetm.me>", "date": "2026-02-25T22:18:59", "name": "[2/2] ipa: simple: data: Add OV2740 tuning file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "31e0ba6a726ee4cf6955f2feba9db13ae2dfe997", "submitter": { "id": 261, "url": "https://patchwork.libcamera.org/api/1.1/people/261/?format=api", "name": "Javier Tia", "email": "floss@jetm.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26239/mbox/", "series": [ { "id": 5812, "url": "https://patchwork.libcamera.org/api/1.1/series/5812/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5812", "date": "2026-02-25T22:18:57", "name": "ipa: simple: Proportional AGC and OV2740 tuning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5812/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26239/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26239/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1F204C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Feb 2026 22:20:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CA8D622F2;\n\tWed, 25 Feb 2026 23:20:19 +0100 (CET)", "from fhigh-a2-smtp.messagingengine.com\n\t(fhigh-a2-smtp.messagingengine.com [103.168.172.153])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1432C622E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Feb 2026 23:20:16 +0100 (CET)", "from phl-compute-03.internal (phl-compute-03.internal\n\t[10.202.2.43])\n\tby mailfhigh.phl.internal (Postfix) with ESMTP id 63E77140015D;\n\tWed, 25 Feb 2026 17:20:15 -0500 (EST)", "from phl-frontend-04 ([10.202.2.163])\n\tby phl-compute-03.internal (MEProxy); Wed, 25 Feb 2026 17:20:15 -0500", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n\t25 Feb 2026 17:20:14 -0500 (EST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=jetm.me header.i=@jetm.me header.b=\"aSldUWDR\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"MOv8txfG\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc\n\t:content-transfer-encoding:content-type:date:date:from:from\n\t:in-reply-to:in-reply-to:message-id:mime-version:references\n\t:reply-to:subject:subject:to:to; s=fm2; t=1772058015; x=\n\t1772144415; bh=etawwz8wYX5zyMveCrQVW5v7g9gVbr4YzsYl5Vs+M6A=; b=a\n\tSldUWDRyXGYys4B0uEM3MalS3j7asazw5xZ7P5j56ek1zyp8cgu7kjUTxw4F5j7W\n\t78Vks5R7+x86OIdfYvPS44lmLPbi64wtrE5KfecZPETuMY34elwJzetwPCierLCA\n\tkAmE1cjlwP+WgNGmUx4RXZ9VC22LBTNf5TXid0KXjXPmlDBEbOdYbwjb+ScSQry0\n\tWp6BfIuE+vW92CG/RQ64zqcjbPveTmfIe1VfEww9F0JJQXEbTOKm0riKcr2eq2gA\n\t36pO8+0HZQBdLBg90wwRfD9FIwvY7eEyEZU6czv+jhjlkJutjCAIii6RLdINw2i4\n\tP5sQjAQAD5F73ABqtg/mg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:date:date:feedback-id:feedback-id:from:from\n\t:in-reply-to:in-reply-to:message-id:mime-version:references\n\t:reply-to:subject:subject:to:to:x-me-proxy:x-me-sender\n\t:x-me-sender:x-sasl-enc; s=fm3; t=1772058015; x=1772144415; bh=e\n\ttawwz8wYX5zyMveCrQVW5v7g9gVbr4YzsYl5Vs+M6A=; b=MOv8txfGvVnR65xsR\n\t/OGM6MmpylcbR/OB+TnqvhK5cKLZUv65105n/tLzjg+zGX7H+/DnRt+Kpi42MJz+\n\tcCfmNTJmUeOBRfxB6KSss9S5g1oijafpXow5p7ruX0F5k1AyprZ2TeXIESlxFn8S\n\tMVMZXKxjWrG+bAsoj7QUmtPp1l5iixedNP7ZyXF0Iq7oKf9dgEeD5oydcKCHs3nN\n\tGzh5HHFoTHH7H1C4xfbipnJmcDtmwGdqjWlXaof2dEGG/HXCzfyIdmsO9nhySPso\n\tf7BcM0TXk5LaR/28LDTE4DMJMw6B4+/5E5aFSropWOW9QfCBBemF6nErRJV3VYs9\n\tywXiQ==" ], "X-ME-Sender": "<xms:n3WfaZtLeVp-e9mq1P0L7JaROIe1pjGGRazZ0KCObtl2-f6xIQh7HA>\n\t<xme:n3WfaYcSCnXYd38ag0t8ZiUGAar2M2R07dK1b9_N_LGmxuSIE47Y2NpdVUYMsK9TI\n\t9ywpHPet01WX-zCQrG6IgqG4idzg_6tUlGuLbX8F0-vfDxgIsdTsuo>", "X-ME-Received": "<xmr:n3WfaaYjrDxLKUfTZuQBxX3P8ulsTN4SRhVq2WwMER5pzJuJSbuaQgXF2Ei16NxXOKLetHUQvPzSXvtCpUHbiA>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgddvgeegvdelucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtkeertd\n\tertddtnecuhfhrohhmpeflrghvihgvrhcuvfhirgcuoehflhhoshhssehjvghtmhdrmhgv\n\tqeenucggtffrrghtthgvrhhnpeeiueehgeevudeiheeuheevgffhtdevheeuffeiieduff\n\tffvdeftdejfefftdekheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr\n\tihhlfhhrohhmpehflhhoshhssehjvghtmhdrmhgvpdhnsggprhgtphhtthhopedvpdhmoh\n\tguvgepshhmthhpohhuthdprhgtphhtthhopehlihgstggrmhgvrhgrqdguvghvvghlsehl\n\tihhsthhsrdhlihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohepfhhlohhsshesjhgvth\n\thmrdhmvg", "X-ME-Proxy": "<xmx:n3WfabWaNHZawcHwfdoFLkjgLyuNZCYomOX3BenMMkBZh1e-mb9iDw>\n\t<xmx:n3Wfacj6BhZfPm36jKUyOfh2n_Ty2hupAXu30Y4b05UfyAoPrh3XHA>\n\t<xmx:n3WfaZViQORJZjceyZXW06hEgOd-k0gSO_B8ZT4O4CbUrgQGhUDJiw>\n\t<xmx:n3WfaTOK7PocZhBSSL3Wjzm9Lq5UijsjV1zevzeq46j6yAwO6fZRkA>\n\t<xmx:n3WfadTMR8pfgdR4M_mHld4lep39fjf_71MNd7Q3GgK4ZzDyA5GyMbEe>", "Feedback-ID": "i9dde48b3:Fastmail", "From": "Javier Tia <floss@jetm.me>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Javier Tia <floss@jetm.me>", "Subject": "[PATCH 2/2] ipa: simple: data: Add OV2740 tuning file", "Date": "Wed, 25 Feb 2026 16:18:59 -0600", "Message-ID": "<20260225221859.600869-3-floss@jetm.me>", "X-Mailer": "git-send-email 2.53.0", "In-Reply-To": "<20260225221859.600869-1-floss@jetm.me>", "References": "<20260225221859.600869-1-floss@jetm.me>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a sensor-specific tuning file for the OmniVision OV2740, commonly\nfound in Intel IPU6 laptops (ThinkPad X1 Carbon, XPS, Surface).\n\nThe tuning enables all Simple IPA algorithms including AGC, AWB, black\nlevel correction, and a color correction matrix calibrated for 6500K.\nThe CCM compensates for the green bias inherent in Bayer demosaicing\n(the GRBG pattern has 2x green pixels vs red/blue).\n\nWithout this file, libcamera falls back to uncalibrated.yaml which\nproduces a heavy green tint on the OV2740.\n\nSigned-off-by: Javier Tia <floss@jetm.me>\n---\n src/ipa/simple/data/meson.build | 1 +\n src/ipa/simple/data/ov2740.yaml | 22 ++++++++++++++++++++++\n 2 files changed, 23 insertions(+)\n create mode 100644 src/ipa/simple/data/ov2740.yaml", "diff": "diff --git a/src/ipa/simple/data/meson.build b/src/ipa/simple/data/meson.build\nindex 92795ee4..e3e4de74 100644\n--- a/src/ipa/simple/data/meson.build\n+++ b/src/ipa/simple/data/meson.build\n@@ -1,6 +1,7 @@\n # SPDX-License-Identifier: CC0-1.0\n \n conf_files = files([\n+ 'ov2740.yaml',\n 'uncalibrated.yaml',\n ])\n \ndiff --git a/src/ipa/simple/data/ov2740.yaml b/src/ipa/simple/data/ov2740.yaml\nnew file mode 100644\nindex 00000000..b48d50ce\n--- /dev/null\n+++ b/src/ipa/simple/data/ov2740.yaml\n@@ -0,0 +1,22 @@\n+# SPDX-License-Identifier: CC0-1.0\n+#\n+# OmniVision OV2740 tuning for libcamera Simple/SoftISP pipeline.\n+#\n+# Tested on ThinkPad X1 Carbon Gen 10 (Alder Lake) with Intel IPU6 ISYS.\n+# The CCM corrects the green bias inherent in Bayer demosaicing (2:1 green\n+# to red/blue pixel ratio in the CFA). Values were iteratively calibrated\n+# from captured frame measurements under 6500K lighting.\n+%YAML 1.1\n+---\n+version: 1\n+algorithms:\n+ - BlackLevel:\n+ - Awb:\n+ - Ccm:\n+ ccms:\n+ - ct: 6500\n+ ccm: [ 2.49, -0.91, -0.26,\n+ -0.30, 1.20, 0.10,\n+ 0.07, -0.80, 2.19 ]\n+ - Adjust:\n+ - Agc:\n", "prefixes": [ "2/2" ] }