Patch Detail
Show a patch.
GET /api/1.1/patches/26231/?format=api
{ "id": 26231, "url": "https://patchwork.libcamera.org/api/1.1/patches/26231/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26231/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260224132415.269693-1-barnabas.pocze@ideasonboard.com>", "date": "2026-02-24T13:24:15", "name": "[v1] libcamera: software_isp: debayer_egl: Remove `frameSize()`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "10f17b320a2373ace0fc7969c0998fb13b5326ad", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26231/mbox/", "series": [ { "id": 5810, "url": "https://patchwork.libcamera.org/api/1.1/series/5810/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5810", "date": "2026-02-24T13:24:15", "name": "[v1] libcamera: software_isp: debayer_egl: Remove `frameSize()`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5810/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26231/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26231/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 198D5BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Feb 2026 13:24:22 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F3A4F622A4;\n\tTue, 24 Feb 2026 14:24:20 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79BCC62080\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 14:24:19 +0100 (CET)", "from pb-laptop.local (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AAB3CAB4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 14:23:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SKyAMZTS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771939402;\n\tbh=hR846s4i1YlVyMIoQKM5vUVJVDfW5g1KPLs7JAZpNq8=;\n\th=From:To:Subject:Date:From;\n\tb=SKyAMZTSzUE4zJtI4kfT3bhpgFSz/6sIv58VG2B6Ikx9weJE4gMzmxU+UXgm54CkH\n\teqzL2bgp61csFA5NRPpKRk1rAPxhxWrrzLYEftVUQ7eT6URp554n79AX53WdGgEclQ\n\tdXP3eX09+Mx/+JgC5InTonXf+5rMC+JmyBuxLHDg=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] libcamera: software_isp: debayer_egl: Remove\n\t`frameSize()`", "Date": "Tue, 24 Feb 2026 14:24:15 +0100", "Message-ID": "<20260224132415.269693-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The base class (`Debayer`) already contains a non-virtual function\nwith the same implementation, so remove it from the derived class.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/software_isp/debayer_egl.cpp | 10 ----------\n src/libcamera/software_isp/debayer_egl.h | 1 -\n 2 files changed, 11 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 93f7c6946..8147eca1c 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -276,16 +276,6 @@ int DebayerEGL::initBayerShaders(PixelFormat inputFormat, PixelFormat outputForm\n \treturn getShaderVariableLocations();\n }\n \n-/**\n- * \\brief Get the output frame size\n- *\n- * \\return The output frame size\n- */\n-unsigned int DebayerEGL::frameSize()\n-{\n-\treturn outputConfig_.frameSize;\n-}\n-\n int DebayerEGL::configure(const StreamConfiguration &inputCfg,\n \t\t\t const std::vector<std::reference_wrapper<StreamConfiguration>> &outputCfgs,\n \t\t\t [[maybe_unused]] bool ccmEnabled)\ndiff --git a/src/libcamera/software_isp/debayer_egl.h b/src/libcamera/software_isp/debayer_egl.h\nindex 59aebcc81..d4c1fa31e 100644\n--- a/src/libcamera/software_isp/debayer_egl.h\n+++ b/src/libcamera/software_isp/debayer_egl.h\n@@ -55,7 +55,6 @@ public:\n \tvoid stop();\n \n \tconst SharedFD &getStatsFD() { return stats_->getStatsFD(); }\n-\tunsigned int frameSize();\n \n \tSizeRange sizes(PixelFormat inputFormat, const Size &inputSize);\n \n", "prefixes": [ "v1" ] }