Patch Detail
Show a patch.
GET /api/1.1/patches/26225/?format=api
{ "id": 26225, "url": "https://patchwork.libcamera.org/api/1.1/patches/26225/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26225/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260223141945.58779-1-mzamazal@redhat.com>", "date": "2026-02-23T14:19:45", "name": "libcamera: software_isp: Set initial values of DebayerParams", "commit_ref": "0d3e543b4d6690f65070b95450aecb5792d0d51f", "pull_url": null, "state": "accepted", "archived": false, "hash": "5411b374b08b28b286d2b2982f9cd0c9d524b190", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26225/mbox/", "series": [ { "id": 5808, "url": "https://patchwork.libcamera.org/api/1.1/series/5808/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5808", "date": "2026-02-23T14:19:45", "name": "libcamera: software_isp: Set initial values of DebayerParams", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5808/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26225/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26225/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47EBBC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Feb 2026 14:19:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 082506228B;\n\tMon, 23 Feb 2026 15:19:57 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1D55621CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Feb 2026 15:19:54 +0100 (CET)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-468-usYjZp3bO5uXC3KVm_bMcg-1;\n\tMon, 23 Feb 2026 09:19:51 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 9467F19560B1; Mon, 23 Feb 2026 14:19:50 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.238])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BD7B01955D71; Mon, 23 Feb 2026 14:19:48 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"GfPEJjdO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1771856393;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=07dLA700o8LmPSlRLrONecWQdUtJWnTqC63YH2VWoyU=;\n\tb=GfPEJjdOTVEVqTkAd5eIGapJzmYRJyaJ4X8ptrh4LY8+LiAVvoTz8odmWvQe5hULkjoATc\n\tMbzb2yPgoOQ2ypCDsH+ZmEZKauTctCX0KlFw87VAM2AsGmWy8CMpqDuqJQdxp5+su+kNQH\n\t0SruOJGGr6bPs39OTsvh37xtuEfCZrI=", "X-MC-Unique": "usYjZp3bO5uXC3KVm_bMcg-1", "X-Mimecast-MFC-AGG-ID": "usYjZp3bO5uXC3KVm_bMcg_1771856391", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH] libcamera: software_isp: Set initial values of DebayerParams", "Date": "Mon, 23 Feb 2026 15:19:45 +0100", "Message-ID": "<20260223141945.58779-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "l3lBi32rz6DB8VAdhOPuPfwdTFssQLy8HL-2J63Blx4_1771856391", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Debayer parameters and processing are currently run asynchronously.\nThis can lead to assertion errors in case the processing tries to use\nnot yet computed debayer parameters. To prevent this situation, specify\nsome default values for DebayerParams members. This doesn't make\ncorrect parameters but prevents crashes or other crazy behaviours at\nleast.\n\nNote this patch is just a workaround. The mutually asynchronous\nparameters computation and processing can cause more problems, like\nusing parameters computed for a different frame. But it is non-trivial\nto fix that; in the meantime, setting the default values solves the\nworst problem.\n\nCloses: https://gitlab.freedesktop.org/camera/libcamera/-/issues/311\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n .../libcamera/internal/software_isp/debayer_params.h | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex 1c0412d75..6772b43bc 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -18,11 +18,13 @@\n namespace libcamera {\n \n struct DebayerParams {\n-\tMatrix<float, 3, 3> combinedMatrix;\n-\tRGB<float> blackLevel;\n-\tfloat gamma;\n-\tfloat contrastExp;\n-\tRGB<float> gains;\n+\tMatrix<float, 3, 3> combinedMatrix = { { 1.0, 0.0, 0.0,\n+\t\t\t\t\t\t 0.0, 1.0, 0.0,\n+\t\t\t\t\t\t 0.0, 0.0, 1.0 } };\n+\tRGB<float> blackLevel = RGB<float>({ 0.0, 0.0, 0.0 });\n+\tfloat gamma = 1.0;\n+\tfloat contrastExp = 1.0;\n+\tRGB<float> gains = RGB<float>({ 1.0, 1.0, 1.0 });\n };\n \n } /* namespace libcamera */\n", "prefixes": [] }