Patch Detail
Show a patch.
GET /api/1.1/patches/26224/?format=api
{ "id": 26224, "url": "https://patchwork.libcamera.org/api/1.1/patches/26224/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26224/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260223091622.322064-1-barnabas.pocze@ideasonboard.com>", "date": "2026-02-23T09:16:22", "name": "[v1] apps: qcam: Fix clang build", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0576f4446b865199ce1cc597463d8bbc9f4802a9", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26224/mbox/", "series": [ { "id": 5807, "url": "https://patchwork.libcamera.org/api/1.1/series/5807/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5807", "date": "2026-02-23T09:16:22", "name": "[v1] apps: qcam: Fix clang build", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5807/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26224/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26224/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA313C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Feb 2026 09:16:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B94DA62280;\n\tMon, 23 Feb 2026 10:16:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B2C461FA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Feb 2026 10:16:26 +0100 (CET)", "from pb-laptop.local (185.221.141.206.nat.pool.zt.hu\n\t[185.221.141.206])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45705308\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Feb 2026 10:15:30 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hn5GaxPf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771838130;\n\tbh=5WlhAsfwpxDlRr5H3CL1AywIZJFtANayc8uCWN9F7/U=;\n\th=From:To:Subject:Date:From;\n\tb=hn5GaxPfFmjh5AjbV7rNuz0O6aOnnC0dzUAAXso3p9w5FqqSJeUMrsgJqnHiEPT1C\n\tsciyKE2z62i66Pb3Gur3WVegZrpr/2xt4Rcxc4ZVvxegJg/BwM7i7WhrRiIBlkNU9X\n\t5nV/t2X7BmR119Df0i2prokgbifiNN7bbFS0N41o=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] apps: qcam: Fix clang build", "Date": "Mon, 23 Feb 2026 10:16:22 +0100", "Message-ID": "<20260223091622.322064-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.53.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "While gcc ignores attempts to disable unknown warnings, clang does not\n(`-Wunknown-warning-option`), thus compilation fails due to the recent\naddition of `-Wno-sfinae-incomplete`. So only add it conditionally.\n\nCloses: https://gitlab.freedesktop.org/camera/libcamera/-/issues/315\nFixes: aa2a0812e6692a (\"apps: qcam: Disable -Wsfinae-incomplete\")\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nI would still love to merge https://patchwork.libcamera.org/patch/26160/\nin some form to avoid this in the future.\n---\n src/apps/qcam/meson.build | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\n--\n2.53.0", "diff": "diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\nindex 8eb815eed..ef4209389 100644\n--- a/src/apps/qcam/meson.build\n+++ b/src/apps/qcam/meson.build\n@@ -40,7 +40,6 @@ qt6_cpp_args = [\n apps_cpp_args,\n '-DQT_NO_KEYWORDS',\n '-Wno-extra-semi',\n- '-Wno-sfinae-incomplete',\n ]\n\n # gcc 12 and 13 output a false positive variable shadowing warning with Qt\n@@ -50,6 +49,10 @@ if qt6_dep.version().version_compare('>=6.9.0') and \\\n qt6_cpp_args += ['-Wno-shadow']\n endif\n\n+if cxx.get_id() == 'gcc' and cxx.version().version_compare('>=16')\n+ qt6_cpp_args += ['-Wno-sfinae-incomplete']\n+endif\n+\n resources = qt6.preprocess(moc_headers : qcam_moc_headers,\n qresources : qcam_resources,\n dependencies : qt6_dep)\n", "prefixes": [ "v1" ] }