Patch Detail
Show a patch.
GET /api/1.1/patches/26220/?format=api
{ "id": 26220, "url": "https://patchwork.libcamera.org/api/1.1/patches/26220/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26220/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260220221636.216353-5-rui.wang@ideasonboard.com>", "date": "2026-02-20T22:16:33", "name": "[v2,4/7] ipa: rkisp1: filter: Add manual denoise mode and manual filter controls", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8838af1164870d27c650df840fd4c338a05f565a", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26220/mbox/", "series": [ { "id": 5806, "url": "https://patchwork.libcamera.org/api/1.1/series/5806/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5806", "date": "2026-02-20T22:16:29", "name": "ipa: rkisp1: make Filter tuning-driven and add manual controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5806/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26220/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26220/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01B1AC32EA\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 Feb 2026 22:17:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2B7862294;\n\tFri, 20 Feb 2026 23:17:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87AB06226E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 Feb 2026 23:16:56 +0100 (CET)", "from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C224A591;\n\tFri, 20 Feb 2026 23:16:01 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ATlEuL/0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771625762;\n\tbh=Kiv3luX1+gEPMuFr1RDU3895jHt07sXhsdVl1FvvTSM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ATlEuL/0FcLujRgCPzh7W+VGFx0MTXqMvENu4D/rV38zaKDTVLJOxt/FAAAuEm6IZ\n\tFaO5UTQu1nkjeWIzBvFtTHgpfhRGNAn4Dhx54sUXtVHimoO+V7IxY6CQ7zHQ0z1yDH\n\tXGItJHElqoMaVX1xf1cIMOcXBCy1U/mfF13CGwl8=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v2 4/7] ipa: rkisp1: filter: Add manual denoise mode and\n\tmanual filter controls", "Date": "Fri, 20 Feb 2026 17:16:33 -0500", "Message-ID": "<20260220221636.216353-5-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260220221636.216353-1-rui.wang@ideasonboard.com>", "References": "<20260220221636.216353-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "-Add NoiseReductionModeManual to draft controls.\n -Implement rkisp1 filter control registration from tuning data\n -Add manual-mode control parsing for filter parameters.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/filter.cpp | 134 +++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/filter.h | 2 +\n src/libcamera/control_ids_draft.yaml | 4 +\n 3 files changed, 140 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/filter.cpp b/src/ipa/rkisp1/algorithms/filter.cpp\nindex 739a0c4d..62d470f4 100644\n--- a/src/ipa/rkisp1/algorithms/filter.cpp\n+++ b/src/ipa/rkisp1/algorithms/filter.cpp\n@@ -178,6 +178,140 @@ int Filter::parseSharpnessConfig(const YamlObject &data,\n \treturn 0;\n }\n \n+void Filter::registerControls([[maybe_unused]] IPAContext &context)\n+{\n+\tauto &cmap = context.ctrlMap;\n+\n+\tif (modes_.empty() or sharpness_.empty()) {\n+\t\tLOG(RkISP1Filter, Warning)\n+\t\t\t<< \"No NoiseReductionModes or Sharpness levels parsed, filter controls not registered\";\n+\t\treturn;\n+\t}\n+\n+\t/* Register sharpness control value from tuning data size*/\n+\tconst size_t sharpnessLevels = sharpness_.size();\n+\tcmap[&controls::Sharpness] = ControlInfo(0.0f, static_cast<float>(sharpnessLevels - 1), 1.0f);\n+\n+\tconst auto manualMode = static_cast<int32_t>(controls::draft::NoiseReductionModeManual);\n+\tauto selectedMode = modes_.find(manualMode);\n+\tif (selectedMode == modes_.end())\n+\t\tselectedMode = modes_.begin();\n+\n+\tconst auto &modeParams = selectedMode->second;\n+\n+\tLOG(RkISP1Filter, Debug)\n+\t\t<< \"Initial NoiseReductionMode set to \" << selectedMode->first;\n+\n+\t/* Register rkisp1-specific filter control values. */\n+\tcmap[&controls::rkisp1::FilterDenoiseMode] =\n+\t\tControlInfo(0, 255, static_cast<int32_t>(modeParams.at(\"mode\")));\n+\tcmap[&controls::rkisp1::FilterDenoiseLumWeight] =\n+\t\tControlInfo(0, 255, static_cast<int32_t>(modeParams.at(\"lum_weight\")));\n+\tcmap[&controls::rkisp1::FilterDenoiseGreenStage1] =\n+\t\tControlInfo(0, 7, static_cast<int32_t>(modeParams.at(\"grn_stage1\")));\n+\tcmap[&controls::rkisp1::FilterDenoiseChrVMode] =\n+\t\tControlInfo(0, 3, static_cast<int32_t>(modeParams.at(\"chr_v_mode\")));\n+\tcmap[&controls::rkisp1::FilterDenoiseChrHMode] =\n+\t\tControlInfo(0, 3, static_cast<int32_t>(modeParams.at(\"chr_h_mode\")));\n+\tcmap[&controls::rkisp1::FilterFacSh0] =\n+\t\tControlInfo(0, 63, static_cast<int32_t>(modeParams.at(\"fac_sh0\")));\n+\tcmap[&controls::rkisp1::FilterFacSh1] =\n+\t\tControlInfo(0, 63, static_cast<int32_t>(modeParams.at(\"fac_sh1\")));\n+\tcmap[&controls::rkisp1::FilterFacMid] =\n+\t\tControlInfo(0, 63, static_cast<int32_t>(modeParams.at(\"fac_mid\")));\n+\tcmap[&controls::rkisp1::FilterFacBl0] =\n+\t\tControlInfo(0, 63, static_cast<int32_t>(modeParams.at(\"fac_bl0\")));\n+\tcmap[&controls::rkisp1::FilterFacBl1] =\n+\t\tControlInfo(0, 63, static_cast<int32_t>(modeParams.at(\"fac_bl1\")));\n+\tcmap[&controls::rkisp1::FilterThreshSh0] =\n+\t\tControlInfo(0, 255, static_cast<int32_t>(modeParams.at(\"thresh_sh0\")));\n+\tcmap[&controls::rkisp1::FilterThreshSh1] =\n+\t\tControlInfo(0, 255, static_cast<int32_t>(modeParams.at(\"thresh_sh1\")));\n+\tcmap[&controls::rkisp1::FilterThreshBl0] =\n+\t\tControlInfo(0, 255, static_cast<int32_t>(modeParams.at(\"thresh_bl0\")));\n+\tcmap[&controls::rkisp1::FilterThreshBl1] =\n+\t\tControlInfo(0, 255, static_cast<int32_t>(modeParams.at(\"thresh_bl1\")));\n+}\n+\n+bool Filter::parseControls(const ControlList &controls)\n+{\n+\tbool updated = false;\n+\tconstexpr auto manual = controls::draft::NoiseReductionModeManual;\n+\tauto ¶ms = modes_[manual];\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterFacSh0); c) {\n+\t\tparams[\"fac_sh0\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterFacSh1); c) {\n+\t\tparams[\"fac_sh1\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterFacMid); c) {\n+\t\tparams[\"fac_mid\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterFacBl0); c) {\n+\t\tparams[\"fac_bl0\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterFacBl1); c) {\n+\t\tparams[\"fac_bl1\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterThreshSh0); c) {\n+\t\tparams[\"thresh_sh0\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterThreshSh1); c) {\n+\t\tparams[\"thresh_sh1\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterThreshBl0); c) {\n+\t\tparams[\"thresh_bl0\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterThreshBl1); c) {\n+\t\tparams[\"thresh_bl1\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterDenoiseMode); c) {\n+\t\tparams[\"mode\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterDenoiseLumWeight); c) {\n+\t\tparams[\"lum_weight\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterDenoiseGreenStage1); c) {\n+\t\tparams[\"grn_stage1\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterDenoiseChrVMode); c) {\n+\t\tparams[\"chr_v_mode\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\tif (const auto &c = controls.get(controls::rkisp1::FilterDenoiseChrHMode); c) {\n+\t\tparams[\"chr_h_mode\"] = *c;\n+\t\tupdated = true;\n+\t}\n+\n+\treturn updated;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\ndiff --git a/src/ipa/rkisp1/algorithms/filter.h b/src/ipa/rkisp1/algorithms/filter.h\nindex 83b90ef3..e6f36df3 100644\n--- a/src/ipa/rkisp1/algorithms/filter.h\n+++ b/src/ipa/rkisp1/algorithms/filter.h\n@@ -35,6 +35,8 @@ private:\n \t\t\t std::unordered_map<std::string, uint32_t> &modeParams);\n \tint parseSharpnessConfig(const YamlObject &data,\n \t\t\t\t std::unordered_map<std::string, uint32_t> &sharpParams);\n+\tvoid registerControls(IPAContext &context);\n+\tbool parseControls(const ControlList &controls);\n \n \tstd::unordered_map<int32_t, std::unordered_map<std::string, uint32_t>> modes_;\n \tstd::vector<std::unordered_map<std::string, uint32_t>> sharpness_;\ndiff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 03309eea..97ccda1c 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -58,6 +58,10 @@ controls:\n value: 4\n description: |\n Noise reduction is applied at different levels to different streams.\n+ - name: NoiseReductionModeManual\n+ value: 5\n+ description: |\n+ Manual control all noise reduction parameters.\n \n - ColorCorrectionAberrationMode:\n type: int32_t\n", "prefixes": [ "v2", "4/7" ] }