Patch Detail
Show a patch.
GET /api/1.1/patches/26209/?format=api
{ "id": 26209, "url": "https://patchwork.libcamera.org/api/1.1/patches/26209/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26209/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260219-kbingham-quantizers-v8-12-2b6ff68ead26@ideasonboard.com>", "date": "2026-02-19T15:05:13", "name": "[v8,12/15] ipa: mali-c55: Convert AWB to UQ<4, 8> usage", "commit_ref": "3d4e0446af06784a8a16a90ea0bc5fcdf47f2113", "pull_url": null, "state": "accepted", "archived": false, "hash": "a4982fff5d61f521bbc79a137343a3945ebb25d8", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26209/mbox/", "series": [ { "id": 5802, "url": "https://patchwork.libcamera.org/api/1.1/series/5802/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5802", "date": "2026-02-19T15:05:01", "name": "libipa: Introduce a Quantized type", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5802/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26209/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26209/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2318C32F2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Feb 2026 15:05:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC1F56228A;\n\tThu, 19 Feb 2026 16:05:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 03AA16225D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Feb 2026 16:05:12 +0100 (CET)", "from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D497A2683;\n\tThu, 19 Feb 2026 16:04:18 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iASSGRM0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771513459;\n\tbh=E714MbmoTzlkEknfkQGU2teK+G38gzHM0hn9fxjmOaE=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=iASSGRM0NGpM325NWDjBfqyitQDyPDUoofDTx3ydYoC2WGXFWvkUfruRszgb/Icjj\n\t7GFX84g57Y4y98lAQkDC5q5yRZUjf1PoXtWn0Oq0vWneNfPWV8WL3USAO/S6WNgAtR\n\tRPlmzbIPWRjRdZ/2W76R0Cgha4NMQAnsObKxxaus=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Thu, 19 Feb 2026 15:05:13 +0000", "Subject": "[PATCH v8 12/15] ipa: mali-c55: Convert AWB to UQ<4, 8> usage", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260219-kbingham-quantizers-v8-12-2b6ff68ead26@ideasonboard.com>", "References": "<20260219-kbingham-quantizers-v8-0-2b6ff68ead26@ideasonboard.com>", "In-Reply-To": "<20260219-kbingham-quantizers-v8-0-2b6ff68ead26@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, Isaac Scott\n\t<isaac.scott@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1771513507; l=5293;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=E714MbmoTzlkEknfkQGU2teK+G38gzHM0hn9fxjmOaE=;\n\tb=5dVSoiCVCumRyn/ReqxMKIOcjPvIBNrf23H6dRCeXCmHxh6arBkOkTpgJrgsnWwNZ4TkoYJl1\n\tfrLonkoNshqAM4ZCBJxycuJqFBBZLk/rEvrPm4vx7s+Ir48bxdPvAP/", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Utilise the new FixedPoint type to explicitly calculate gains for AWB in Q4.8\nformat. This ensures that reporting of gains in metadata reflect the true\nAWB gains applied.\n\nReviewed-by: Isaac Scott <isaac.scott@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv8:\n - Use 1.0f to prevent double usage\n---\n src/ipa/mali-c55/algorithms/awb.cpp | 36 ++++++++++++++++++------------------\n src/ipa/mali-c55/ipa_context.h | 10 ++++++----\n 2 files changed, 24 insertions(+), 22 deletions(-)", "diff": "diff --git a/src/ipa/mali-c55/algorithms/awb.cpp b/src/ipa/mali-c55/algorithms/awb.cpp\nindex fab73294a88f..8a671b52be59 100644\n--- a/src/ipa/mali-c55/algorithms/awb.cpp\n+++ b/src/ipa/mali-c55/algorithms/awb.cpp\n@@ -37,8 +37,8 @@ int Awb::configure([[maybe_unused]] IPAContext &context,\n \t * for the first frame we will make no assumptions and leave the R/B\n \t * channels unmodified.\n \t */\n-\tcontext.activeState.awb.rGain = 1.0;\n-\tcontext.activeState.awb.bGain = 1.0;\n+\tcontext.activeState.awb.rGain = 1.0f;\n+\tcontext.activeState.awb.bGain = 1.0f;\n \n \treturn 0;\n }\n@@ -46,8 +46,8 @@ int Awb::configure([[maybe_unused]] IPAContext &context,\n void Awb::fillGainsParamBlock(MaliC55Params *params, IPAContext &context,\n \t\t\t\tIPAFrameContext &frameContext)\n {\n-\tdouble rGain = context.activeState.awb.rGain;\n-\tdouble bGain = context.activeState.awb.bGain;\n+\tUQ<4, 8> rGain = context.activeState.awb.rGain;\n+\tUQ<4, 8> bGain = context.activeState.awb.bGain;\n \n \t/*\n \t * The gains here map as follows:\n@@ -61,10 +61,10 @@ void Awb::fillGainsParamBlock(MaliC55Params *params, IPAContext &context,\n \t */\n \tauto block = params->block<MaliC55Blocks::AwbGains>();\n \n-\tblock->gain00 = floatingToFixedPoint<4, 8, uint16_t, double>(rGain);\n-\tblock->gain01 = floatingToFixedPoint<4, 8, uint16_t, double>(1.0);\n-\tblock->gain10 = floatingToFixedPoint<4, 8, uint16_t, double>(1.0);\n-\tblock->gain11 = floatingToFixedPoint<4, 8, uint16_t, double>(bGain);\n+\tblock->gain00 = rGain.quantized();\n+\tblock->gain01 = UQ<4, 8>(1.0f).quantized();\n+\tblock->gain10 = UQ<4, 8>(1.0f).quantized();\n+\tblock->gain11 = bGain.quantized();\n \n \tframeContext.awb.rGain = rGain;\n \tframeContext.awb.bGain = bGain;\n@@ -140,18 +140,18 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * gain figures that we can apply to approximate a grey world.\n \t */\n \tunsigned int counted_zones = 0;\n-\tdouble rgSum = 0, bgSum = 0;\n+\tfloat rgSum = 0, bgSum = 0;\n \n \tfor (unsigned int i = 0; i < 225; i++) {\n \t\tif (!awb_ratios[i].num_pixels)\n \t\t\tcontinue;\n \n \t\t/*\n-\t\t * The statistics are in Q4.8 format, so we convert to double\n+\t\t * The statistics are in Q4.8 format, so we convert to float\n \t\t * here.\n \t\t */\n-\t\trgSum += fixedToFloatingPoint<4, 8, double, uint16_t>(awb_ratios[i].avg_rg_gr);\n-\t\tbgSum += fixedToFloatingPoint<4, 8, double, uint16_t>(awb_ratios[i].avg_bg_br);\n+\t\trgSum += UQ<4, 8>(awb_ratios[i].avg_rg_gr).value();\n+\t\tbgSum += UQ<4, 8>(awb_ratios[i].avg_bg_br).value();\n \t\tcounted_zones++;\n \t}\n \n@@ -174,8 +174,8 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * figure by the gains that were applied when the statistics for this\n \t * frame were generated.\n \t */\n-\tfloat rRatio = rgAvg / frameContext.awb.rGain;\n-\tfloat bRatio = bgAvg / frameContext.awb.bGain;\n+\tfloat rRatio = rgAvg / frameContext.awb.rGain.value();\n+\tfloat bRatio = bgAvg / frameContext.awb.bGain.value();\n \n \t/*\n \t * And then we can simply invert the ratio to find the gain we should\n@@ -191,15 +191,15 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * want to fix the miscolouring as quickly as possible.\n \t */\n \tfloat speed = frame < kNumStartupFrames ? 1.0f : 0.2f;\n-\trGain = speed * rGain + context.activeState.awb.rGain * (1.0 - speed);\n-\tbGain = speed * bGain + context.activeState.awb.bGain * (1.0 - speed);\n+\trGain = speed * rGain + context.activeState.awb.rGain.value() * (1.0f - speed);\n+\tbGain = speed * bGain + context.activeState.awb.bGain.value() * (1.0f - speed);\n \n \tcontext.activeState.awb.rGain = rGain;\n \tcontext.activeState.awb.bGain = bGain;\n \n \tmetadata.set(controls::ColourGains, {\n-\t\tstatic_cast<float>(frameContext.awb.rGain),\n-\t\tstatic_cast<float>(frameContext.awb.bGain),\n+\t\tframeContext.awb.rGain.value(),\n+\t\tframeContext.awb.bGain.value(),\n \t});\n \n \tLOG(MaliC55Awb, Debug) << \"For frame number \" << frame << \": \"\ndiff --git a/src/ipa/mali-c55/ipa_context.h b/src/ipa/mali-c55/ipa_context.h\nindex 13885eb83b5c..08f78e4f74ce 100644\n--- a/src/ipa/mali-c55/ipa_context.h\n+++ b/src/ipa/mali-c55/ipa_context.h\n@@ -14,6 +14,8 @@\n \n #include <libipa/fc_queue.h>\n \n+#include \"libipa/fixedpoint.h\"\n+\n namespace libcamera {\n \n namespace ipa::mali_c55 {\n@@ -53,8 +55,8 @@ struct IPAActiveState {\n \t} agc;\n \n \tstruct {\n-\t\tdouble rGain;\n-\t\tdouble bGain;\n+\t\tUQ<4, 8> rGain;\n+\t\tUQ<4, 8> bGain;\n \t} awb;\n };\n \n@@ -66,8 +68,8 @@ struct IPAFrameContext : public FrameContext {\n \t} agc;\n \n \tstruct {\n-\t\tdouble rGain;\n-\t\tdouble bGain;\n+\t\tUQ<4, 8> rGain;\n+\t\tUQ<4, 8> bGain;\n \t} awb;\n };\n \n", "prefixes": [ "v8", "12/15" ] }