Patch Detail
Show a patch.
GET /api/1.1/patches/26189/?format=api
{ "id": 26189, "url": "https://patchwork.libcamera.org/api/1.1/patches/26189/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26189/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260218-kbingham-awb-cleanup-v3-2-3be1269ef949@ideasonboard.com>", "date": "2026-02-18T16:42:42", "name": "[v3,2/3] ipa: simple: Remove duplicate header inclusion", "commit_ref": "a1d272d7f1bf4f304c431b9d560deb03c1986a9b", "pull_url": null, "state": "accepted", "archived": false, "hash": "f93b6c44897bb6b278b8a1243b317c9621df13e4", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26189/mbox/", "series": [ { "id": 5799, "url": "https://patchwork.libcamera.org/api/1.1/series/5799/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5799", "date": "2026-02-18T16:42:40", "name": "ipa: awb: Fix and cleanup RKISP1 and Simple Awb", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5799/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26189/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26189/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5096CC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 Feb 2026 16:47:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B09ED62238;\n\tWed, 18 Feb 2026 17:47:27 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ADE23621F1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Feb 2026 17:47:24 +0100 (CET)", "from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DAEA5C79;\n\tWed, 18 Feb 2026 17:46:31 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Q4KT78qJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771433192;\n\tbh=VG6tw4lww0gXthLkfVWb96d9vRqaOthIRqPPgzwCIU4=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Q4KT78qJVQtzLOX/iPVwocrsp/GH76qddzwLjKnIP23JbkLpiHzZdMsnrJWyE1VX4\n\ttXSqSq4k0GvdmorFuBacPXzk85BL0tX0EUc7eDiLA4EVz3kXEajB1BqS04JMrHglgG\n\tAbu0lQBCg7P41gUbb4uH8BOm2uJSYT00jSkgo1lA=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Wed, 18 Feb 2026 16:42:42 +0000", "Subject": "[PATCH v3 2/3] ipa: simple: Remove duplicate header inclusion", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260218-kbingham-awb-cleanup-v3-2-3be1269ef949@ideasonboard.com>", "References": "<20260218-kbingham-awb-cleanup-v3-0-3be1269ef949@ideasonboard.com>", "In-Reply-To": "<20260218-kbingham-awb-cleanup-v3-0-3be1269ef949@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab?=\n\t=?utf-8?b?w6FzIFDFkWN6ZQ==?= <barnabas.pocze@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1771433243; l=789;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=VG6tw4lww0gXthLkfVWb96d9vRqaOthIRqPPgzwCIU4=;\n\tb=aEmfUmxygpCnv2QM4lWrQWWnAjIxyR8cdyLcV3aZWC2Q7v9EWlDMNU3CSyK3u63KaStwuju7h\n\tuSXhEBgChZ+DX4sqk7A1ElORIEh86yPmw7Wklwo3Yykg1IcsNzDJW/U", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Awb component already references libcamera/control_ids.h. Remove\nthe incorrect duplicate inclusion of \"control_ids.h\".\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 4ed1be289562..f5c88ea6f896 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -17,8 +17,6 @@\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n-#include \"control_ids.h\"\n-\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPASoftAwb)\n", "prefixes": [ "v3", "2/3" ] }