Patch Detail
Show a patch.
GET /api/1.1/patches/26166/?format=api
{ "id": 26166, "url": "https://patchwork.libcamera.org/api/1.1/patches/26166/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26166/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260216190204.106922-5-johannes.goede@oss.qualcomm.com>", "date": "2026-02-16T19:02:03", "name": "[4/5] software_isp: debayer_cpu: Select process inner loop by function pointer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5ad589b402eae811b0123d5f4ffaa617d99ea2e3", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/1.1/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26166/mbox/", "series": [ { "id": 5794, "url": "https://patchwork.libcamera.org/api/1.1/series/5794/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5794", "date": "2026-02-16T19:01:59", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5794/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26166/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26166/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F37DDC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Feb 2026 19:02:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 774DE62209;\n\tMon, 16 Feb 2026 20:02:16 +0100 (CET)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 462E5621FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 20:02:13 +0100 (CET)", "from pps.filterd (m0279862.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61GH4VBZ985305 for <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 19:02:11 GMT", "from mail-vk1-f198.google.com (mail-vk1-f198.google.com\n\t[209.85.221.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc7ap08mj-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 19:02:11 +0000 (GMT)", "by mail-vk1-f198.google.com with SMTP id\n\t71dfb90a1353d-567503c3dbdso5295695e0c.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 11:02:11 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b8fc735e587sm276698966b.2.2026.02.16.11.02.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Feb 2026 11:02:09 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"DVMA2GQN\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"bDPt1sWl\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=6rYZ4DZgBGf\n\ttLzZQ7ANPf59s8EG5sl99CSqwra87u9Y=; b=DVMA2GQNY4y+d2kruLmyfWQWZvZ\n\t2YuaOVe5siLrv8u/mze/s5gdPZK9p0InIrosLSpc6BRM5QTbIlh/3FSlyQtSlJRZ\n\tOe6q/bdtFMKavnun7v1vzD0ACi5Ski+ITDoYjNGJQsWquUsGh39ltaMgNH6VKDTJ\n\tWeIrUhSeFC79O36eA7FBL9rVQHv3Ie/ahWnLR/P/70FVRt6qaKcvTyvmC9FeXWf7\n\txno/Ub3YY8B+/MsZVVdmKXIUXdZA/nabP7dfJYPhsqHEoqn55T4WqYcRgPfSKEEo\n\tBYow9XQQKQqvzl91CLF7olPnDGsj1/3cKsLX7W2RW5xdNrPA1fOFxFfNSXQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771268530; x=1771873330;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=6rYZ4DZgBGftLzZQ7ANPf59s8EG5sl99CSqwra87u9Y=;\n\tb=bDPt1sWlbLKu9eB6G85v3Q6xX9Aqr6vS4fko9MTm/rXxRirVRz9n0ggfRyLhl8xOhJ\n\tgEr9uz4xo8+OA9yrz3lYuynIFlYVEINSwXK2zFBMqhnZ4pnn0EQdCHocp9bD9js2sPCB\n\tgYUAa/8Ib5OheygC1HjcalLO4vt610i6lg6bMk105EZnkeFNvdc8vaeYOEpgCfaHer6T\n\trJwERWuWdc6at4jE6YhRbUJBSWn67bej4t6EwxUIg/2+dHp4OwRy0oGbQU2qYDkfgXL5\n\tVaNtqxbON+KjMquTCGJQ2f7p7gZFsPRXZLP2N/T9w92+IZfHXPcSonG3kU/NfBgP1mlQ\n\t39Ww==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771268530; x=1771873330;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=6rYZ4DZgBGftLzZQ7ANPf59s8EG5sl99CSqwra87u9Y=;\n\tb=HsrkD6STa6AqzFFUDgOBOYqDRvTklt7C4W+pNf99qqS+n2+fj3f1VxE2c9Kp5EaA9i\n\t/Nvo2ppEQcfJOBTNjWCyE6Q9q64RoO5vm0qIAIAv7fIINQaWaysi/5e3a3XWrDv0JHk4\n\t4RDLUwGWQWHoCWwkdoEp5k1MkAL/ZEp9jM9++3C9p1UfH3PicTIKm34nHii+liHoUnsQ\n\txBQivBadr9I53JzxVQfxM9QP418c2mfR8bfBTN4cneeiknEjwklVE5V/jilyoY5BWchM\n\tChwLwPdenrDtXg+4HCks7vNRrznMnsNen0KMDeFy1BUKWLL0e6kZwhTrm83wuwwjvOTI\n\toQRQ==", "X-Gm-Message-State": "AOJu0YyMZG9qS/6PAT1RP3JJtfvnnVb0BOrD2UCGkj3h90CxV/s/jd62\n\tanhe/4t8G9PX25+fc3GZ9Gi+0pbnF++zEpywwY2f4/pufcpHVzS0p6ZTltkKt8U1FGlWbX0gxvR\n\tlGwihDNCo9DpgK1wrg/68w4WnxXCcm9LUflCsUhXL+mYQ1Zuc1Zy8e4+2VowimrxVa29kmqt6n+\n\tQ6sGkYxBMv", "X-Gm-Gg": "AZuq6aI/3GJYYohKjpjcbjcUpoSzTgMjENrHFzSaGp0fT+zp53uMXvSammTnkF6725l\n\tkfKGjsq3GXQ9JKC2tX+iP3Bj/YYJOaMV0q0QvNPOaDYDkzAVmNNYpCBcuvwti1zX8t1gjou5Fcb\n\tB1/4IRRiBKyH+WCfIniqXaNfZynzHpOzx92ppABI+YjEUVsmgPLYcydXvlLngjwXwx2lFJdeH1c\n\tp8/zSgZLQiINgegFco4q3tqGIPKUwx8yP8HhQhv6nbl33h87GAvFEVCHGQIPYF1XeVlEL6iaS1F\n\tr7DtVLxTfbO6wUwton8KxIphq9l8jXFLviXVgIqgNkyfG37vRxxTEzRvoVK/59Gmcmen85OKtKB\n\tOjqwGgc3eIauM2SMOzX+Sk13poHf7Vl6Y2pZnuOvTGlsNnuX3CV1ocOi4kZgBZlI2WTjF9qWuXn\n\t/pFaQABmdtm76RmD6pT1tH6E7yuO9efkzYtjt/", "X-Received": [ "by 2002:a05:6122:32cb:b0:559:5ef5:b196 with SMTP id\n\t71dfb90a1353d-56889bf9467mr2270160e0c.13.1771268530162; \n\tMon, 16 Feb 2026 11:02:10 -0800 (PST)", "by 2002:a05:6122:32cb:b0:559:5ef5:b196 with SMTP id\n\t71dfb90a1353d-56889bf9467mr2270129e0c.13.1771268529692; \n\tMon, 16 Feb 2026 11:02:09 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH 4/5] software_isp: debayer_cpu: Select process inner loop by\n\tfunction pointer", "Date": "Mon, 16 Feb 2026 20:02:03 +0100", "Message-ID": "<20260216190204.106922-5-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260216190204.106922-1-johannes.goede@oss.qualcomm.com>", "References": "<20260216190204.106922-1-johannes.goede@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjE2MDE2MyBTYWx0ZWRfXwm/dHNZI1da2\n\tN+Z33R+MagnMruuiioHe805RGODeT+92LJuEXQe6mT1+/fIUdg1tVzQ1LAArvPtfC2oCYlFb7TX\n\tu2dm2PBIhWUSwklWFwW/lPEcbto7XOt4NndBIvAMdpb1bCLoDdreKVrFvrSzKVXCaCZCzOY59j4\n\tRpnleqIlYb0wBWX9IulTtxgYN7x12ZGvPeWllfhOM0xlwVFEHuYYZN+uUV55htu1pT7n5QR+rzv\n\tdgFD02EgGyL61AOs+QEc4t60YwHLDzwPy/cDJ3BKU9LrpdAmuar5ksllk+dOBt0hPedDhNsV3/n\n\tliK6lp3VoDqmklAQ2VAubYEKfXig6nTsxTJfz5bbJBAceJ3lvMVbDZJYTGiBE6voKrLceoZnTLR\n\ts3lkytz3momfIUI86yLEA2h5OSpAgz4tmZAbzZAkxRR7DzMeEKgMdDqyrWRqeXI9IDEaegED1E8\n\tJsnVFa9qKykaDeDbEAw==", "X-Proofpoint-ORIG-GUID": "wkF-Jh02Ag3z1cqHGhWzi3BRCQWy0yKF", "X-Proofpoint-GUID": "wkF-Jh02Ag3z1cqHGhWzi3BRCQWy0yKF", "X-Authority-Analysis": "v=2.4 cv=Rfydyltv c=1 sm=1 tr=0 ts=699369b3 cx=c_pps\n\ta=1Os3MKEOqt8YzSjcPV0cFA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n\ta=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=invZXm7wCyodYBJXmhMA:9\n\ta=hhpmQAJR8DioWGSBphRh:22", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-16_06,2026-02-16_04,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tmalwarescore=0 spamscore=0 lowpriorityscore=0 impostorscore=0\n\tsuspectscore=0\n\tclxscore=1015 phishscore=0 priorityscore=1501 adultscore=0\n\tbulkscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2601150000\n\tdefinitions=main-2602160163", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "At a processInner_ function pointer and set this to process2() /\nprocess4() in configure instead of making the choise inline in process().\n\nThis is a preparation patch for making DebayerCpu support multi-threading.\n\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n src/libcamera/software_isp/debayer_cpu.cpp | 10 ++++++----\n src/libcamera/software_isp/debayer_cpu.h | 4 ++++\n 2 files changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex e1d3c164..5e168554 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -437,6 +437,11 @@ int DebayerCpu::setDebayerFunctions(PixelFormat inputFormat,\n \t\treturn invalidFmt();\n \t}\n \n+\tif (inputConfig_.patternSize.height == 2)\n+\t\tprocessInner_ = &DebayerCpu::process2;\n+\telse\n+\t\tprocessInner_ = &DebayerCpu::process4;\n+\n \tif ((bayerFormat.bitDepth == 8 || bayerFormat.bitDepth == 10 || bayerFormat.bitDepth == 12) &&\n \t bayerFormat.packing == BayerFormat::Packing::None &&\n \t isStandardBayerOrder(bayerFormat.order)) {\n@@ -890,10 +895,7 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \n \tthreadData_[0].yStart = 0;\n \tthreadData_[0].yEnd = window_.height;\n-\tif (inputConfig_.patternSize.height == 2)\n-\t\tprocess2(frame, in.planes()[0].data(), out.planes()[0].data(), &threadData_[0]);\n-\telse\n-\t\tprocess4(frame, in.planes()[0].data(), out.planes()[0].data(), &threadData_[0]);\n+\t(this->*processInner_)(frame, in.planes()[0].data(), out.planes()[0].data(), &threadData_[0]);\n \n \tmetadata.planes()[0].bytesused = out.planes()[0].size();\n \ndiff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex a54418dc..b85dd11c 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -87,6 +87,9 @@ private:\n \t\tbool processLastLinesSeperately;\n \t};\n \n+\tusing processFn = void (DebayerCpu::*)(uint32_t frame, const uint8_t *src, uint8_t *dst,\n+\t\t\t\t\t DebayerCpuThreadData *threadData);\n+\n \t/* 8-bit raw bayer format */\n \ttemplate<bool addAlphaByte, bool ccmEnabled>\n \tvoid debayer8_BGBG_BGR888(uint8_t *dst, const uint8_t *src[]);\n@@ -164,6 +167,7 @@ private:\n \tunsigned int threadCount_;\n \tbool ccmEnabled_;\n \tDebayerParams params_;\n+\tprocessFn processInner_;\n };\n \n } /* namespace libcamera */\n", "prefixes": [ "4/5" ] }