Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 26164,
    "url": "https://patchwork.libcamera.org/api/1.1/patches/26164/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/26164/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20260216190204.106922-2-johannes.goede@oss.qualcomm.com>",
    "date": "2026-02-16T19:02:00",
    "name": "[1/5] software_isp: swstats_cpu: Move accumulator storage out of the class",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "1a9786c383bdc3c5c095b21599aab0475a9ae1eb",
    "submitter": {
        "id": 242,
        "url": "https://patchwork.libcamera.org/api/1.1/people/242/?format=api",
        "name": "Hans de Goede",
        "email": "johannes.goede@oss.qualcomm.com"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/26164/mbox/",
    "series": [
        {
            "id": 5794,
            "url": "https://patchwork.libcamera.org/api/1.1/series/5794/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5794",
            "date": "2026-02-16T19:01:59",
            "name": "software_isp: debayer_cpu: Add multi-threading support",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/5794/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/26164/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/26164/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CFD8C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Feb 2026 19:02:14 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16F68621F6;\n\tMon, 16 Feb 2026 20:02:12 +0100 (CET)",
            "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7584562084\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 20:02:10 +0100 (CET)",
            "from pps.filterd (m0279863.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61GBCMhu2522870 for <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 19:02:09 GMT",
            "from mail-vk1-f198.google.com (mail-vk1-f198.google.com\n\t[209.85.221.198])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cb6bukt7g-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 19:02:08 +0000 (GMT)",
            "by mail-vk1-f198.google.com with SMTP id\n\t71dfb90a1353d-5662a8e87a0so6082139e0c.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Feb 2026 11:02:08 -0800 (PST)",
            "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b8fc735e587sm276698966b.2.2026.02.16.11.02.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Feb 2026 11:02:06 -0800 (PST)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"S9+VVNS7\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"Jhn03iVy\"; dkim-atps=neutral",
        "DKIM-Signature": [
            "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:in-reply-to:message-id\n\t:mime-version:references:subject:to; s=qcppdkim1; bh=ZPJPpQWAv3f\n\twV2B3qD8jcpXwRAqAWVW9lYTGrYN+zBY=; b=S9+VVNS7WFJNfxZMOBLZuxQjSSY\n\tc+QssJXfMo/9Uq+Mb1YIm6c2xibe26TQmr9qVcarO9kDp9FctTeaaM+4owaGkEr1\n\t1Q8JssshbLvLFy6Q2abEglwymaEBHP6kQT1CYQnRXJwCxeJaln6/DNZ0waaBFoxi\n\tYwnvXJfjoXKZxmOUw2usG3znCihsvpDnNPgXHoU8eYTBJ2HWDL0eDmMsEESZwd81\n\tGlps/M36dVjimNjbYVs1ACRf2ll3hNv9hUyF8qBdLHZBfRpzOuqb86G8EUSLuqR/\n\tcmbNvzD5VgrKrrSd+yk2nBdgWPMyQfZH+jEveqdkf/llfFmJzDIDwXPI89A==",
            "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771268527; x=1771873327;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZPJPpQWAv3fwV2B3qD8jcpXwRAqAWVW9lYTGrYN+zBY=;\n\tb=Jhn03iVySC94d16byLjk7kIoWiv4/ClQw8BK/2gaPpyb32yRTR9VMUOOcYiSV4e8W9\n\tCbSRQs2Qz+PT2sgIsnuyXiwbRajYXJSe98e5wtVM6dcsn93puPkXszpOaeZsQGIrRQg7\n\tAwjMOsOrvvvn15YWfslnGSPho7CLGKst4DUiAesGZ9iBly93l7xQEGnpltpaiV9R8Zke\n\tlPzTXKPR0DI9i53oA5pxuzOqt6YvU51nyxZGxejV4Bg/SOkXmlkoV0NxuMTxJ6zI2v6s\n\tUpV4YlbEVDoqqndxuBONgJZwZA8NcNLigX3qCQnE/ddIsgEl+8ItShucu+gKPWKRC/kW\n\tJJhw=="
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771268527; x=1771873327;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZPJPpQWAv3fwV2B3qD8jcpXwRAqAWVW9lYTGrYN+zBY=;\n\tb=XNBi4bYhAvP6NNw6AEl70TOms/EaS0+TbmJnUiismemtyINO5r0ICrbkyLDZaDkRcu\n\tdR7owhq+mp0Zb0JQp3Ue+fIVXAyRGEfx2DkXPc9knGNyTSL2Ho6mjzhtsLvLw5ruFPau\n\tUjKma71vGIILs9KTRBfgKWP0MZBO7/9T7AF3t7ppv9J+0TLFKZqRQFnDnrfk43WB/NgW\n\tsQGa+nQQhP37jyEfASaOdaD1KEQe72V6rv8r4JUIQTy4oYXUJrxXA1abdP0+ja5/WM4r\n\tHhV2irvl/iqhVvyAe9WvdonNiAms5fNHnKVDUOQrXYli9+CY9Ve6swy730mkAkQMz5hf\n\tqqOw==",
        "X-Gm-Message-State": "AOJu0YwqXTIWjLMTkKkfVwXdTkLsaCI9Oevd5L0nlS496TrnQzCJdonR\n\t/UUnvwoCSrtSZ2wUW624gZth/kTj6rdI0n21+65U6GXxUorkhtBGDxkZPdg/USXRj4pv8fnYyVw\n\thoyxa9iydz7kge2RUGjMPbHLTwmHuS5TW1dprEEVjRwqdYRiqneIFcsNW2njDf6TRThg6vTpTqn\n\tvzysj+RrME",
        "X-Gm-Gg": "AZuq6aKjSkAJa3560N/GmHV7aAk6LOvM7EgbCe7OUdBZzHbce9kJvrwtKUSsrB+5/8i\n\t7Qx6cWiymkquCzxs6jmcopCPzAjQEH22wmyJ7sH8EpCVGkwAHga++2bTeV07tdrYAHe8GwVbVsx\n\txXgkY45lAi6rzgrjE5ZLjYCtbKIxrqGA8tT7sPYMD6QLu79y7dQYn1pXC+y2pbwRg0La7b6bdQh\n\tjSz1PgzT/4gjeXHfAMYE4MFVmC29Ono2TE0LUmh5y6rNpLyvuqh2tighO3CH6q/aQTSlQsdk11L\n\tQ7/UW3wL2mDXzSJhX2EUOJh5BdypoPH9UQxn2JjOaBT+XEwAuSSo5RiQ2cb/e/ZDe/yfMo/bCDf\n\tb6I93n5D1ZQpmnlJH9u+Lkd0p2BDOZs0K+qVbQfXvK9a3Yo/oy38mxNT52bWCQ65bFkFpNc84A/\n\t6WEKDqG4/QfzlUc/vSQPc5z981d0W7SAOwrMVb",
        "X-Received": [
            "by 2002:a05:6122:a01:b0:563:73ff:19be with SMTP id\n\t71dfb90a1353d-56889b6bd02mr2103340e0c.8.1771268527254; \n\tMon, 16 Feb 2026 11:02:07 -0800 (PST)",
            "by 2002:a05:6122:a01:b0:563:73ff:19be with SMTP id\n\t71dfb90a1353d-56889b6bd02mr2103283e0c.8.1771268526657; \n\tMon, 16 Feb 2026 11:02:06 -0800 (PST)"
        ],
        "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>",
        "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>",
        "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>",
        "Subject": "[PATCH 1/5] software_isp: swstats_cpu: Move accumulator storage out\n\tof the class",
        "Date": "Mon, 16 Feb 2026 20:02:00 +0100",
        "Message-ID": "<20260216190204.106922-2-johannes.goede@oss.qualcomm.com>",
        "X-Mailer": "git-send-email 2.52.0",
        "In-Reply-To": "<20260216190204.106922-1-johannes.goede@oss.qualcomm.com>",
        "References": "<20260216190204.106922-1-johannes.goede@oss.qualcomm.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-Proofpoint-GUID": "j7gR0LYcap0kG8jzxCFVBwRbf8C_6K8R",
        "X-Proofpoint-ORIG-GUID": "j7gR0LYcap0kG8jzxCFVBwRbf8C_6K8R",
        "X-Authority-Analysis": "v=2.4 cv=M8dA6iws c=1 sm=1 tr=0 ts=699369b0 cx=c_pps\n\ta=1Os3MKEOqt8YzSjcPV0cFA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22\n\ta=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=3n2xhyToohh5fnZkaeQA:9\n\ta=hhpmQAJR8DioWGSBphRh:22",
        "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjE2MDE2MyBTYWx0ZWRfX6LJNkA33AM6L\n\t7CzMv7vI1yC8IXt0EjsZwOoYMtoGufYJE6j16rjM349g5IrkQEpOGyj/wkRgGwV7rW4vMUVqQ25\n\toJYBkw8BO8gZ+f6qDVcqAJ8lTr1OfIi7D2v92PmQzbBYvEXrcJB6lUlebneMkMpjfuKrXb9xzqI\n\tHB9LgW852xrBuDOoCRdGjnvwCh1PS9MxQT1SJMwYjmIVndumxDJZ80vIWTt/IDpnRm4YQst9g+T\n\tcPhoFWMkCCyuzksjjfKd0YEbKl1w/neKWEl8ZU7zBX62/nssz0tC2zRNa5V5vepvVjojJWRn/N2\n\tqwUfG0loJCqPLZKe/6ScxMWqNm0U6UFT0M3ZerHhZsSd5NgkqA2dWgqgkkxUimL+vuYc7PnFtpG\n\tbDXoe1fmAqjJyU6NBj0J5FXU7LTL71qgXn+24PELY9tAVmfiO+gJRG/AWIRu2a2Po9EyudeQXO0\n\tLlpjNEk+8bOTcjE+Zxg==",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-16_06,2026-02-16_04,2025-10-01_01",
        "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0\n\tclxscore=1015 phishscore=0 lowpriorityscore=0 priorityscore=1501\n\tmalwarescore=0 classifier=typeunknown authscore=0 authtc= authcc=\n\troute=outbound adjust=0 reason=mlx scancount=1\n\tengine=8.22.0-2601150000\n\tdefinitions=main-2602160163",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "Move the storage used to accumulate the RGB sums and the Y histogram\nout of the SwStatsCpu class and into the callers.\n\nThe idea is to allow a single SwStatsCpu object to be shared between\nmultiple threads each processing part of the image, with finishFrame()\naccumulating the per thread data into the final stats for the entire\nframe.\n\nThis is a preparation patch for making DebayerCpu support multi-threading\nand this could also be used to make processFrame() multi-threaded.\n\nBenchmarking with the GPU-ISP which does separate swstats benchmarking,\non the Uno-Q which has a weak CPU which is good for performance testing,\nshows 20-21ms to generate stats for a 3272x2464 frame both before and\nafter this change.\n\nSigned-off-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n .../internal/software_isp/swstats_cpu.h       | 29 ++++-----\n src/libcamera/software_isp/debayer_cpu.cpp    | 12 ++--\n src/libcamera/software_isp/debayer_cpu.h      |  1 +\n src/libcamera/software_isp/swstats_cpu.cpp    | 65 +++++++++++++------\n 4 files changed, 65 insertions(+), 42 deletions(-)",
    "diff": "diff --git a/include/libcamera/internal/software_isp/swstats_cpu.h b/include/libcamera/internal/software_isp/swstats_cpu.h\nindex 64b3e23f..a157afe8 100644\n--- a/include/libcamera/internal/software_isp/swstats_cpu.h\n+++ b/include/libcamera/internal/software_isp/swstats_cpu.h\n@@ -53,11 +53,11 @@ public:\n \n \tint configure(const StreamConfiguration &inputCfg);\n \tvoid setWindow(const Rectangle &window);\n-\tvoid startFrame(uint32_t frame);\n-\tvoid finishFrame(uint32_t frame, uint32_t bufferId);\n+\tvoid startFrame(uint32_t frame, struct SwIspStats statsBuffer[], unsigned int statsBufferCount);\n+\tvoid finishFrame(uint32_t frame, uint32_t bufferId, struct SwIspStats statsBuffer[], unsigned int statsBufferCount);\n \tvoid processFrame(uint32_t frame, uint32_t bufferId, FrameBuffer *input);\n \n-\tvoid processLine0(uint32_t frame, unsigned int y, const uint8_t *src[])\n+\tvoid processLine0(uint32_t frame, unsigned int y, const uint8_t *src[], SwIspStats *stats)\n \t{\n \t\tif (frame % kStatPerNumFrames)\n \t\t\treturn;\n@@ -66,10 +66,10 @@ public:\n \t\t    y >= (window_.y + window_.height))\n \t\t\treturn;\n \n-\t\t(this->*stats0_)(src);\n+\t\t(this->*stats0_)(src, stats);\n \t}\n \n-\tvoid processLine2(uint32_t frame, unsigned int y, const uint8_t *src[])\n+\tvoid processLine2(uint32_t frame, unsigned int y, const uint8_t *src[], SwIspStats *stats)\n \t{\n \t\tif (frame % kStatPerNumFrames)\n \t\t\treturn;\n@@ -78,27 +78,27 @@ public:\n \t\t    y >= (window_.y + window_.height))\n \t\t\treturn;\n \n-\t\t(this->*stats2_)(src);\n+\t\t(this->*stats2_)(src, stats);\n \t}\n \n \tSignal<uint32_t, uint32_t> statsReady;\n \n private:\n-\tusing statsProcessFn = void (SwStatsCpu::*)(const uint8_t *src[]);\n-\tusing processFrameFn = void (SwStatsCpu::*)(MappedFrameBuffer &in);\n+\tusing statsProcessFn = void (SwStatsCpu::*)(const uint8_t *src[], SwIspStats *stats);\n+\tusing processFrameFn = void (SwStatsCpu::*)(MappedFrameBuffer &in, SwIspStats *stats);\n \n \tint setupStandardBayerOrder(BayerFormat::Order order);\n \t/* Bayer 8 bpp unpacked */\n-\tvoid statsBGGR8Line0(const uint8_t *src[]);\n+\tvoid statsBGGR8Line0(const uint8_t *src[], SwIspStats *stats);\n \t/* Bayer 10 bpp unpacked */\n-\tvoid statsBGGR10Line0(const uint8_t *src[]);\n+\tvoid statsBGGR10Line0(const uint8_t *src[], SwIspStats *stats);\n \t/* Bayer 12 bpp unpacked */\n-\tvoid statsBGGR12Line0(const uint8_t *src[]);\n+\tvoid statsBGGR12Line0(const uint8_t *src[], SwIspStats *stats);\n \t/* Bayer 10 bpp packed */\n-\tvoid statsBGGR10PLine0(const uint8_t *src[]);\n-\tvoid statsGBRG10PLine0(const uint8_t *src[]);\n+\tvoid statsBGGR10PLine0(const uint8_t *src[], SwIspStats *stats);\n+\tvoid statsGBRG10PLine0(const uint8_t *src[], SwIspStats *stats);\n \n-\tvoid processBayerFrame2(MappedFrameBuffer &in);\n+\tvoid processBayerFrame2(MappedFrameBuffer &in, SwIspStats *stats);\n \n \tprocessFrameFn processFrame_;\n \n@@ -117,7 +117,6 @@ private:\n \tunsigned int stride_;\n \n \tSharedMemObject<SwIspStats> sharedStats_;\n-\tSwIspStats stats_;\n \tBenchmark bench_;\n };\n \ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex d0988357..97c1959a 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -673,7 +673,7 @@ void DebayerCpu::process2(uint32_t frame, const uint8_t *src, uint8_t *dst)\n \tfor (unsigned int y = 0; y < yEnd; y += 2) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n-\t\tstats_->processLine0(frame, y, linePointers);\n+\t\tstats_->processLine0(frame, y, linePointers, &statsBuffer_);\n \t\t(this->*debayer0_)(dst, linePointers);\n \t\tsrc += inputConfig_.stride;\n \t\tdst += outputConfig_.stride;\n@@ -688,7 +688,7 @@ void DebayerCpu::process2(uint32_t frame, const uint8_t *src, uint8_t *dst)\n \tif (window_.y == 0) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n-\t\tstats_->processLine0(frame, yEnd, linePointers);\n+\t\tstats_->processLine0(frame, yEnd, linePointers, &statsBuffer_);\n \t\t(this->*debayer0_)(dst, linePointers);\n \t\tsrc += inputConfig_.stride;\n \t\tdst += outputConfig_.stride;\n@@ -724,7 +724,7 @@ void DebayerCpu::process4(uint32_t frame, const uint8_t *src, uint8_t *dst)\n \tfor (unsigned int y = 0; y < window_.height; y += 4) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n-\t\tstats_->processLine0(frame, y, linePointers);\n+\t\tstats_->processLine0(frame, y, linePointers, &statsBuffer_);\n \t\t(this->*debayer0_)(dst, linePointers);\n \t\tsrc += inputConfig_.stride;\n \t\tdst += outputConfig_.stride;\n@@ -737,7 +737,7 @@ void DebayerCpu::process4(uint32_t frame, const uint8_t *src, uint8_t *dst)\n \n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n-\t\tstats_->processLine2(frame, y, linePointers);\n+\t\tstats_->processLine2(frame, y, linePointers, &statsBuffer_);\n \t\t(this->*debayer2_)(dst, linePointers);\n \t\tsrc += inputConfig_.stride;\n \t\tdst += outputConfig_.stride;\n@@ -866,7 +866,7 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \t\treturn;\n \t}\n \n-\tstats_->startFrame(frame);\n+\tstats_->startFrame(frame, &statsBuffer_, 1);\n \n \tif (inputConfig_.patternSize.height == 2)\n \t\tprocess2(frame, in.planes()[0].data(), out.planes()[0].data());\n@@ -885,7 +885,7 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \t *\n \t * \\todo Pass real bufferId once stats buffer passing is changed.\n \t */\n-\tstats_->finishFrame(frame, 0);\n+\tstats_->finishFrame(frame, 0, &statsBuffer_, 1);\n \toutputBufferReady.emit(output);\n \tinputBufferReady.emit(input);\n }\ndiff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\nindex 7a651746..8abf5168 100644\n--- a/src/libcamera/software_isp/debayer_cpu.h\n+++ b/src/libcamera/software_isp/debayer_cpu.h\n@@ -135,6 +135,7 @@ private:\n \tLookupTable gammaLut_;\n \tbool ccmEnabled_;\n \tDebayerParams params_;\n+\tSwIspStats statsBuffer_;\n \n \tdebayerFn debayer0_;\n \tdebayerFn debayer1_;\ndiff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 5c3011a7..23842f6c 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -182,14 +182,14 @@ static constexpr unsigned int kBlueYMul = 29; /* 0.114 * 256 */\n \tyVal = r * kRedYMul;               \\\n \tyVal += g * kGreenYMul;            \\\n \tyVal += b * kBlueYMul;             \\\n-\tstats_.yHistogram[yVal * SwIspStats::kYHistogramSize / (256 * 256 * (div))]++;\n+\tstats->yHistogram[yVal * SwIspStats::kYHistogramSize / (256 * 256 * (div))]++;\n \n #define SWSTATS_FINISH_LINE_STATS() \\\n-\tstats_.sum_.r() += sumR;    \\\n-\tstats_.sum_.g() += sumG;    \\\n-\tstats_.sum_.b() += sumB;\n+\tstats->sum_.r() += sumR;    \\\n+\tstats->sum_.g() += sumG;    \\\n+\tstats->sum_.b() += sumB;\n \n-void SwStatsCpu::statsBGGR8Line0(const uint8_t *src[])\n+void SwStatsCpu::statsBGGR8Line0(const uint8_t *src[], SwIspStats *stats)\n {\n \tconst uint8_t *src0 = src[1] + window_.x;\n \tconst uint8_t *src1 = src[2] + window_.x;\n@@ -214,7 +214,7 @@ void SwStatsCpu::statsBGGR8Line0(const uint8_t *src[])\n \tSWSTATS_FINISH_LINE_STATS()\n }\n \n-void SwStatsCpu::statsBGGR10Line0(const uint8_t *src[])\n+void SwStatsCpu::statsBGGR10Line0(const uint8_t *src[], SwIspStats *stats)\n {\n \tconst uint16_t *src0 = (const uint16_t *)src[1] + window_.x;\n \tconst uint16_t *src1 = (const uint16_t *)src[2] + window_.x;\n@@ -240,7 +240,7 @@ void SwStatsCpu::statsBGGR10Line0(const uint8_t *src[])\n \tSWSTATS_FINISH_LINE_STATS()\n }\n \n-void SwStatsCpu::statsBGGR12Line0(const uint8_t *src[])\n+void SwStatsCpu::statsBGGR12Line0(const uint8_t *src[], SwIspStats *stats)\n {\n \tconst uint16_t *src0 = (const uint16_t *)src[1] + window_.x;\n \tconst uint16_t *src1 = (const uint16_t *)src[2] + window_.x;\n@@ -266,7 +266,7 @@ void SwStatsCpu::statsBGGR12Line0(const uint8_t *src[])\n \tSWSTATS_FINISH_LINE_STATS()\n }\n \n-void SwStatsCpu::statsBGGR10PLine0(const uint8_t *src[])\n+void SwStatsCpu::statsBGGR10PLine0(const uint8_t *src[], SwIspStats *stats)\n {\n \tconst uint8_t *src0 = src[1] + window_.x * 5 / 4;\n \tconst uint8_t *src1 = src[2] + window_.x * 5 / 4;\n@@ -292,7 +292,7 @@ void SwStatsCpu::statsBGGR10PLine0(const uint8_t *src[])\n \tSWSTATS_FINISH_LINE_STATS()\n }\n \n-void SwStatsCpu::statsGBRG10PLine0(const uint8_t *src[])\n+void SwStatsCpu::statsGBRG10PLine0(const uint8_t *src[], SwIspStats *stats)\n {\n \tconst uint8_t *src0 = src[1] + window_.x * 5 / 4;\n \tconst uint8_t *src1 = src[2] + window_.x * 5 / 4;\n@@ -321,10 +321,13 @@ void SwStatsCpu::statsGBRG10PLine0(const uint8_t *src[])\n /**\n  * \\brief Reset state to start statistics gathering for a new frame\n  * \\param[in] frame The frame number\n+ * \\param[in] statsBuffer Array of buffers storing stats\n+ * \\param[in] statsBufferCount number of buffers in the statsBuffer array\n  *\n  * This may only be called after a successful setWindow() call.\n  */\n-void SwStatsCpu::startFrame(uint32_t frame)\n+void SwStatsCpu::startFrame(uint32_t frame,\n+\t\t\t    struct SwIspStats statsBuffer[], unsigned int statsBufferCount)\n {\n \tif (frame % kStatPerNumFrames)\n \t\treturn;\n@@ -332,21 +335,39 @@ void SwStatsCpu::startFrame(uint32_t frame)\n \tif (window_.width == 0)\n \t\tLOG(SwStatsCpu, Error) << \"Calling startFrame() without setWindow()\";\n \n-\tstats_.sum_ = RGB<uint64_t>({ 0, 0, 0 });\n-\tstats_.yHistogram.fill(0);\n+\tfor (unsigned int i = 0; i < statsBufferCount; i++) {\n+\t\tstatsBuffer[i].sum_ = RGB<uint64_t>({ 0, 0, 0 });\n+\t\tstatsBuffer[i].yHistogram.fill(0);\n+\t}\n }\n \n /**\n  * \\brief Finish statistics calculation for the current frame\n  * \\param[in] frame The frame number\n  * \\param[in] bufferId ID of the statistics buffer\n+ * \\param[in] statsBuffer Array of buffers storing stats\n+ * \\param[in] statsBufferCount number of buffers in the statsBuffer array\n  *\n  * This may only be called after a successful setWindow() call.\n  */\n-void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId)\n+void SwStatsCpu::finishFrame(uint32_t frame, uint32_t bufferId,\n+\t\t\t     struct SwIspStats statsBuffer[], unsigned int statsBufferCount)\n {\n-\tstats_.valid = frame % kStatPerNumFrames == 0;\n-\t*sharedStats_ = stats_;\n+\tif (frame % kStatPerNumFrames) {\n+\t\tsharedStats_->valid = false;\n+\t\tstatsReady.emit(frame, bufferId);\n+\t\treturn;\n+\t}\n+\n+\tsharedStats_->sum_ = RGB<uint64_t>({ 0, 0, 0 });\n+\tsharedStats_->yHistogram.fill(0);\n+\tfor (unsigned int i = 0; i < statsBufferCount; i++) {\n+\t\tsharedStats_->sum_ += statsBuffer[i].sum_;\n+\t\tfor (unsigned int j = 0; j < SwIspStats::kYHistogramSize; j++)\n+\t\t\tsharedStats_->yHistogram[j] += statsBuffer[i].yHistogram[j];\n+\t}\n+\n+\tsharedStats_->valid = true;\n \tstatsReady.emit(frame, bufferId);\n }\n \n@@ -487,7 +508,7 @@ void SwStatsCpu::setWindow(const Rectangle &window)\n \twindow_.height &= ~(patternSize_.height - 1);\n }\n \n-void SwStatsCpu::processBayerFrame2(MappedFrameBuffer &in)\n+void SwStatsCpu::processBayerFrame2(MappedFrameBuffer &in, SwIspStats *stats)\n {\n \tconst uint8_t *src = in.planes()[0].data();\n \tconst uint8_t *linePointers[3];\n@@ -504,7 +525,7 @@ void SwStatsCpu::processBayerFrame2(MappedFrameBuffer &in)\n \t\t/* linePointers[0] is not used by any stats0_ functions */\n \t\tlinePointers[1] = src;\n \t\tlinePointers[2] = src + stride_;\n-\t\t(this->*stats0_)(linePointers);\n+\t\t(this->*stats0_)(linePointers, stats);\n \t\tsrc += stride_ * 2;\n \t}\n }\n@@ -520,12 +541,14 @@ void SwStatsCpu::processBayerFrame2(MappedFrameBuffer &in)\n void SwStatsCpu::processFrame(uint32_t frame, uint32_t bufferId, FrameBuffer *input)\n {\n \tif (frame % kStatPerNumFrames) {\n-\t\tfinishFrame(frame, bufferId);\n+\t\tfinishFrame(frame, bufferId, NULL, 0);\n \t\treturn;\n \t}\n \n+\tSwIspStats stats;\n+\n \tbench_.startFrame();\n-\tstartFrame(frame);\n+\tstartFrame(frame, &stats, 1);\n \n \tMappedFrameBuffer in(input, MappedFrameBuffer::MapFlag::Read);\n \tif (!in.isValid()) {\n@@ -533,8 +556,8 @@ void SwStatsCpu::processFrame(uint32_t frame, uint32_t bufferId, FrameBuffer *in\n \t\treturn;\n \t}\n \n-\t(this->*processFrame_)(in);\n-\tfinishFrame(frame, bufferId);\n+\t(this->*processFrame_)(in, &stats);\n+\tfinishFrame(frame, bufferId, &stats, 1);\n \tbench_.finishFrame();\n }\n \n",
    "prefixes": [
        "1/5"
    ]
}