Patch Detail
Show a patch.
GET /api/1.1/patches/26153/?format=api
{ "id": 26153, "url": "https://patchwork.libcamera.org/api/1.1/patches/26153/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26153/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260213-kbingham-quantizers-v7-11-1626b9aaabf1@ideasonboard.com>", "date": "2026-02-13T16:57:50", "name": "[v7,11/15] ipa: mali-c55: Reduce AWB calculations to float precision", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dad72009d7a127545c0a6b7ff4f2c8dab5dcac4f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26153/mbox/", "series": [ { "id": 5789, "url": "https://patchwork.libcamera.org/api/1.1/series/5789/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5789", "date": "2026-02-13T16:57:39", "name": "libipa: Introduce a Quantized type", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5789/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26153/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26153/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C08C3C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Feb 2026 16:58:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9148062218;\n\tFri, 13 Feb 2026 17:58:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2D1F621E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Feb 2026 17:58:06 +0100 (CET)", "from ping.linuxembedded.co.uk\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D9E2926D2;\n\tFri, 13 Feb 2026 17:57:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DmdgzTwD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1771001837;\n\tbh=Q9+VDruAwbq/Vrlp4mVoSlDCP5Ct8bT4A2EKShmYdaM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=DmdgzTwDDGz19gnkYnSGNW3cznhYtWo9oKU8U88s3EH4FmLevtC6+oPVwKyaEt4oD\n\txK8spdqQSz+wGjwNJ0olCSlUvP/k6+vMoNobrIibGWju9BH2vdzUgcnKY8YCto00O3\n\t2Sf1yRjvdcKmojDD/NyBriJGCqEIp5BfooljSEls=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Date": "Fri, 13 Feb 2026 16:57:50 +0000", "Subject": "[PATCH v7 11/15] ipa: mali-c55: Reduce AWB calculations to float\n\tprecision", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260213-kbingham-quantizers-v7-11-1626b9aaabf1@ideasonboard.com>", "References": "<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>", "In-Reply-To": "<20260213-kbingham-quantizers-v7-0-1626b9aaabf1@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.3", "X-Developer-Signature": "v=1; a=ed25519-sha256; t=1771001883; l=2203;\n\ti=kieran.bingham@ideasonboard.com; s=20260207;\n\th=from:subject:message-id; \n\tbh=Q9+VDruAwbq/Vrlp4mVoSlDCP5Ct8bT4A2EKShmYdaM=;\n\tb=clqY5KiPe6xHHz5DTaL2Py+tXcJ3/aY+ry1sCoX1Lz+01iCLeV7ie5SqWtrxCMRfY6C6mZn2O\n\tT08wryi5LQOA3htISMoAZVJL0OaIg9p7gHRyUdiqmuKKnDxj3ghbucu", "X-Developer-Key": "i=kieran.bingham@ideasonboard.com; a=ed25519;\n\tpk=FVXKN7YuwHc6UtbRUeTMAmranfsQomA+vnilfglWdaY=", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AWB calculations are determined using double precision, and then\nwill be soon stored in a quantized float.\n\nUse float types for the intermediate types after the sums have been\nconverted to an average to remove static cast assignments.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv5:\n - New in v5\n---\n src/ipa/mali-c55/algorithms/awb.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/mali-c55/algorithms/awb.cpp b/src/ipa/mali-c55/algorithms/awb.cpp\nindex 964e810882a9..b179dd7f0c1c 100644\n--- a/src/ipa/mali-c55/algorithms/awb.cpp\n+++ b/src/ipa/mali-c55/algorithms/awb.cpp\n@@ -159,7 +159,7 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * Sometimes the first frame's statistics have no valid pixels, in which\n \t * case we'll just assume a grey world until they say otherwise.\n \t */\n-\tdouble rgAvg, bgAvg;\n+\tfloat rgAvg, bgAvg;\n \tif (!counted_zones) {\n \t\trgAvg = 1.0;\n \t\tbgAvg = 1.0;\n@@ -174,15 +174,15 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * figure by the gains that were applied when the statistics for this\n \t * frame were generated.\n \t */\n-\tdouble rRatio = rgAvg / frameContext.awb.rGain;\n-\tdouble bRatio = bgAvg / frameContext.awb.bGain;\n+\tfloat rRatio = rgAvg / frameContext.awb.rGain;\n+\tfloat bRatio = bgAvg / frameContext.awb.bGain;\n \n \t/*\n \t * And then we can simply invert the ratio to find the gain we should\n \t * apply.\n \t */\n-\tdouble rGain = 1 / rRatio;\n-\tdouble bGain = 1 / bRatio;\n+\tfloat rGain = 1 / rRatio;\n+\tfloat bGain = 1 / bRatio;\n \n \t/*\n \t * Running at full speed, this algorithm results in oscillations in the\n@@ -190,7 +190,7 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * changes in gain, unless we're in the startup phase in which case we\n \t * want to fix the miscolouring as quickly as possible.\n \t */\n-\tdouble speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n+\tfloat speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n \trGain = speed * rGain + context.activeState.awb.rGain * (1.0 - speed);\n \tbGain = speed * bGain + context.activeState.awb.bGain * (1.0 - speed);\n \n", "prefixes": [ "v7", "11/15" ] }