Patch Detail
Show a patch.
GET /api/1.1/patches/26141/?format=api
{ "id": 26141, "url": "https://patchwork.libcamera.org/api/1.1/patches/26141/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26141/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260212152850.3743004-1-laurent.pinchart@ideasonboard.com>", "date": "2026-02-12T15:28:50", "name": "android: camera_stream: Include <poll.h> instead of <sys/poll.h>", "commit_ref": "59be23f34e6b8668d391be5483df6dad15ed525e", "pull_url": null, "state": "accepted", "archived": false, "hash": "5b6ce4475808c955efacb8823dbd81cd3236415e", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26141/mbox/", "series": [ { "id": 5788, "url": "https://patchwork.libcamera.org/api/1.1/series/5788/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5788", "date": "2026-02-12T15:28:50", "name": "android: camera_stream: Include <poll.h> instead of <sys/poll.h>", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5788/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26141/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26141/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C90F4BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Feb 2026 15:28:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 052E5621D7;\n\tThu, 12 Feb 2026 16:28:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64A5862181\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Feb 2026 16:28:52 +0100 (CET)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2F42F492\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Feb 2026 16:28:04 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SdSFNH+Y\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770910084;\n\tbh=baCJY6MB7KOo45me6DaQ89pfAm2GtcFnu6YAV3Wil0Q=;\n\th=From:To:Subject:Date:From;\n\tb=SdSFNH+YBCSHNA1qBaVzDV+L4GzMoWPS3vm6OsaygUpJmN2v0KtEuvIHUO5p74pN9\n\tRD7IByaiJSDp9XD4KhnfzizrQ7/0Dk7KfFY9GwcGhYlfa948Bk5+rBMU2D0Swh98FF\n\t/dXuoMLinyNIZOR9fhUM3wDqaRAbIMKrAzTWK+2g=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] android: camera_stream: Include <poll.h> instead of\n\t<sys/poll.h>", "Date": "Thu, 12 Feb 2026 17:28:50 +0200", "Message-ID": "<20260212152850.3743004-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The standard C library header for the poll() API is poll.h, not\nsys/poll.h. The musl C library warns about this:\n\nIn file included from src/android/camera_stream.cpp:13:\nhost/i586-buildroot-linux-musl/sysroot/usr/include/sys/poll.h:1:2: error: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Werror=cpp]\n 1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>\n | ^~~~~~~\n\nFix it by including the correct header.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/android/camera_stream.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 1dcf9957a47fb54fce4fbae9daec0b587e52562e", "diff": "diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 1d68540d7e50..7da01dc30031 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -8,9 +8,9 @@\n #include \"camera_stream.h\"\n \n #include <errno.h>\n+#include <poll.h>\n #include <string.h>\n #include <sys/mman.h>\n-#include <sys/poll.h>\n #include <unistd.h>\n \n #include <libcamera/formats.h>\n", "prefixes": [] }