Patch Detail
Show a patch.
GET /api/1.1/patches/26106/?format=api
{ "id": 26106, "url": "https://patchwork.libcamera.org/api/1.1/patches/26106/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26106/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260208174450.416314-4-rui.wang@ideasonboard.com>", "date": "2026-02-08T17:44:49", "name": "[v1,3/4] ipa: rkisp1: dpf: Report DPF configuration in metadata", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f629eba846fe425c3387f23842ada8231b7b1de1", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26106/mbox/", "series": [ { "id": 5777, "url": "https://patchwork.libcamera.org/api/1.1/series/5777/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5777", "date": "2026-02-08T17:44:46", "name": "dpf_manual_patch_v1", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5777/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26106/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26106/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 257FFC32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 8 Feb 2026 17:45:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A86FB620E1;\n\tSun, 8 Feb 2026 18:45:50 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A91826209C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 8 Feb 2026 18:45:45 +0100 (CET)", "from rui-Precision-7560.tail5b760b.ts.net (unknown\n\t[209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB57C16AE;\n\tSun, 8 Feb 2026 18:44:59 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ln7tv3TR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1770572700;\n\tbh=YQePkAKvhcHED6tBDFRhHRcfhr9Wk5UlqB7GdP2lgWI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ln7tv3TRkpQDPJ72JRLdrnIj05qWG2OLdoooUnTJDqBGZEe66BVtJlIjMiH7M5XbY\n\tIwLZYSSnoz36+OJ2hxkaoSYK0exiy2gvngxmCTP7eiwggXPNzcrCAViF1/ncPKf65y\n\tJFVCC7O4G9HTU6RwIyQK/44R6iFq5CNvmtUTA1nw=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v1 3/4] ipa: rkisp1: dpf: Report DPF configuration in\n\tmetadata", "Date": "Sun, 8 Feb 2026 12:44:49 -0500", "Message-ID": "<20260208174450.416314-4-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20260208174450.416314-1-rui.wang@ideasonboard.com>", "References": "<20260208174450.416314-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "- Populate the request metadata with the current DPF configuration values.\n- Including channel strengths, spatial coefficients, filter sizes, and\n noise level lookup table parameters. This allows applications to inspect\n the state of the DPF algorithm for each frame.\n- The metadata post only after controls are initilized\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 42 +++++++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/dpf.h | 6 +++++\n 2 files changed, 48 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex c232f2ad..174c4160 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -551,6 +551,48 @@ bool Dpf::parseControls(const ControlList &controls)\n \treturn true;\n }\n \n+void Dpf::fillMetadata([[maybe_unused]] IPAContext &context, [[maybe_unused]] IPAFrameContext &frameContext, ControlList &metadata)\n+{\n+\t/* Strength (R,G,B) */\n+\tstd::array<int32_t, 3> strength{ activeMode_->strength.r, activeMode_->strength.g, activeMode_->strength.b };\n+\tmetadata.set(controls::rkisp1::DpfChannelStrengths, Span<const int32_t, 3>(strength));\n+\n+\t/* Spatial kernels */\n+\tstd::array<int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS> greenCoeffs;\n+\tstd::copy(std::begin(activeMode_->dpf.g_flt.spatial_coeff), std::end(activeMode_->dpf.g_flt.spatial_coeff), greenCoeffs.begin());\n+\tmetadata.set(controls::rkisp1::DpfGreenSpatialCoefficients,\n+\t\t Span<const int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS>(greenCoeffs));\n+\n+\tstd::array<int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS> redBlueCoeffs;\n+\tstd::copy(std::begin(activeMode_->dpf.rb_flt.spatial_coeff), std::end(activeMode_->dpf.rb_flt.spatial_coeff), redBlueCoeffs.begin());\n+\tmetadata.set(controls::rkisp1::DpfRedBlueSpatialCoefficients,\n+\t\t Span<const int32_t, RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS>(redBlueCoeffs));\n+\n+\tmetadata.set(controls::rkisp1::DpfRedBlueFilterSize,\n+\t\t static_cast<int32_t>(activeMode_->dpf.rb_flt.fltsize));\n+\n+\t/* NLL coefficients and scale */\n+\tstd::array<int32_t, RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS> nllCoeffs;\n+\tstd::copy(std::begin(activeMode_->dpf.nll.coeff), std::end(activeMode_->dpf.nll.coeff), nllCoeffs.begin());\n+\tmetadata.set(controls::rkisp1::DpfNoiseLevelLookupCoefficients,\n+\t\t Span<const int32_t, RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS>(nllCoeffs));\n+\tmetadata.set(controls::rkisp1::DpfNoiseLevelLookupScaleMode, activeMode_->dpf.nll.scale_mode);\n+}\n+\n+/**\n+ * \\copydoc libcamera::ipa::Algorithm::process\n+ */\n+void Dpf::process(IPAContext &context, const uint32_t frame [[maybe_unused]],\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats [[maybe_unused]],\n+\t\t ControlList &metadata)\n+{\n+\tif (noiseReductionModes_.empty())\n+\t\treturn;\n+\n+\tfillMetadata(context, frameContext, metadata);\n+}\n+\n REGISTER_IPA_ALGORITHM(Dpf, \"Dpf\")\n \n } /* namespace ipa::rkisp1::algorithms */\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex e3dea97b..62f5e2f7 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -28,6 +28,10 @@ public:\n \tvoid prepare(IPAContext &context, const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\n \t\t RkISP1Params *params) override;\n+\tvoid process(IPAContext &context, const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t const rkisp1_stat_buffer *stats,\n+\t\t ControlList &metadata) override;\n \n private:\n \tstruct ModeConfig {\n@@ -51,6 +55,8 @@ private:\n \tvoid prepareDisabledMode(RkISP1Params *params);\n \tvoid prepareEnabledMode(IPAContext &context, IPAFrameContext &frameContext,\n \t\t\t\tRkISP1Params *params);\n+\tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n+\t\t\t ControlList &metadata);\n \n \tstd::vector<ModeConfig> noiseReductionModes_;\n \tstd::vector<ModeConfig>::const_iterator activeMode_;\n", "prefixes": [ "v1", "3/4" ] }