Patch Detail
Show a patch.
GET /api/1.1/patches/26027/?format=api
{ "id": 26027, "url": "https://patchwork.libcamera.org/api/1.1/patches/26027/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26027/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128162649.3263861-1-laurent.pinchart@ideasonboard.com>", "date": "2026-01-28T16:26:49", "name": "libcamera: yaml_parser: Fix uninitialized variable warning", "commit_ref": "67fd7d720b4845a22d3e97009212d20cd22df83d", "pull_url": null, "state": "accepted", "archived": false, "hash": "89c930c1536863b08c483f561f169fd063577f86", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26027/mbox/", "series": [ { "id": 5752, "url": "https://patchwork.libcamera.org/api/1.1/series/5752/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5752", "date": "2026-01-28T16:26:49", "name": "libcamera: yaml_parser: Fix uninitialized variable warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5752/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26027/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26027/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23D48C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 16:26:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65D0E61FD0;\n\tWed, 28 Jan 2026 17:26:53 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF7D061FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 17:26:51 +0100 (CET)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 768F8E70\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 17:26:14 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LfZTvphp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769617574;\n\tbh=KL9Rxa/g40CTGkUb2NJ47B2Ahpmt6xszy4Zg3ycVDj8=;\n\th=From:To:Subject:Date:From;\n\tb=LfZTvphpwYqLKhaLH0FGOqIsLlCVcG4EfpIOAJINrj063T+akktiUgi5PUHQdmgB7\n\t3184RgY7rORb5jZ3xzb1q29ked8mKEJShiPfZeMwiNWVrAurCnkCMiycv5qdy4UEh8\n\tB6rgPQDVlhLaZEFZuAN+Sy/tYPcFMZVBFN/p7KzM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] libcamera: yaml_parser: Fix uninitialized variable warning", "Date": "Wed, 28 Jan 2026 18:26:49 +0200", "Message-ID": "<20260128162649.3263861-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "gcc 14.3.0, cross-compiling from amd64 to arm64, warns about a possibly\nuninitialized variable in YamlObject::Getter<>::get():\n\nIn file included from ../../include/libcamera/internal/yaml_parser.h:12,\n from ../../src/libcamera/yaml_parser.cpp:8:\nIn constructor ‘constexpr std::_Optional_payload_base<_Tp>::_Storage<_Up, <anonymous> >::_Storage(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}; _Up = unsigned char; bool <anonymous> = true; _Tp = unsigned char]’,\n inlined from ‘constexpr std::_Optional_payload_base<_Tp>::_Optional_payload_base(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}; _Tp = unsigned char]’ at include/c++/14.3.0/optional:122:4,\n inlined from ‘constexpr std::_Optional_payload<unsigned char, true, true, true>::_Optional_payload(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}][inherited from std::_Optional_payload_base<unsigned char>]’ at include/c++/14.3.0/optional:337:42,\n inlined from ‘constexpr std::_Optional_base<_Tp, true, true>::_Optional_base(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}; typename std::enable_if<is_constructible_v<_Tp, _Args ...>, bool>::type <anonymous> = false; _Tp = unsigned char]’ at include/c++/14.3.0/optional:648:4,\n inlined from ‘constexpr std::optional<_Tp>::optional(_Up&&) [with _Up = unsigned char; typename std::enable_if<__and_v<std::__not_<std::is_same<std::optional<_Tp>, typename std::remove_cv<typename std::remove_reference<_Up>::type>::type> >, std::__not_<std::is_same<std::in_place_t, typename std::remove_cv<typename std::remove_reference<_Up>::type>::type> >, std::is_constructible<_T1, _U1>, std::is_convertible<_Iter, _Iterator> >, bool>::type <anonymous> = true; _Tp = unsigned char]’ at include/c++/14.3.0/optional:747:47,\n inlined from ‘std::optional<_Tp> libcamera::YamlObject::Getter<T, typename std::enable_if<(((((is_same_v<signed char, T> || is_same_v<unsigned char, T>) || is_same_v<short int, T>) || is_same_v<short unsigned int, T>) || is_same_v<int, T>) || is_same_v<unsigned int, T>), void>::type>::get(const libcamera::YamlObject&) const [with T = unsigned char]’ at ../../src/libcamera/yaml_parser.cpp:172:10:\ninclude/c++/14.3.0/optional:210:15: error: ‘value’ may be used uninitialized [-Werror=maybe-uninitialized]\n 210 | : _M_value(std::forward<_Args>(__args)...)\n | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n../../src/libcamera/yaml_parser.cpp: In member function ‘std::optional<_Tp> libcamera::YamlObject::Getter<T, typename std::enable_if<(((((is_same_v<signed char, T> || is_same_v<unsigned char, T>) || is_same_v<short int, T>) || is_same_v<short unsigned int, T>) || is_same_v<int, T>) || is_same_v<unsigned int, T>), void>::type>::get(const libcamera::YamlObject&) const [with T = unsigned char]’:\n../../src/libcamera/yaml_parser.cpp:165:19: note: ‘value’ was declared here\n 165 | T value;\n | ^~~~~\n\nThis appears to be a false positive, as the std::from_chars() function\nshould set value when it returns without an error. Commit bb1d216113bc\n(\"libcamera: base: log: Fix uninitialized variable warning\") fixed a\nsimilar warning with gcc 13.3.0.\n\nThe warning is easy to work around by initializing the variable, and\ndoing so shouldn't be too costly as the type T is restricted to being an\ninteger. Fix the build by doing so.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/yaml_parser.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 186e5cf9ac74cc495384c0af5a055c33a43d9ecc", "diff": "diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp\nindex a5e424615c26..e13b5faedd81 100644\n--- a/src/libcamera/yaml_parser.cpp\n+++ b/src/libcamera/yaml_parser.cpp\n@@ -162,7 +162,7 @@ struct YamlObject::Getter<T, std::enable_if_t<\n \t\t\treturn std::nullopt;\n \n \t\tconst std::string &str = obj.value_;\n-\t\tT value;\n+\t\tT value = {};\n \n \t\tauto [ptr, ec] = std::from_chars(str.data(), str.data() + str.size(),\n \t\t\t\t\t\t value);\n", "prefixes": [] }