Patch Detail
Show a patch.
GET /api/1.1/patches/26009/?format=api
{ "id": 26009, "url": "https://patchwork.libcamera.org/api/1.1/patches/26009/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26009/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128124011.104617-1-kieran.bingham@ideasonboard.com>", "date": "2026-01-28T12:40:11", "name": "apps: qcam: Disable -Wsfinae-incomplete", "commit_ref": "aa2a0812e6692a29a161b6790a520ba8076347f8", "pull_url": null, "state": "accepted", "archived": false, "hash": "40ae1ff66c66b236a448d388460872e5920f3760", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26009/mbox/", "series": [ { "id": 5749, "url": "https://patchwork.libcamera.org/api/1.1/series/5749/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5749", "date": "2026-01-28T12:40:11", "name": "apps: qcam: Disable -Wsfinae-incomplete", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5749/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26009/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26009/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01F85C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 12:40:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10DDA61FD0;\n\tWed, 28 Jan 2026 13:40:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 81A4261FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 13:40:16 +0100 (CET)", "from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78DDF73B;\n\tWed, 28 Jan 2026 13:39:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hL53MEcC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769603979;\n\tbh=NAvmrtswaN0R3VXKkBEEF1fZKgaG5pNpxOtCc7sXMPU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=hL53MEcCUkxdRmo2GPexCBVz2sqY0uJZ4nQPDA+MNABv3z4dMgj3hdLttkeUAx4mt\n\t12SjG7dbMY1cd5zUpXQN3N49RkMYNukNq9kH5DfepzZwaVwghz9xraq5q1CghXrINx\n\t0q8GnVa+DytYTk3CUOMlS27MK4KN+JjopycdNgOI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] apps: qcam: Disable -Wsfinae-incomplete", "Date": "Wed, 28 Jan 2026 12:40:11 +0000", "Message-ID": "<20260128124011.104617-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "GCC-16 has updated the warnings enabled and now includes\n-Wsfinae-incomplete triggering breakage in the included headers from\nQt6:\n\n/usr/include/qt6/QtCore/qregularexpression.h:31:21: error: defining ‘QRegularExpression’, which previously failed to be complete in a SFINAE context [-Werror=sfinae-incomplete=]\n\nThis is a Qt header issue outside of libcamera’s control. Disable the\nwarning for qcam to restore buildability with newer GCC versions.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nI see there's a conditional section to only disable some warnings for\nspecific versions, but I have no indication here as to when or if this\nwarning will be fixed - so I've chosen to just put it directly into the\nmain flags to disable the warning.\n\nIt's out side of our control, and doesn't impact what we can do.\n\n src/apps/qcam/meson.build | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build\nindex 33600095ff9d..8eb815eed863 100644\n--- a/src/apps/qcam/meson.build\n+++ b/src/apps/qcam/meson.build\n@@ -40,6 +40,7 @@ qt6_cpp_args = [\n apps_cpp_args,\n '-DQT_NO_KEYWORDS',\n '-Wno-extra-semi',\n+ '-Wno-sfinae-incomplete',\n ]\n \n # gcc 12 and 13 output a false positive variable shadowing warning with Qt\n", "prefixes": [] }