Patch Detail
Show a patch.
GET /api/1.1/patches/26003/?format=api
{ "id": 26003, "url": "https://patchwork.libcamera.org/api/1.1/patches/26003/?format=api", "web_url": "https://patchwork.libcamera.org/patch/26003/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128114402.31570-11-mzamazal@redhat.com>", "date": "2026-01-28T11:43:57", "name": "[v5,10/15] libcamera: ipa: simple: Apply gain matrix in awb", "commit_ref": "da0926bc4b2dc28599ee2000ee9fb375b38d4f9e", "pull_url": null, "state": "accepted", "archived": false, "hash": "955fa1a27cc547a52c3cbcd619941741fe7eedaf", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/26003/mbox/", "series": [ { "id": 5748, "url": "https://patchwork.libcamera.org/api/1.1/series/5748/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5748", "date": "2026-01-28T11:43:47", "name": "Simple pipeline IPA cleanup", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5748/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/26003/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/26003/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CBD4C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 11:44:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E143F61FF5;\n\tWed, 28 Jan 2026 12:44:42 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 432B361FD0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 12:44:38 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-107-BUlrdB8lPtOFaR51RXB70A-1;\n\tWed, 28 Jan 2026 06:44:33 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 80EE51955D98; Wed, 28 Jan 2026 11:44:32 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A315A19560B2; Wed, 28 Jan 2026 11:44:30 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"fWyfLU0F\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769600677;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tXFgft+XYVjSa8lYqVP+B3fdcH9cDd+ABLYCY2ZVagY=;\n\tb=fWyfLU0Fm7iIGmKCUGUSJOjJbOY1dT6COMMZt/o4ggouK1VNbqM4V8hG18V1zolW6ngNXd\n\tIJvAwd/8TlabbCxehVSzsI9nUwnTQBeBiMtQH5kTM7Hga/a5o+hDYIO9jdB6dt3UWNDUri\n\tRADDK8xJsXWib4qSJ5eAwZ+9gCW4Qdk=", "X-MC-Unique": "BUlrdB8lPtOFaR51RXB70A-1", "X-Mimecast-MFC-AGG-ID": "BUlrdB8lPtOFaR51RXB70A_1769600672", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tRobert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v5 10/15] libcamera: ipa: simple: Apply gain matrix in awb", "Date": "Wed, 28 Jan 2026 12:43:57 +0100", "Message-ID": "<20260128114402.31570-11-mzamazal@redhat.com>", "In-Reply-To": "<20260128114402.31570-1-mzamazal@redhat.com>", "References": "<20260128114402.31570-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "mcPPp43coS6v17ZFt7bYTfiGt6cr7TKxkDIRiz_n5HU_1769600672", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Now, when we have a combined matrix, we can apply AWB gains to it\ndirectly in awb.cpp.\n\nReviewed-by: Robert Mader <robert.mader@collabora.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 5 +++++\n src/ipa/simple/algorithms/lut.cpp | 5 +----\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 18d97f707..31726658a 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -40,6 +40,11 @@ void Awb::prepare(IPAContext &context,\n \t\t [[maybe_unused]] DebayerParams *params)\n {\n \tauto &gains = context.activeState.awb.gains;\n+\tMatrix<float, 3, 3> gainMatrix = { { gains.r(), 0, 0,\n+\t\t\t\t\t 0, gains.g(), 0,\n+\t\t\t\t\t 0, 0, gains.b() } };\n+\tcontext.activeState.combinedMatrix =\n+\t\tcontext.activeState.combinedMatrix * gainMatrix;\n \t/* Just report, the gains are applied in LUT algorithm. */\n \tframeContext.gains.red = gains.r();\n \tframeContext.gains.blue = gains.b();\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 9740f8c8d..d8e92c613 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -107,10 +107,7 @@ void Lut::prepare(IPAContext &context,\n \t\t\tparams->blue[i] = gammaTable[static_cast<unsigned int>(lutGains.b())];\n \t\t}\n \t} else if (context.activeState.matrixChanged || gammaUpdateNeeded) {\n-\t\tMatrix<float, 3, 3> gainMatrix = { { gains.r(), 0, 0,\n-\t\t\t\t\t\t 0, gains.g(), 0,\n-\t\t\t\t\t\t 0, 0, gains.b() } };\n-\t\tauto matrix = context.activeState.combinedMatrix * gainMatrix;\n+\t\tauto &matrix = context.activeState.combinedMatrix;\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\n", "prefixes": [ "v5", "10/15" ] }