Patch Detail
Show a patch.
GET /api/1.1/patches/25957/?format=api
{ "id": 25957, "url": "https://patchwork.libcamera.org/api/1.1/patches/25957/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25957/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260126085747.36043-2-barnabas.pocze@ideasonboard.com>", "date": "2026-01-26T08:57:47", "name": "[libcamera-ci,v2,2/2] Update virtme-ng to 1.40", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1aa4aafbdeb4649c4b8de29eb19e1e9197460725", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25957/mbox/", "series": [ { "id": 5738, "url": "https://patchwork.libcamera.org/api/1.1/series/5738/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5738", "date": "2026-01-26T08:57:46", "name": "[libcamera-ci,v2,1/2] Move kvm tests and cross compilation to debian 13", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5738/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25957/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25957/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8FFAC328D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Jan 2026 08:57:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F8C661FC4;\n\tMon, 26 Jan 2026 09:57:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 925F961FBB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Jan 2026 09:57:51 +0100 (CET)", "from pb-laptop.local (185.221.142.123.nat.pool.zt.hu\n\t[185.221.142.123])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2289463F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Jan 2026 09:57:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s+Xo2ZH1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769417836;\n\tbh=W4oVy3iCc+iAM/HHT00BybWKNhl4Llj46VS7s5yEMVo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=s+Xo2ZH17kRFxZjdVh0HAbqfg7h7Ewzx+kv32cD5wElXpbQRLtjlII2gP5wEa1sLt\n\tjoEoo7tz+uKShwdSelBj9zZ5fWwTceS3Vrzp0zj6MUxGhJk8iG9ujM3cH0lHoiLMOv\n\tGmoxtcs3/pNzTAgsYWAn4QHnIYiTARi/QM7AlETU=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [PATCH v2 2/2] Update virtme-ng to 1.40", "Date": "Mon, 26 Jan 2026 09:57:47 +0100", "Message-ID": "<20260126085747.36043-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260126085747.36043-1-barnabas.pocze@ideasonboard.com>", "References": "<20260126085747.36043-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This enables the removal of the exit code workaround since the exit code is\nnow propagated to the host[0]. However, the single argument `--rwdir` does\nnot work as it did in 1.18, and the `<path>=<path>` form must be used\notherwise virtme-ng refuses to start[1]:\n\n error: cannot initialize <path> inside the guest (path must be defined inside a valid overlay)\n\nAnd moreover, since virtme-ng now creates an overlay for `/tmp` by default[2],\nand some tests require a /tmp with `O_TMPFILE` support, `/tmp` needs to be\nmounted as tmpfs before running the tests.\n\n[0]: https://github.com/arighi/virtme-ng/pull/61\n[1]: https://github.com/arighi/virtme-ng/issues/409\n[2]: https://github.com/arighi/virtme-ng/pull/114\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nchanges in v2:\n * move virtme-ng update to a separate commit\n * use `--rwdir x=x` instead of `--overlay-rwdir`\n * I created and referenced https://github.com/arighi/virtme-ng/issues/409\n because I don't really understand why the 1.18 behaviour was changed\n\nv1: https://patchwork.libcamera.org/patch/25942/\n---\n .gitlab-ci/test-lc-compliance.sh | 6 ++----\n .gitlab-ci/test-libcamera-qemu.sh | 11 +++++++----\n gitlab-ci.yml | 2 +-\n 3 files changed, 10 insertions(+), 9 deletions(-)\n\n--\n2.52.0", "diff": "diff --git a/.gitlab-ci/test-lc-compliance.sh b/.gitlab-ci/test-lc-compliance.sh\nindex 6208723..a888cae 100755\n--- a/.gitlab-ci/test-lc-compliance.sh\n+++ b/.gitlab-ci/test-lc-compliance.sh\n@@ -14,7 +14,7 @@ libcamera_compliance() {\n \t\t--verbose \\\n \t\t--skip-modules \\\n \t\t--force-9p \\\n-\t\t--rwdir \"$PWD/build\" \\\n+\t\t--rwdir \"$PWD/build=$PWD/build\" \\\n \t\t--run /opt/linux/bzImage \\\n \t\t--exec \" \\\n \t\t\tset -x; \\\n@@ -25,12 +25,10 @@ libcamera_compliance() {\n \t\t\tUBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 \\\n \t\t\tGTEST_OUTPUT=xml:./build/lc-compliance-report.xml \\\n \t\t\tlc-compliance -c Virtual0; \\\n-\t\t\techo \\\\\\$? > ./build/.test-status; \\\n \t\t\"\n\n-\tlocal status=$(cat build/.test-status)\n+\tlocal status=$?\n \techo \"Test result exit state: $status\"\n-\trm build/.test-status\n\n \tif [[ $status != 0 ]] ; then\n \t\texit $status\ndiff --git a/.gitlab-ci/test-libcamera-qemu.sh b/.gitlab-ci/test-libcamera-qemu.sh\nindex f9de5ab..03d39d3 100755\n--- a/.gitlab-ci/test-libcamera-qemu.sh\n+++ b/.gitlab-ci/test-libcamera-qemu.sh\n@@ -24,13 +24,16 @@ libcamera_unit_test() {\n \techo \"Running libcamera tests in a qemu VM\"\n\n \tvirtme-ng --verbose --skip-modules --force-9p \\\n-\t\t--rwdir \"$PWD/build\" \\\n+\t\t--rwdir \"$PWD/build=$PWD/build\" \\\n \t\t--run /opt/linux/bzImage \\\n-\t\t--exec \"meson test -C build --no-rebuild --print-errorlogs; echo \\\\\\$? > build/.test-status\"\n+\t\t--exec \" \\\n+\t\t\tset -ex; \\\n+\t\t\tmount -t tmpfs tmpfs /tmp/; \\\n+\t\t\tmeson test -C build --no-rebuild --print-errorlogs; \\\n+\t\t\"\n\n-\tlocal status=$(cat build/.test-status)\n+\tlocal status=$?\n \techo \"Test result exit state: $status\"\n-\trm build/.test-status\n\n \tif [[ $status != 0 ]] ; then\n \t\texit $status\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex bd5df66..3f80cb8 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -34,7 +34,7 @@ variables:\n ca-certificates\n git\n VIRTME_GIT_URL: 'https://github.com/arighi/virtme-ng.git'\n- VIRTME_GIT_REF: 'v1.18'\n+ VIRTME_GIT_REF: 'v1.40'\n\n # Jobs that test individual commits need more history to find the common\n # ancestor of the branch being tested and the default branch. Fetch up to 100\n", "prefixes": [ "libcamera-ci", "v2", "2/2" ] }