Patch Detail
Show a patch.
GET /api/1.1/patches/25955/?format=api
{ "id": 25955, "url": "https://patchwork.libcamera.org/api/1.1/patches/25955/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25955/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260123125903.2469016-2-julien.vuillaumier@nxp.com>", "date": "2026-01-23T12:59:03", "name": "[v2,1/1] libcamera: camera_sensor: Fix imageStream() for CameraSensorLegacy class", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "274f0dbb9b78d000c52e9664bb9918cc0e09d8bf", "submitter": { "id": 190, "url": "https://patchwork.libcamera.org/api/1.1/people/190/?format=api", "name": "Julien Vuillaumier", "email": "julien.vuillaumier@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25955/mbox/", "series": [ { "id": 5737, "url": "https://patchwork.libcamera.org/api/1.1/series/5737/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5737", "date": "2026-01-23T12:59:02", "name": "libcamera: camera_sensor: Fix imageStream() for CameraSensorLegacy class", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5737/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25955/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25955/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A3BCBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Jan 2026 12:59:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D03F61FCB;\n\tFri, 23 Jan 2026 13:59:45 +0100 (CET)", "from DU2PR03CU002.outbound.protection.outlook.com\n\t(mail-northeuropeazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c200::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94BAC61FBB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Jan 2026 13:59:43 +0100 (CET)", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)\n\tby GVXPR04MB11690.eurprd04.prod.outlook.com (2603:10a6:150:2e5::5)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.11;\n\tFri, 23 Jan 2026 12:59:42 +0000", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::b387:72c6:e33c:8656]) by\n\tAM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::b387:72c6:e33c:8656%7]) with mapi id 15.20.9542.009;\n\tFri, 23 Jan 2026 12:59:42 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"lqcnFaew\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=WZytnqg6FS0KxrDMWfPczy+N8tpZC2XEOFR23vHaFIkYGwPTsdB40Ob8qSdU5/y8Gbmy/Bq56PZL0TjAIWzFxBxlx48NickSdtyfENrdh0KJvtWmDi/bYHWCWrudthaUBrRtDAMThanYWFzlQJaZCuLjmxZIPiWlfPl+ZXlQl9Pmh+8aNuZB3ggh+p4FS2HJ5pnS3dLWzo4uc22zS6ML6+MIvCq0DTnH5uDS5CnOinq2pLen7tCaTVcvjNljldFCFzJ93VyUOSUg1yousoZ8lg1txgIr3TrVNWZ6Gl6SVH7ttr/s5AP0MosYIhq5siuObpJQ2G2PndiHEbRu4kt+uA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=XzMDiKtbhoV3YKgamfso7Tx+JNJTdnnkTdMpjeOGLf8=;\n\tb=GnkCJKXVzSNXbH6saseNqT0zruQISywtOBfOlMg91rTjamBQppkPyv66QKmh97JCkDQVkIrJxaz7aYyEq/rxnCdqAZiJirH0N8+zI6bCooBj3bsYtxmLCuHmfj/JnwN9qmMsUx55usqzeQV3LD5XJtT+w6dGs76dPHdVKHjS5jhfZod3FvfNAmVEkNXLhALotnrm1jStbe5H3sD0iUqZAM6SLQ4iNoQbYnBIRk4wq7RkTiKmy0QGgwXdWIPt88srs+T4q7RkV1oDjs/eHyeSXkb4tz9LaWljjV7v48wY4RSKz/9U01UKissV7YN6a/t1KITLXc1Ba/1Qp/lA42u9JQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=XzMDiKtbhoV3YKgamfso7Tx+JNJTdnnkTdMpjeOGLf8=;\n\tb=lqcnFaewQNjOHllyp0klGFY7Fn/Wl6BzqvjMW0ryCfmozjQzgxu5SEOKEHmrwYEE+AjOMgEAFwG4Sp+duZhshs8oFkQxODpuP3kbWeIEwoQPijzfDEgpuvz1JO5d77qqtF93R5NRnnUlmVUv6huoF/wfgNGY/AfpsZ7/21CJjkSXGhxcZmPWWdUzLx0ZiBl2Hk9p3xWa+A9/1ey+BRFyXIyhwMriAlPAs1eYi3WZmA59lysZMwEgm1DsSEztQIdEsWQZNNb3MatM04Zy4vJR5Cjvhw1MWFbNDNcVUYAEmpWIrvV7tIxd+c7ihvSMHrv2rjHnIJhJdIN7hPp3yTt5Mw==", "From": "Julien Vuillaumier <julien.vuillaumier@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Julien Vuillaumier <julien.vuillaumier@nxp.com>", "Subject": "[PATCH v2 1/1] libcamera: camera_sensor: Fix imageStream() for\n\tCameraSensorLegacy class", "Date": "Fri, 23 Jan 2026 13:59:03 +0100", "Message-Id": "<20260123125903.2469016-2-julien.vuillaumier@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260123125903.2469016-1-julien.vuillaumier@nxp.com>", "References": "<20260123125903.2469016-1-julien.vuillaumier@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AS4P189CA0069.EURP189.PROD.OUTLOOK.COM\n\t(2603:10a6:20b:659::7) To AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM9PR04MB8147:EE_|GVXPR04MB11690:EE_", "X-MS-Office365-Filtering-Correlation-Id": "33c9dd89-0ced-402e-950a-08de5a7f4645", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|19092799006|1800799024|366016|52116014|376014|38350700014;", "X-Microsoft-Antispam-Message-Info": "86mRlxpP8iO0aUbp3raCsZe+Km9ApfeKoxmx8SoD00lNNKbBckcKlaMzzzlsuhUd2wwWXrdaqWGixg7cIArkVj1d0GDofPoRZXeA34j8GivdcgBin/spdot93lb3Afb5AS+8Y2jXUPmp5hfe8gzDFmbS8PfJpstfMo2eDtksfH6/A4oVoew7ADIFg+cYeYqRPDEUSpEpanXX+1NnzMTG/p2x3jHy5Fp32bnrL5+a3vgw+l4yO9x/bnqXeyOVw7qyngnu5HUNnZEyW9j/BqAz+6RGVLYP/w7WZwyLC1fWP/DKzJl/KZFNSnRNBrha9LlSlVlq/gJRpW1BzUaZgW3O029Y8nLOaMQw0SBIf/KNzfaDuEMIVy0OhlwQw4vcPfLTWn3XrguPF2QCDC4xBxNHTc7LmsJSRL4iisHj1Vmv2Fi8qn6mfC/aIcZIFgsYDcj3COhvhWIK4/5AiVK5+Ti3UErGGcQjP2CNb0q+D8JDujB53Voaw9NgbdXbQkolM1iGCe7Uz/ifW5n8uUZyh0b1APMIGK+rXVeWZSGvY98dI7qflgMc2vlRkuuTkKLjUfyF1ktrR9CQKaZ9chmA6GuTLhFK1pQGq0MCDRn2uVdlC5xyokzKaA0lK8OeYk+tKbIgMj/wJHkrZNpfAw9GG1bhtdySHWrmDhHfdZLSlnEE6lzT2xjARuh++VL+ajwX7zW0cNtA5yOm2j78wGW+dreF4CuBgOEy7q+VjbUgv8DH76HWCIi4JUt9RgYJaLgX8CTQhxQQA0ySnhL+WgL50QI4wOXYTvOeQlv07F7viA3NCe+Z381h/1gzg5CHyHf+XiozDyFk3J+SNKrUpIlcEPVTi8D6F0iIbHO9XMmwoCMJYXnZhCCLEK4gkOpkahRQ7GI1sxoz6MhVBsLCB+0CDVAEYpt+UcoHWcftDXE1Ces/3hmNNSjwWmdwMM6mnVK39DZb1ST/v+WSn/HaGpUkMhZby+/ThowuhzorMQ4LL19B5EZ1th/bzhIuwEgx3oePqTFgJXmF78Nd+4/UfO8d5cKv4gIQQD0HVw4N46AM1nUAb+uzIkLa0xehdmLTD3pepKpxihova4i93fjUQA9n1osOfgTnPktDv2+Fqv2d4UBvQs4luVjLZcT+My0W+zgEbx8k75gUoZqDp3Fwu9zyHVLdLmpGXDvyOC//h62IFtQpyTS1H1ySNGt46gb5W5ojOfJ1uw7jtCZf4higtIRYcheEWfG+YtkK1kMzc2wg0OGgVreHo+rTdyXOAGUE3jwf9YqBIHg8WeO7Vv8BVcdqrG1Zx34tZZdNoEllbhZ6fi/CshbowFvrnBwQZjpmtE6kiwYaxG5wnNBpyZ/mN+Ky9OeBFRxGuZnq4Y1DokpCur6pJZlWdfAccDSnKaeVmKda/3i1v4QaaRbGsNw307Y9MyRT689cDNhIG9PLi0E2BwfPdsOVSwq6hPzbhVYYUtr3FEQ34R10YRk8mIDtiuEpc94N6GYKLfNnKiaZaxAkz2O8Q0HkQabTfb5837s8DvSL7Q34Orjk01usdVqpTBjSLSZFJBR5GE/iVMClKSJxtfC7RiPVA/neM19FwGoDcpf6Kr17k+LqMhZyy+77MGWz0z6Vr4It4IBmwYlUvQ9IwNpr18k=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(376014)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "J5BG3Fs+ddfqZDDj2R8hK2j+uMCzBIn8aeTAYbWjjsYREwJ2/WcQGB2Pn3GLkiy/twfnEHW5+LscobK/ZlkNIDKm1QCtWcf5Ru2wcH47O7A68roxwTSt2L2A4hF/qUEu81Px3qKE28dyG/YTMnNVDpmCHbsuXrvPASuzycSWgthPxjwf78Ea0gF787PwCI/9GpbAmHekbYTcqa/rEeKgySnLuN0LoHZouSs5c4/73glmK76c2ZWzWFQlxM3xWxdTuV2PcCRLKbW+g/B9U3H/BFzjMdjA4RpF2+diueLlhBfM4grVUWNyIxGG1VCF3qcrB4+oo7VlWQCT2bLPApSnz786ZLFQmVrEb8p9zt+Fm4RmgoSVA7nZNudq59Xt8ukP1zIGww3WsIT33Bdr+Fab/p3JgyoJOJ3N3HZau/4+besBfU4miBhMzYMp6qPXXZ1DVUoZp9eHlcORQO83hEd8YKGBJCXrrBO1KEbh/7ruRJH9yJ/7noEbf9DNYtB3mu3VodoTfGnWPMzshza8J3dqrBmuTvOWgwq31ZoSnC6Xy7f972ftudxR5vU47C3Emq78KylOZHpjjSKChidn5btXKxsLLwYHE+EpqLZRd3cO9jMGH1R5g2l2jketv4zwnH/WvSQBoO21FJURW1MIGNz7UOBRat0JmSrdCKP+O8X0JdCedoSgOWl2oRtb+EPzjL5JtCxdDci6NtWDeE2s1pNlIa7tNkkRFXxzgoJ0iIf5jPZFlAl/qaPSLgfBKCLdKoicy/A1tlvqO92rmeku85mT7wqZV5NXfW+LLu2kNr5QA8MJS0o+lvAD1VHnz30wB+EmTXPV6h4LbIru1AAmfesIP5MiGXUoKf55GRFfBZC3SyY0IWq+BHsK70GOJcEOKPwPnqxVjZOUdn+tNrX2KNIdXKPEBpILkz6sjNaqOQ5XwFuNCLyddSiS5YLSPylZ5QPB4jJsnqKNXiGVU/o0KWi/cWS6j/ki0fy99dP59qet5XRW2eogmwQX1A4fAbGGSRmxsnJd8tW3rp3Vn7ohMbMO4Li1dsGkMm8FKxBI9bhx7BEws1N0FzTMSCuEPg3134CrHwpgCr8G3LUNFr65FPwC9rQFzQ38VIV3rNZ1gnQvUrfKKwqwbFoKUCog1Fxc653INnLfGcCyn126UPLf5qv2ChaN1bOLA5+VtOrdx7HOv7CWWrSRP6nu70vAV6ia/TP/PJvE6xnUcce76cS4Pdzq5WsS3zoiIjFdgVHE+MWsKfQJrNLloWfArCp/ZaBPSLJjEX10KHsx4OEAiTpHRwi7OV+1xHyxeMJ28cDopnpNyV6OfOfyh68/FtO1naOWCiu0B1+pfilGmW+IAYqx9ebsw/GBVIHrHNaue1d/Jwebt3DCC4GgPcVraKBkN7b7DkPr8D3d+Wns8fNyHmAFqFTxN2Ot9qeESn5pmULfGEs3d4Sdlz7cVvf+DD7qkUNzaMFnI1HvzWp5J964IVIzcYA0IVwrlYCfPPE2bWPGgmFcMUiS8NqYBR1CoWacCPZeozi4rKale5VnZpcIuQ5/Jdk6gbNr5ns2+hOW5YSCxjVSYT20uBYTPoahI6otzZZbaw/LviNM6PMSvwZC0aLvsjvnSdtn3qm36adYKAQ53kGUbSiVMIMOvbWw2AcI9OOtTwGouCK4sOBK8BHgN5nlUWwAkQ77TdlQfloIa+onKJeCebodQj76kuRrWb90nY0SpoYsFYT82hYpzvuA87b9R1ZfEZyQrB68DCaPtyOuG7Qt/mg=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "33c9dd89-0ced-402e-950a-08de5a7f4645", "X-MS-Exchange-CrossTenant-AuthSource": "AM9PR04MB8147.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jan 2026 12:59:42.1015\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "4vXXmW0AQZTZlF1mqyFnQtM6jHTDCJPn56lWnI+fPeAS8IIVuZ8IEmqvDvni+YfVnSfC5IoHlaTCUfa4sosJRxcR/RJGXEEJHx6ULHeZcRs=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "GVXPR04MB11690", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The CameraSensor::imageStream() function has a default implementation\nin the base class that returns {0, 0} as {pad, stream}, assuming that\nthe image pad is located on the pad index 0.\nThis assumption is correct most of the time, but not in some other\ncases, for instance when an external ISP entity acts as the sensor.\nSuch entity would typically have sink pad(s) connected to the actual\nsensor and source pad(s) connected to the downstream graph. Associated\npad indexes would likely be different from zero.\n\nCameraSensorLegacy subclass correctly handles this case in its\nfunctions, using the pad_ variable discovered at init() time to access\nthe source pad index, instead of using a hardcoded zero value.\nException is imageStream() that is not overriden in the\nCameraSensorLegacy definition so keeps the default implementation of\nthe parent class, hardcoding the returned source pad index to zero.\n\nThis change declares CameraSensor::imageStream() as a pure virtual to\nlet the subclasses provide an implementation. Implementation for\nCameraSensorLegacy is added, based on pad_ variable usage.\n\nSigned-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>\n---\n include/libcamera/internal/camera_sensor.h | 2 +-\n src/libcamera/sensor/camera_sensor.cpp | 5 +----\n src/libcamera/sensor/camera_sensor_legacy.cpp | 6 ++++++\n 3 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex e6b72d22a..58e7df4a4 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -64,7 +64,7 @@ public:\n \t\t\t\t Transform transform = Transform::Identity,\n \t\t\t\t V4L2SubdeviceFormat *sensorFormat = nullptr) = 0;\n \n-\tvirtual V4L2Subdevice::Stream imageStream() const;\n+\tvirtual V4L2Subdevice::Stream imageStream() const = 0;\n \tvirtual std::optional<V4L2Subdevice::Stream> embeddedDataStream() const;\n \tvirtual V4L2SubdeviceFormat embeddedDataFormat() const;\n \tvirtual int setEmbeddedDataEnabled(bool enable);\ndiff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex 05390d1e1..58affd8f5 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -200,6 +200,7 @@ CameraSensor::~CameraSensor() = default;\n */\n \n /**\n+ * \\fn CameraSensor::imageStream()\n * \\brief Retrieve the image source stream\n *\n * Sensors that produce multiple streams do not guarantee that the image stream\n@@ -209,10 +210,6 @@ CameraSensor::~CameraSensor() = default;\n *\n * \\return The image source stream\n */\n-V4L2Subdevice::Stream CameraSensor::imageStream() const\n-{\n-\treturn { 0, 0 };\n-}\n \n /**\n * \\brief Retrieve the embedded data source stream\ndiff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex 39c34200b..d2583a615 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -84,6 +84,7 @@ public:\n \t\t\t Transform transform = Transform::Identity,\n \t\t\t V4L2SubdeviceFormat *sensorFormat = nullptr) override;\n \n+\tV4L2Subdevice::Stream imageStream() const override;\n \tconst ControlList &properties() const override { return properties_; }\n \tint sensorInfo(IPACameraSensorInfo *info) const override;\n \tTransform computeTransform(Orientation *orientation) const override;\n@@ -856,6 +857,11 @@ int CameraSensorLegacy::applyConfiguration(const SensorConfiguration &config,\n \treturn 0;\n }\n \n+V4L2Subdevice::Stream CameraSensorLegacy::imageStream() const\n+{\n+\treturn { pad_, 0 };\n+}\n+\n int CameraSensorLegacy::sensorInfo(IPACameraSensorInfo *info) const\n {\n \tif (!bayerFormat_)\n", "prefixes": [ "v2", "1/1" ] }