Patch Detail
Show a patch.
GET /api/1.1/patches/25942/?format=api
{ "id": 25942, "url": "https://patchwork.libcamera.org/api/1.1/patches/25942/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25942/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260122170256.4048314-1-barnabas.pocze@ideasonboard.com>", "date": "2026-01-22T17:02:56", "name": "[libcamera-ci,v1] Move kvm tests and cross compilation to debian 13", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c30894ca448f1db6aabdf0e4a471f20a4b7f0d60", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25942/mbox/", "series": [ { "id": 5734, "url": "https://patchwork.libcamera.org/api/1.1/series/5734/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5734", "date": "2026-01-22T17:02:56", "name": "[libcamera-ci,v1] Move kvm tests and cross compilation to debian 13", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5734/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25942/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25942/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7BBC2BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jan 2026 17:03:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D543061FCB;\n\tThu, 22 Jan 2026 18:03:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4F7761F84\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jan 2026 18:03:00 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EC1C4460\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jan 2026 18:02:27 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Oba9mt8P\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769101348;\n\tbh=ihIeH31P1gC5O9cqvjrUBx8SumI92j4N3HfQ4ID2DZY=;\n\th=From:To:Subject:Date:From;\n\tb=Oba9mt8P3D9M0ZgXYIMnU8KWwpv4JrJdjJzSGInzlLC1YECt8exEQ+F+DL0pTD9kd\n\tijbW037Q9deJzZGpf2BjbXT1SugEAQ/63+3TxM6YMaL9N780pbwep0I9ocK17/QZbB\n\tUBPOsyY9iWitc2XNM6tDhCdpSwJmtRsornARDSt4=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [PATCH v1] Move kvm tests and cross compilation to\n\tdebian 13", "Date": "Thu, 22 Jan 2026 18:02:56 +0100", "Message-ID": "<20260122170256.4048314-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Debian 13 is the current stable edition, and virtme-ng 1.18 no longer\ncompiles on debian 12 due to rustc version incompatibilities. So move\nthe kvm tests (and kernel compilation), as well as cross compilation\ntests to debian 13.\n\nAlso update virtme-ng to the latest version (1.40), and remove the\nexit code workaround since the exit code is now propagated to the\nhost[0]. Furthermore, the addition is `--overlay-rwdir` is necessary\notherwise virtme-ng refuses to start:\n\n error: cannot initialize <path> inside the guest (path must be defined inside a valid overlay)\n\nAnd moreover, since virtme-ng now creates an overlay for /tmp by\ndefault[1], and some tests require a /tmp with `O_TMPFILE` support,\n/tmp needs to be mounted as tmpfs before running the tests.\n\nUnfortunately, there is a debian peculiarity that has to be worked\naround. In contrast to debian 12, the `libclang-rt-dev` package does\nnot exist for armhf. So its versioned variant needs to be used.\n\n[0]: https://github.com/arighi/virtme-ng/pull/61\n[1]: https://github.com/arighi/virtme-ng/pull/114\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .gitlab-ci/setup-container.sh | 12 ++++++------\n .gitlab-ci/test-lc-compliance.sh | 5 ++---\n .gitlab-ci/test-libcamera-qemu.sh | 10 +++++++---\n gitlab-ci.yml | 22 +++++++++++-----------\n 4 files changed, 26 insertions(+), 23 deletions(-)\n\n--\n2.52.0", "diff": "diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh\nindex 2ba94bb..3506271 100755\n--- a/.gitlab-ci/setup-container.sh\n+++ b/.gitlab-ci/setup-container.sh\n@@ -132,9 +132,6 @@ case $FDO_DISTRIBUTION_VERSION in\n \tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libclang-rt-dev )\n \t# For the Android camera HAL and the virtual pipeline handler.\n \tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libyuv-dev )\n-\t# For cam and lc-compliance\n-\t# libevent-dev cannot be used here, see build-libcamera-common.sh\n-\tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libevent-2.1-7 libevent-pthreads-2.1-7 )\n \t;;\n 'trixie')\n \t# gcc 13 to expand compilation testing coverage.\n@@ -142,15 +139,18 @@ case $FDO_DISTRIBUTION_VERSION in\n \t# Sphinx theme for the documentation.\n \tPKGS_LIBCAMERA_RUNTIME+=( python3-sphinx-book-theme )\n \t# libclang-rt-dev for the clang ASan runtime.\n-\tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libclang-rt-dev )\n+\tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libclang-rt-19-dev )\n \t# For the Android camera HAL and the virtual pipeline handler.\n \tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libyuv-dev )\n+\t# For lc-compliance in the `test-lc-compliance:virtual` job\n+\t# libevent-dev cannot be used here, see build-libcamera-common.sh\n+\tPKGS_LIBCAMERA_RUNTIME_MULTIARCH+=( libevent-2.1-7t64 libevent-pthreads-2.1-7t64 )\n \t;;\n esac\n\n-# We use Debian bookworm containers to produce ARM binaries and run unit tests\n+# We use Debian 13 (trixie) containers to produce ARM binaries and run unit tests\n # with virtme, and other Debian versions for compilation-testing on amd64 only.\n-if [[ $FDO_DISTRIBUTION_VERSION == 'bookworm' ]] ; then\n+if [[ $FDO_DISTRIBUTION_VERSION == 'trixie' ]] ; then\n \tarchs+=( arm64 armhf )\n \tcomponents['kernel']=1\n \tcomponents['virtme']=1\ndiff --git a/.gitlab-ci/test-lc-compliance.sh b/.gitlab-ci/test-lc-compliance.sh\nindex 6208723..d4ae838 100755\n--- a/.gitlab-ci/test-lc-compliance.sh\n+++ b/.gitlab-ci/test-lc-compliance.sh\n@@ -14,6 +14,7 @@ libcamera_compliance() {\n \t\t--verbose \\\n \t\t--skip-modules \\\n \t\t--force-9p \\\n+\t\t--overlay-rwdir \"$PWD\" \\\n \t\t--rwdir \"$PWD/build\" \\\n \t\t--run /opt/linux/bzImage \\\n \t\t--exec \" \\\n@@ -25,12 +26,10 @@ libcamera_compliance() {\n \t\t\tUBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 \\\n \t\t\tGTEST_OUTPUT=xml:./build/lc-compliance-report.xml \\\n \t\t\tlc-compliance -c Virtual0; \\\n-\t\t\techo \\\\\\$? > ./build/.test-status; \\\n \t\t\"\n\n-\tlocal status=$(cat build/.test-status)\n+\tlocal status=$?\n \techo \"Test result exit state: $status\"\n-\trm build/.test-status\n\n \tif [[ $status != 0 ]] ; then\n \t\texit $status\ndiff --git a/.gitlab-ci/test-libcamera-qemu.sh b/.gitlab-ci/test-libcamera-qemu.sh\nindex f9de5ab..8a588a5 100755\n--- a/.gitlab-ci/test-libcamera-qemu.sh\n+++ b/.gitlab-ci/test-libcamera-qemu.sh\n@@ -24,13 +24,17 @@ libcamera_unit_test() {\n \techo \"Running libcamera tests in a qemu VM\"\n\n \tvirtme-ng --verbose --skip-modules --force-9p \\\n+\t\t--overlay-rwdir \"$PWD\" \\\n \t\t--rwdir \"$PWD/build\" \\\n \t\t--run /opt/linux/bzImage \\\n-\t\t--exec \"meson test -C build --no-rebuild --print-errorlogs; echo \\\\\\$? > build/.test-status\"\n+\t\t--exec \" \\\n+\t\t\tset -ex;\n+\t\t\tmount -t tmpfs tmpfs /tmp/;\n+\t\t\tmeson test -C build --no-rebuild --print-errorlogs; \\\n+\t\t\"\n\n-\tlocal status=$(cat build/.test-status)\n+\tlocal status=$?\n \techo \"Test result exit state: $status\"\n-\trm build/.test-status\n\n \tif [[ $status != 0 ]] ; then\n \t\texit $status\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex b1d5f0e..50fc6c6 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -34,7 +34,7 @@ variables:\n ca-certificates\n git\n VIRTME_GIT_URL: 'https://github.com/arighi/virtme-ng.git'\n- VIRTME_GIT_REF: 'v1.18'\n+ VIRTME_GIT_REF: 'v1.40'\n\n # Jobs that test individual commits need more history to find the common\n # ancestor of the branch being tested and the default branch. Fetch up to 100\n@@ -65,12 +65,12 @@ include:\n .libcamera-ci.debian:12:\n variables:\n FDO_DISTRIBUTION_VERSION: 'bookworm'\n- FDO_DISTRIBUTION_TAG: '2025-11-02.0'\n+ FDO_DISTRIBUTION_TAG: '2026-01-22.0'\n\n .libcamera-ci.debian:13:\n variables:\n FDO_DISTRIBUTION_VERSION: 'trixie'\n- FDO_DISTRIBUTION_TAG: '2025-11-02.0'\n+ FDO_DISTRIBUTION_TAG: '2026-01-22.0'\n\n .container-debian:\n extends:\n@@ -208,8 +208,6 @@ build-full:debian:12:\n ${MESON_ALL_OPTIONS}\n ${MESON_CLANG_OPTIONS}\n -D qcam=disabled\n- - ARCH: armhf\n- - ARCH: arm64\n\n build-full:debian:13:\n extends:\n@@ -241,6 +239,8 @@ build-full:debian:13:\n -D cpp_debugstl=false\n # `cpp_debugstl=false` needed approximately between meson 1.4.0 and 1.9.3\n # with clang 18 or later due to https://github.com/mesonbuild/meson/issues/13812\n+ - ARCH: armhf\n+ - ARCH: arm64\n\n # Build each commit in the branch individually to detect compilation breakages.\n build-history:\n@@ -267,11 +267,11 @@ build-history:\n build-package:debug:\n extends:\n - .fdo.distribution-image@debian\n- - .libcamera-ci.debian:12\n+ - .libcamera-ci.debian:13\n - .libcamera-ci.scripts\n stage: build\n needs:\n- - job: container-debian:12\n+ - job: container-debian:13\n artifacts: false\n script:\n - $CI_PROJECT_DIR/.gitlab-ci/build-libcamera.sh\n@@ -366,11 +366,11 @@ merge-check:\n test-unit:\n extends:\n - .fdo.distribution-image@debian\n- - .libcamera-ci.debian:12\n+ - .libcamera-ci.debian:13\n - .libcamera-ci.scripts\n stage: test\n needs:\n- - job: container-debian:12\n+ - job: container-debian:13\n artifacts: false\n tags:\n - kvm\n@@ -404,7 +404,7 @@ test-unit:\n test-lc-compliance:virtual:\n extends:\n - .fdo.distribution-image@debian\n- - .libcamera-ci.debian:12\n+ - .libcamera-ci.debian:13\n - .libcamera-ci.scripts\n stage: test\n needs:\n@@ -412,7 +412,7 @@ test-lc-compliance:virtual:\n parallel:\n matrix:\n - ARCH: amd64\n- - job: container-debian:12\n+ - job: container-debian:13\n artifacts: false\n tags:\n - kvm\n", "prefixes": [ "libcamera-ci", "v1" ] }