Patch Detail
Show a patch.
GET /api/1.1/patches/25924/?format=api
{ "id": 25924, "url": "https://patchwork.libcamera.org/api/1.1/patches/25924/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25924/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<176907326823.3882822.2987303171422721170@neptunite.rasen.tech>", "date": "2026-01-22T09:14:28", "name": "[v1,01/35] libcamera: delayed_controls: Add push() function that accepts a sequence number", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5aa66957c334b2be61c6c5bad98df979b14d81a0", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25924/mbox/", "series": [ { "id": 5731, "url": "https://patchwork.libcamera.org/api/1.1/series/5731/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5731", "date": "2026-01-22T09:14:28", "name": "[v1,01/35] libcamera: delayed_controls: Add push() function that accepts a sequence number", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5731/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25924/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25924/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2EC0BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Jan 2026 09:14:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2D0361FC9;\n\tThu, 22 Jan 2026 10:14:38 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C6A761FA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Jan 2026 10:14:37 +0100 (CET)", "from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:8816:a947:ebed:2ec7])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E50B4324;\n\tThu, 22 Jan 2026 10:14:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lBn1SB16\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769073244;\n\tbh=Mq3VgjPOmUWN56f+Ki6jAqTBRtkRzgg1fUaSbXT/GwU=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=lBn1SB16YRPE0f5qYBs8vD8dop+OtT5Zyk7ypjNe0aqoh8/Jtv7IyWm248QZTUJOO\n\tCodF0dOvdP3G+ReI930KUvYGBjDAlHm9zySoaekS4N1hFQ5Pw5cA6hJWC+Rebk1u8I\n\tFvWVp6pHba8DI0yJuyXAVRxXHNOeH50ssUTOACfk=", "Content-Type": "text/plain; charset=\"utf-8\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "In-Reply-To": "<20251024085130.995967-1-stefan.klug@ideasonboard.com>", "References": "<20251024085130.995967-1-stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 01/35] libcamera: delayed_controls: Add push() function\n\tthat accepts a sequence number", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Thu, 22 Jan 2026 18:14:28 +0900", "Message-ID": "<176907326823.3882822.2987303171422721170@neptunite.rasen.tech>", "User-Agent": "alot/0.0.0", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The push function is asymmetric to the get() and applyControls()\nfunction in that it doesn't allow to specify a frame number. This leads\nto the unfortunate situation that it is very difficult to detect if\nanything goes out of sync. Add a version of the push() function that\ntakes a sequence parameter and warns when the sequence provided differs\nfrom the expected sequence. Don't take any further actions for now to\nsee where issues pop up.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\nLooks good to me.\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n include/libcamera/internal/delayed_controls.h | 1 +\n src/libcamera/delayed_controls.cpp | 32 ++++++++++++++++++-\n 2 files changed, 32 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/delayed_controls.h b/include/libcamera/internal/delayed_controls.h\nindex b64d8bba7cf7..c650e672d964 100644\n--- a/include/libcamera/internal/delayed_controls.h\n+++ b/include/libcamera/internal/delayed_controls.h\n@@ -32,6 +32,7 @@ public:\n void reset();\n \n bool push(const ControlList &controls);\n+ bool push(uint32_t sequence, const ControlList &controls);\n ControlList get(uint32_t sequence);\n \n void applyControls(uint32_t sequence);\ndiff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\nindex 94d0a575b01b..246e7cefa4e5 100644\n--- a/src/libcamera/delayed_controls.cpp\n+++ b/src/libcamera/delayed_controls.cpp\n@@ -144,10 +144,40 @@ void DelayedControls::reset()\n * Push a set of controls to the control queue. This increases the control queue\n * depth by one.\n *\n+ * \\note The usage of this function is discouraged as it does not provide a way\n+ * to detect double pushes for the same sequence. Better\n+ * DelayedControls::push(uint32_t sequence, const ControlList &controls)\n+ * instead.\n+ *\n * \\returns true if \\a controls are accepted, or false otherwise\n */\n bool DelayedControls::push(const ControlList &controls)\n {\n+ LOG(DelayedControls, Debug) << \"Deprecated: Push without sequence number\";\n+ return push(queueCount_, controls);\n+}\n+\n+/**\n+ * \\brief Push a set of controls on the queue\n+ * \\param[in] sequence The sequence number to push for\n+ * \\param[in] controls List of controls to add to the device queue\n+ *\n+ * Push a set of controls to the control queue. This increases the control queue\n+ * depth by one.\n+ *\n+ * The \\a sequence number is used to do some sanity checks to detect double\n+ * pushes for the same sequence (either due to a bug or a request underrun).\n+ *\n+ * \\returns true if \\a controls are accepted, or false otherwise\n+ */\n+bool DelayedControls::push(uint32_t sequence, const ControlList &controls)\n+{\n+ if (sequence < queueCount_) {\n+ LOG(DelayedControls, Warning)\n+ << \"Double push for sequence \" << sequence\n+ << \" current queue index: \" << queueCount_;\n+ }\n+\n /* Copy state from previous frame. */\n for (auto &ctrl : values_) {\n Info &info = ctrl.second[queueCount_];\n@@ -276,7 +306,7 @@ void DelayedControls::applyControls(uint32_t sequence)\n while (writeCount_ > queueCount_) {\n LOG(DelayedControls, Debug)\n << \"Queue is empty, auto queue no-op.\";\n- push({});\n+ push(queueCount_, {});\n }\n \n device_->setControls(&out);\n", "prefixes": [ "v1", "01/35" ] }